)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77c4b8737e1be683d7a49a8c4be369fe8dc9a5c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 17:17:31 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass the req_dest fielf of ReqSpec in the filter props"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we added the requested_destination field for the RequestSpec object"},{"line_number":10,"context_line":"in Newton, we forgot to pass it to the legacy dictionary when wanting to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_743c4b2e","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":23},"updated":"2017-07-06 15:34:32.000000000","message":"field","commit_id":"be80e9dfbfc133d13cc670d7d85d6a1fefe05009"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77c4b8737e1be683d7a49a8c4be369fe8dc9a5c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"use scheduler methods not yet supporting the NovaObject."},{"line_number":12,"context_line":"As a consequence, when we were transforming the RequestSpec object into a"},{"line_number":13,"context_line":"tuple of (request_spec, filter_props) dicts and then rehydrating a new"},{"line_number":14,"context_line":"RequestSpec object using those dicts, it was not staying the requested_dest field."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adding now it to the legacy filter_properties dict so."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_d40c3f95","line":14,"range":{"start_line":14,"start_character":61,"end_line":14,"end_character":75},"updated":"2017-07-06 15:34:32.000000000","message":"Please be consistent with the name of the actual field in here, you\u0027ve used 3 different names now.","commit_id":"be80e9dfbfc133d13cc670d7d85d6a1fefe05009"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77c4b8737e1be683d7a49a8c4be369fe8dc9a5c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"use scheduler methods not yet supporting the NovaObject."},{"line_number":12,"context_line":"As a consequence, when we were transforming the RequestSpec object into a"},{"line_number":13,"context_line":"tuple of (request_spec, filter_props) dicts and then rehydrating a new"},{"line_number":14,"context_line":"RequestSpec object using those dicts, it was not staying the requested_dest field."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adding now it to the legacy filter_properties dict so."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_942a47d8","line":14,"range":{"start_line":14,"start_character":49,"end_line":14,"end_character":56},"updated":"2017-07-06 15:34:32.000000000","message":"keeping?","commit_id":"be80e9dfbfc133d13cc670d7d85d6a1fefe05009"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77c4b8737e1be683d7a49a8c4be369fe8dc9a5c5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tuple of (request_spec, filter_props) dicts and then rehydrating a new"},{"line_number":14,"context_line":"RequestSpec object using those dicts, it was not staying the requested_dest field."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adding now it to the legacy filter_properties dict so."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iba0b88172e9a3bfd4f216dd364d70f7e01c60ee2"},{"line_number":19,"context_line":"Closes-Bug: #1702454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_147cf7e9","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":54},"updated":"2017-07-06 15:34:32.000000000","message":"huh?","commit_id":"be80e9dfbfc133d13cc670d7d85d6a1fefe05009"}],"nova/objects/request_spec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9561e33d1bee817bc9d5c9e8e12fee09b71691d2","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        spec._populate_group_info(filter_properties)"},{"line_number":265,"context_line":"        scheduler_hints \u003d filter_properties.get(\u0027scheduler_hints\u0027, {})"},{"line_number":266,"context_line":"        spec._from_hints(scheduler_hints)"},{"line_number":267,"context_line":"        spec.requested_destination \u003d filter_properties.get("},{"line_number":268,"context_line":"            \u0027requested_destination\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        # NOTE(sbauza): Default the other fields that are not part of the"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_1c5bdb54","line":267,"range":{"start_line":267,"start_character":37,"end_line":267,"end_character":54},"updated":"2017-10-28 17:11:39.000000000","message":"Use request_spec.","commit_id":"0fcdbbac8b9b5faa18a1b7e45c9b9e7df1667dd5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9561e33d1bee817bc9d5c9e8e12fee09b71691d2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                \u0027group_hosts\u0027: set(self.instance_group.hosts),"},{"line_number":325,"context_line":"                \u0027group_policies\u0027: set(self.instance_group.policies)}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def to_legacy_request_spec_dict(self):"},{"line_number":328,"context_line":"        \"\"\"Returns a legacy request_spec dict from the RequestSpec object."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        Since we need to manage backwards compatibility and rolling upgrades"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_fc57df25","line":327,"range":{"start_line":327,"start_character":8,"end_line":327,"end_character":35},"updated":"2017-10-28 17:11:39.000000000","message":"requested_destination was never a filter_properties field, so I\u0027d store it in here. Are you doing it in filter_properties because of from_components?","commit_id":"0fcdbbac8b9b5faa18a1b7e45c9b9e7df1667dd5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93c5d1d2ca579a8af4b243dac17c7954fb6bf058","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                hint) for hint in self.scheduler_hints}"},{"line_number":376,"context_line":"        if self.obj_attr_is_set(\u0027requested_destination\u0027"},{"line_number":377,"context_line":"                                ) and self.requested_destination:"},{"line_number":378,"context_line":"            filt_props[\u0027requested_destination\u0027] \u003d self.requested_destination"},{"line_number":379,"context_line":"        return filt_props"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_5cbb9371","line":378,"updated":"2017-10-28 17:03:25.000000000","message":"It seems weird to put this in the filter_properties dict, as nothing in the scheduler reads requested_destination from the filter_properties dict. I guess this is just a place to shove it until from_primitives is called? I was more expecting to break apart the requested_destination and use it\u0027s host/node to put into the force_hosts and force_nodes fields. But then the problem is when you do from_primitives, you wouldn\u0027t know if you should set requested_destination or not.\n\nAlso, shouldn\u0027t the Destination object be converted to a primitive and then in from_primitives, you\u0027d convert back to an Object?","commit_id":"0fcdbbac8b9b5faa18a1b7e45c9b9e7df1667dd5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7cf45a470e8f570c1b74db424c5eb450efe05e29","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            req_spec[\u0027instance_type\u0027] \u003d {}"},{"line_number":347,"context_line":"        return req_spec"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def to_legacy_filter_properties_dict(self):"},{"line_number":350,"context_line":"        \"\"\"Returns a legacy filter_properties dict from the RequestSpec object."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        Since we need to manage backwards compatibility and rolling upgrades"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_5dadcae8","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":40},"updated":"2017-10-29 16:04:55.000000000","message":"There is no test for this method.","commit_id":"5102839eda1aa10eb163cfc10b1e7efc7b73e71b"}]}