)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"5c9013835ad254c2002dfdd23e00cdffe55f3e40","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        block_device_mapping \u003d virt_driver.block_device_info_get_mapping("},{"line_number":885,"context_line":"            block_device_info)"},{"line_number":886,"context_line":"        if block_device_mapping:"},{"line_number":887,"context_line":"            # TODO(mriedem): We should be able to get the BDMs out of the"},{"line_number":888,"context_line":"            # block_device_info[\u0027block_device_mapping\u0027] field, however, that"},{"line_number":889,"context_line":"            # is a list of DriverVolumeBlockDevice objects and do not currently"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_82d99ff5","line":886,"updated":"2017-07-10 09:27:23.000000000","message":"Why not keep this as \"if block_device_info\" and get the mapping within the if?\nOf course, currently there\u0027s no benefit getting the mapping either until the tag attribute is proxied...","commit_id":"151242ab7175242383a212015bb781ac6f7804fb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ba4497f92018da4bbe7786995a48b33b82c6e70","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        block_device_mapping \u003d virt_driver.block_device_info_get_mapping("},{"line_number":885,"context_line":"            block_device_info)"},{"line_number":886,"context_line":"        if block_device_mapping:"},{"line_number":887,"context_line":"            # TODO(mriedem): We should be able to get the BDMs out of the"},{"line_number":888,"context_line":"            # block_device_info[\u0027block_device_mapping\u0027] field, however, that"},{"line_number":889,"context_line":"            # is a list of DriverVolumeBlockDevice objects and do not currently"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_af0209b3","line":886,"in_reply_to":"3f1d235d_82d99ff5","updated":"2017-07-11 18:09:36.000000000","message":"Because \"if block_device_info\" will always be true because it will at a minimum have an empty \u0027mappings\u0027 dict within it. I found that out when unit testing this.","commit_id":"151242ab7175242383a212015bb781ac6f7804fb"}]}