)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2090d7299f2ac488f4f193ca4cffb72a0e6af75d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 10:08:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add device tag support info in support matrix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The virtual device tagging support was added for several"},{"line_number":10,"context_line":"hypervisors and it\u0027s useful to document in the support"},{"line_number":11,"context_line":"matrix to provide more info to user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idab929904aaba924f9f1f4814ff959de01f72f83"},{"line_number":14,"context_line":"Related-Bug: 1701421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_05a46707","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":36},"updated":"2017-07-10 17:42:46.000000000","message":"I\u0027d word it like follows (however this is perfectly understandable!)\n\n  Document device tags in support matrix\n\n  XenAPI, HyperV and libvirt support device tags. This patch\n  documents this in the support matrix.","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8e12e0f696b6ba814315ed262091518f50486e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 10:08:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add device tag support info in support matrix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The virtual device tagging support was added for several"},{"line_number":10,"context_line":"hypervisors and it\u0027s useful to document in the support"},{"line_number":11,"context_line":"matrix to provide more info to user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idab929904aaba924f9f1f4814ff959de01f72f83"},{"line_number":14,"context_line":"Related-Bug: 1701421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_e71d2a10","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":36},"in_reply_to":"3f1d235d_05a46707","updated":"2017-07-12 09:46:31.000000000","message":"Done","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"}],"doc/source/support-matrix.ini":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2090d7299f2ac488f4f193ca4cffb72a0e6af75d","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"driver-impl-libvirt-vz-ct\u003dmissing"},{"line_number":1205,"context_line":"driver-impl-powervm\u003dmissing"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_4a4b8e86","line":1207,"range":{"start_line":1207,"start_character":11,"end_line":1207,"end_character":33},"updated":"2017-07-10 17:42:46.000000000","message":"Let\u0027s change this too to match whatever \"title\" ends up being (I\u0027m +1 with Matt on \"Device tags\")","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8e12e0f696b6ba814315ed262091518f50486e9","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"driver-impl-libvirt-vz-ct\u003dmissing"},{"line_number":1205,"context_line":"driver-impl-powervm\u003dmissing"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f1a1f67_a7bbb20c","line":1207,"range":{"start_line":1207,"start_character":11,"end_line":1207,"end_character":33},"in_reply_to":"3f1d235d_4a4b8e86","updated":"2017-07-12 09:46:31.000000000","message":"Done","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88ad95ab763edac83ea1a6f09259d0e464b5d3b6","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"driver-impl-powervm\u003dmissing"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1211,"context_line":"cli\u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_645fa4e5","line":1208,"range":{"start_line":1208,"start_character":6,"end_line":1208,"end_character":28},"updated":"2017-07-10 15:17:45.000000000","message":"Device tags","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8e12e0f696b6ba814315ed262091518f50486e9","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"driver-impl-powervm\u003dmissing"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1211,"context_line":"cli\u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f1a1f67_873676b4","line":1208,"range":{"start_line":1208,"start_character":6,"end_line":1208,"end_character":28},"in_reply_to":"3f1d235d_645fa4e5","updated":"2017-07-12 09:46:31.000000000","message":"Done","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88ad95ab763edac83ea1a6f09259d0e464b5d3b6","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1211,"context_line":"cli\u003d"},{"line_number":1212,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1213,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_e4cf3455","line":1210,"range":{"start_line":1210,"start_character":6,"end_line":1210,"end_character":53},"updated":"2017-07-10 15:17:45.000000000","message":"We should explain this in more detail. Borrowing from the REST API Version History and compute API reference, maybe something like:\n\n\"Device tags are used to identify virtual device metadata, as exposed in the metadata API and on the config drive. For example, a network interface on the virtual PCI bus tagged with ‘nic1’ will appear in the metadata along with its bus (PCI), bus address (ex: 0000:00:02.0), MAC address, and tag (‘nic1’). If multiple networks are defined, the order in which they appear in the guest operating system will not necessarily reflect the order in which they are given in the server boot request. Guests should therefore not depend on device order to deduce any information about their network devices. Instead, device role tags should be used. Device tags apply to virtual network interfaces and block devices.\"","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8e12e0f696b6ba814315ed262091518f50486e9","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"[operation.support-device-tagging]"},{"line_number":1208,"context_line":"title\u003dsupport device tagging"},{"line_number":1209,"context_line":"status\u003doptional"},{"line_number":1210,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1211,"context_line":"cli\u003d"},{"line_number":1212,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1213,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f1a1f67_27456218","line":1210,"range":{"start_line":1210,"start_character":6,"end_line":1210,"end_character":53},"in_reply_to":"3f1d235d_e4cf3455","updated":"2017-07-12 09:46:31.000000000","message":"ok, I copied above as this is helpful and complete","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88ad95ab763edac83ea1a6f09259d0e464b5d3b6","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"},{"line_number":1215,"context_line":"driver-impl-libvirt-kvm-s390x\u003dcomplete"},{"line_number":1216,"context_line":"driver-impl-libvirt-qemu-x86\u003dcomplete"},{"line_number":1217,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1218,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1219,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1220,"context_line":"driver-impl-hyperv\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_c4f55885","line":1217,"range":{"start_line":1217,"start_character":24,"end_line":1217,"end_character":32},"updated":"2017-07-10 15:17:45.000000000","message":"I\u0027m not sure about this. Just because the libvirt driver supports something doesn\u0027t mean it also works in lxc.","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2090d7299f2ac488f4f193ca4cffb72a0e6af75d","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"},{"line_number":1215,"context_line":"driver-impl-libvirt-kvm-s390x\u003dcomplete"},{"line_number":1216,"context_line":"driver-impl-libvirt-qemu-x86\u003dcomplete"},{"line_number":1217,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1218,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1219,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1220,"context_line":"driver-impl-hyperv\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_eabb7a6f","line":1217,"range":{"start_line":1217,"start_character":24,"end_line":1217,"end_character":32},"in_reply_to":"3f1d235d_c4f55885","updated":"2017-07-10 17:42:46.000000000","message":"I\u0027m fairly confident it works for nics at least (albeit with only their MAC address I suspect, not PCI)","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8e12e0f696b6ba814315ed262091518f50486e9","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"},{"line_number":1215,"context_line":"driver-impl-libvirt-kvm-s390x\u003dcomplete"},{"line_number":1216,"context_line":"driver-impl-libvirt-qemu-x86\u003dcomplete"},{"line_number":1217,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1218,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1219,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1220,"context_line":"driver-impl-hyperv\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f1a1f67_a769728c","line":1217,"range":{"start_line":1217,"start_character":24,"end_line":1217,"end_character":32},"in_reply_to":"3f1d235d_eabb7a6f","updated":"2017-07-12 09:46:31.000000000","message":"this might need further test while I don\u0027t have env to work on ... maybe post a mail and ask? for now , we can say it\u0027s missing and update it later after test?","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88ad95ab763edac83ea1a6f09259d0e464b5d3b6","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1221,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1222,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1223,"context_line":"driver-impl-libvirt-vz-ct\u003dcomplete"},{"line_number":1224,"context_line":"driver-impl-powervm\u003dmissing"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f1d235d_24d08cc9","line":1223,"range":{"start_line":1223,"start_character":26,"end_line":1223,"end_character":34},"updated":"2017-07-10 15:17:45.000000000","message":"same as lxc","commit_id":"cfc660dbd6010c22fafce26178413bc541cb039b"}],"doc/source/user/support-matrix.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7fb1a69bf6bd8c7c62d190a400b26cae810d8560","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.support-device-tagging]"},{"line_number":1234,"context_line":"title\u003dsupport device tagging"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1237,"context_line":"cli\u003d"},{"line_number":1238,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1239,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ff346bd7_599c300d","line":1236,"range":{"start_line":1236,"start_character":27,"end_line":1236,"end_character":38},"updated":"2017-07-27 13:17:47.000000000","message":"set tags on\n\n set a tag on\n\nor just \n\n tag\n\nAnd a period at the end.","commit_id":"49651c28b6bd84042f5de20fccd8d63f5a525f6e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"84a989d4fbeaa62c5aff69ebe38dead050af9c7e","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.support-device-tagging]"},{"line_number":1234,"context_line":"title\u003dsupport device tagging"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices"},{"line_number":1237,"context_line":"cli\u003d"},{"line_number":1238,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1239,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":5,"id":"df3967d1_22661353","line":1236,"range":{"start_line":1236,"start_character":27,"end_line":1236,"end_character":38},"in_reply_to":"ff346bd7_599c300d","updated":"2017-08-02 08:33:11.000000000","message":"Done","commit_id":"49651c28b6bd84042f5de20fccd8d63f5a525f6e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1725acad8064b6d1125d2ce8dabacf64163cab0a","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.support-device-tagging]"},{"line_number":1234,"context_line":"title\u003dsupport device tagging"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to tag virtual devices."},{"line_number":1237,"context_line":"cli\u003d"},{"line_number":1238,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1239,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_8ad02d21","line":1236,"range":{"start_line":1236,"start_character":6,"end_line":1236,"end_character":47},"updated":"2017-08-11 12:26:17.000000000","message":"i think some rebase issue occurred. You added detail in PS2 but not in latest one. Please add those.","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a74ce9196cb0e23b07720c8c6006155456d74eff","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.support-device-tagging]"},{"line_number":1234,"context_line":"title\u003dsupport device tagging"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to tag virtual devices."},{"line_number":1237,"context_line":"cli\u003d"},{"line_number":1238,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1239,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_1387b511","line":1236,"range":{"start_line":1236,"start_character":6,"end_line":1236,"end_character":47},"in_reply_to":"9f436f4f_8ad02d21","updated":"2017-08-14 07:14:01.000000000","message":"right, it\u0027s because of rebase... thanks for finding this","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1725acad8064b6d1125d2ce8dabacf64163cab0a","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"},{"line_number":1241,"context_line":"driver-impl-libvirt-kvm-s390x\u003dcomplete"},{"line_number":1242,"context_line":"driver-impl-libvirt-qemu-x86\u003dcomplete"},{"line_number":1243,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1244,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_0aa2fdae","line":1243,"range":{"start_line":1243,"start_character":24,"end_line":1243,"end_character":32},"updated":"2017-08-11 12:26:17.000000000","message":"i think we should mark it not known (?) till we have enough test proof.","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a74ce9196cb0e23b07720c8c6006155456d74eff","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"},{"line_number":1241,"context_line":"driver-impl-libvirt-kvm-s390x\u003dcomplete"},{"line_number":1242,"context_line":"driver-impl-libvirt-qemu-x86\u003dcomplete"},{"line_number":1243,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1244,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_9399657a","line":1243,"range":{"start_line":1243,"start_character":24,"end_line":1243,"end_character":32},"in_reply_to":"9f436f4f_0aa2fdae","updated":"2017-08-14 07:14:01.000000000","message":"Done","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1725acad8064b6d1125d2ce8dabacf64163cab0a","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1244,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1247,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1248,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-vz-ct\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_6a90694f","line":1246,"range":{"start_line":1246,"start_character":19,"end_line":1246,"end_character":27},"updated":"2017-08-11 12:26:17.000000000","message":"are we testing it with hyperV. I can test it as i have my PoV env ready with HyperV","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a74ce9196cb0e23b07720c8c6006155456d74eff","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"driver-impl-libvirt-lxc\u003dcomplete"},{"line_number":1244,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1247,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1248,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-vz-ct\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_d3936d5a","line":1246,"range":{"start_line":1246,"start_character":19,"end_line":1246,"end_character":27},"in_reply_to":"9f436f4f_6a90694f","updated":"2017-08-14 07:14:01.000000000","message":"yes, if you have ,I will update it to unknow first","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1725acad8064b6d1125d2ce8dabacf64163cab0a","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1247,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1248,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-vz-ct\u003dcomplete"},{"line_number":1250,"context_line":"driver-impl-powervm\u003dmissing"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_4a9fe55e","line":1249,"range":{"start_line":1248,"start_character":26,"end_line":1249,"end_character":34},"updated":"2017-08-11 12:26:17.000000000","message":"ditto as lxc","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a74ce9196cb0e23b07720c8c6006155456d74eff","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1246,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1247,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1248,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-vz-ct\u003dcomplete"},{"line_number":1250,"context_line":"driver-impl-powervm\u003dmissing"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9f436f4f_f396714c","line":1249,"range":{"start_line":1248,"start_character":26,"end_line":1249,"end_character":34},"in_reply_to":"9f436f4f_4a9fe55e","updated":"2017-08-14 07:14:01.000000000","message":"Done","commit_id":"ccd017a8ffe980625d3991e0e90faebd7df1814b"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"de3ef3f725c49f0c98d10c968df72d699490dba9","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices,Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":7,"id":"9f436f4f_5f977ced","line":1236,"range":{"start_line":1236,"start_character":53,"end_line":1236,"end_character":55},"updated":"2017-08-14 10:18:07.000000000","message":"s/,/\\. /","commit_id":"c97b6e9b1899cfa7af281c7838a4e831fcf68c4f"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"de3ef3f725c49f0c98d10c968df72d699490dba9","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"  the order in which they are given in the server boot request."},{"line_number":1244,"context_line":"  Guests should therefore not depend on device order to deduce any information"},{"line_number":1245,"context_line":"  about their network devices. Instead, device role tags should be used."},{"line_number":1246,"context_line":"  Device tags apply to virtual network interfaces and block devices"},{"line_number":1247,"context_line":"cli\u003d"},{"line_number":1248,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":7,"id":"9f436f4f_9f9044ef","line":1246,"updated":"2017-08-14 10:18:07.000000000","message":"Period at the end.","commit_id":"c97b6e9b1899cfa7af281c7838a4e831fcf68c4f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_0e50ced3","line":1236,"range":{"start_line":1236,"start_character":27,"end_line":1236,"end_character":53},"updated":"2017-08-25 20:11:13.000000000","message":"\u0027tag virtual devices\u0027, or \u0027set tags on virtual devices\u0027","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12edad351ff941ca7a90e4c73c186fd6c5e62d79","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_aef3fa09","line":1236,"range":{"start_line":1236,"start_character":53,"end_line":1236,"end_character":54},"updated":"2017-08-25 20:07:47.000000000","message":".","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_ced52645","line":1236,"range":{"start_line":1236,"start_character":53,"end_line":1236,"end_character":54},"updated":"2017-08-25 20:11:13.000000000","message":"Should be a period.","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7e5455ce5666bf1df8c4b1e09bde5ed4518ccd0","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_4e46d623","line":1236,"range":{"start_line":1236,"start_character":6,"end_line":1236,"end_character":53},"updated":"2017-08-25 20:08:37.000000000","message":"This isn\u0027t clear if you can set the device tags at server create or during an attach. So maybe this should say, \"This allows users to set tags on virtual devices when creating a server.\"","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12edad351ff941ca7a90e4c73c186fd6c5e62d79","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"[operation.device-tags]"},{"line_number":1234,"context_line":"title\u003dDevice tags"},{"line_number":1235,"context_line":"status\u003doptional"},{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_eee9021a","line":1236,"range":{"start_line":1236,"start_character":31,"end_line":1236,"end_character":37},"updated":"2017-08-25 20:07:47.000000000","message":"tags on","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"},{"line_number":1240,"context_line":"  with its bus (PCI), bus address (ex: 0000:00:02.0), MAC address, and"},{"line_number":1241,"context_line":"  tag (.nic1.). If multiple networks are defined, the order in which"},{"line_number":1242,"context_line":"  they appear in the guest operating system will not necessarily reflect"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_8ecf1eaf","line":1239,"range":{"start_line":1239,"start_character":30,"end_line":1239,"end_character":36},"updated":"2017-08-25 20:11:13.000000000","message":"Is .\u003csomething\u003e. weird syntax I\u0027m not familiar with?","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12edad351ff941ca7a90e4c73c186fd6c5e62d79","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"notes\u003dThis allows users to set tag to virtual devices, Device tags are"},{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"},{"line_number":1240,"context_line":"  with its bus (PCI), bus address (ex: 0000:00:02.0), MAC address, and"},{"line_number":1241,"context_line":"  tag (.nic1.). If multiple networks are defined, the order in which"},{"line_number":1242,"context_line":"  they appear in the guest operating system will not necessarily reflect"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_eed2225c","line":1239,"range":{"start_line":1239,"start_character":30,"end_line":1239,"end_character":36},"updated":"2017-08-25 20:07:47.000000000","message":"``nic1``","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"  used to identify virtual device metadata, as exposed in the metadata"},{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"},{"line_number":1240,"context_line":"  with its bus (PCI), bus address (ex: 0000:00:02.0), MAC address, and"},{"line_number":1241,"context_line":"  tag (.nic1.). If multiple networks are defined, the order in which"},{"line_number":1242,"context_line":"  they appear in the guest operating system will not necessarily reflect"},{"line_number":1243,"context_line":"  the order in which they are given in the server boot request."}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_ee60e2a7","line":1240,"range":{"start_line":1240,"start_character":16,"end_line":1240,"end_character":19},"updated":"2017-08-25 20:11:13.000000000","message":"\u0027ex: PCI\u0027","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12edad351ff941ca7a90e4c73c186fd6c5e62d79","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"  API and on the config drive. For example, a network interface on the"},{"line_number":1239,"context_line":"  virtual PCI bus tagged with .nic1. will appear in the metadata along"},{"line_number":1240,"context_line":"  with its bus (PCI), bus address (ex: 0000:00:02.0), MAC address, and"},{"line_number":1241,"context_line":"  tag (.nic1.). If multiple networks are defined, the order in which"},{"line_number":1242,"context_line":"  they appear in the guest operating system will not necessarily reflect"},{"line_number":1243,"context_line":"  the order in which they are given in the server boot request."},{"line_number":1244,"context_line":"  Guests should therefore not depend on device order to deduce any information"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_aecc1abc","line":1241,"range":{"start_line":1241,"start_character":7,"end_line":1241,"end_character":13},"updated":"2017-08-25 20:07:47.000000000","message":"Just nic1","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"  the order in which they are given in the server boot request."},{"line_number":1244,"context_line":"  Guests should therefore not depend on device order to deduce any information"},{"line_number":1245,"context_line":"  about their network devices. Instead, device role tags should be used."},{"line_number":1246,"context_line":"  Device tags apply to virtual network interfaces and block devices."},{"line_number":1247,"context_line":"cli\u003d"},{"line_number":1248,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1249,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_8e5ddeea","line":1246,"range":{"start_line":1246,"start_character":14,"end_line":1246,"end_character":19},"updated":"2017-08-25 20:11:13.000000000","message":"\u0027can be applied\u0027","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d1293f1dd93554e12db7630e54e05f833c1afbe2","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"driver-impl-libvirt-lxc\u003dunknown"},{"line_number":1254,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1255,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1256,"context_line":"driver-impl-hyperv\u003dunknown"},{"line_number":1257,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1258,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1259,"context_line":"driver-impl-libvirt-vz-ct\u003dunknown"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_ae41ba0d","line":1256,"range":{"start_line":1256,"start_character":19,"end_line":1256,"end_character":26},"updated":"2017-08-25 20:11:13.000000000","message":"Hyperv is done. I\u0027m assuming this is purely boot-time device tagging, not the tagged attach stuff that was recently-ish merged.","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12edad351ff941ca7a90e4c73c186fd6c5e62d79","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"driver-impl-libvirt-lxc\u003dunknown"},{"line_number":1254,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1255,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1256,"context_line":"driver-impl-hyperv\u003dunknown"},{"line_number":1257,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1258,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1259,"context_line":"driver-impl-libvirt-vz-ct\u003dunknown"}],"source_content_type":"text/x-properties","patch_set":8,"id":"7f287b81_ee37c2af","line":1256,"range":{"start_line":1256,"start_character":19,"end_line":1256,"end_character":26},"updated":"2017-08-25 20:07:47.000000000","message":"This should be complete.","commit_id":"83389794abc535138e9c585b6c55f04d814babb2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"469da3df8d1b16bcc087a2d3988d663afec4ff58","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"notes\u003dThis allows users to set tags on virtual devices when creating a"},{"line_number":1237,"context_line":"      server instance. Device tags are used to identify virtual device"},{"line_number":1238,"context_line":"      metadata, as exposed in the metadata API and on the config drive."},{"line_number":1239,"context_line":"      For example, a network interface on the virtual PCI bus tagged with"},{"line_number":1240,"context_line":"      ``nic1`` will appear in the metadata along with its bus (ex: PCI),"},{"line_number":1241,"context_line":"      bus address (ex: 0000:00:02.0), MAC address, and tag (nic1). If"},{"line_number":1242,"context_line":"      multiple networks are defined, the order in which they appear in the"}],"source_content_type":"text/x-properties","patch_set":9,"id":"7f287b81_eeb8e2c8","line":1239,"range":{"start_line":1239,"start_character":39,"end_line":1239,"end_character":61},"updated":"2017-08-25 20:24:01.000000000","message":"I didn\u0027t actually register this part when I said to add \u0027ex: PCI\u0027 in the brackets. It doesn\u0027t make sense to have both, and I think it\u0027s better to remove this entirely, to make it clearer that PCI is just an example.","commit_id":"625ab1b42fdb115e52bd409a667725f79c44a30d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30756909f29611df50f0b3059ec5629c25203d56","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"notes\u003dThis allows users to set tags on virtual devices when creating a"},{"line_number":1237,"context_line":"      server instance. Device tags are used to identify virtual device"},{"line_number":1238,"context_line":"      metadata, as exposed in the metadata API and on the config drive."},{"line_number":1239,"context_line":"      For example, a network interface on the virtual PCI bus tagged with"},{"line_number":1240,"context_line":"      ``nic1`` will appear in the metadata along with its bus (ex: PCI),"},{"line_number":1241,"context_line":"      bus address (ex: 0000:00:02.0), MAC address, and tag (nic1). If"},{"line_number":1242,"context_line":"      multiple networks are defined, the order in which they appear in the"}],"source_content_type":"text/x-properties","patch_set":9,"id":"7f287b81_ee2b42e8","line":1239,"range":{"start_line":1239,"start_character":39,"end_line":1239,"end_character":61},"in_reply_to":"7f287b81_eeb8e2c8","updated":"2017-08-25 20:34:17.000000000","message":"Done","commit_id":"625ab1b42fdb115e52bd409a667725f79c44a30d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"469da3df8d1b16bcc087a2d3988d663afec4ff58","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"      metadata, as exposed in the metadata API and on the config drive."},{"line_number":1239,"context_line":"      For example, a network interface on the virtual PCI bus tagged with"},{"line_number":1240,"context_line":"      ``nic1`` will appear in the metadata along with its bus (ex: PCI),"},{"line_number":1241,"context_line":"      bus address (ex: 0000:00:02.0), MAC address, and tag (nic1). If"},{"line_number":1242,"context_line":"      multiple networks are defined, the order in which they appear in the"},{"line_number":1243,"context_line":"      guest operating system will not necessarily reflect the order in which"},{"line_number":1244,"context_line":"      they are given in the server boot request. Guests should therefore not"}],"source_content_type":"text/x-properties","patch_set":9,"id":"7f287b81_6e7e321a","line":1241,"range":{"start_line":1241,"start_character":60,"end_line":1241,"end_character":64},"updated":"2017-08-25 20:24:01.000000000","message":"I guess you might as well put the `` here too then.","commit_id":"625ab1b42fdb115e52bd409a667725f79c44a30d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30756909f29611df50f0b3059ec5629c25203d56","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"      metadata, as exposed in the metadata API and on the config drive."},{"line_number":1239,"context_line":"      For example, a network interface on the virtual PCI bus tagged with"},{"line_number":1240,"context_line":"      ``nic1`` will appear in the metadata along with its bus (ex: PCI),"},{"line_number":1241,"context_line":"      bus address (ex: 0000:00:02.0), MAC address, and tag (nic1). If"},{"line_number":1242,"context_line":"      multiple networks are defined, the order in which they appear in the"},{"line_number":1243,"context_line":"      guest operating system will not necessarily reflect the order in which"},{"line_number":1244,"context_line":"      they are given in the server boot request. Guests should therefore not"}],"source_content_type":"text/x-properties","patch_set":9,"id":"7f287b81_0eefaeb0","line":1241,"range":{"start_line":1241,"start_character":60,"end_line":1241,"end_character":64},"in_reply_to":"7f287b81_6e7e321a","updated":"2017-08-25 20:34:17.000000000","message":"I intentionally left that out since the code formatting will look odd within parenthesis.","commit_id":"625ab1b42fdb115e52bd409a667725f79c44a30d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c12a630e9f51fb8d539a1c5c958a642790a8bc99","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"      depend on device order to deduce any information about their network"},{"line_number":1246,"context_line":"      devices. Instead, device role tags should be used. Device tags can be"},{"line_number":1247,"context_line":"      applied to virtual network interfaces and block devices."},{"line_number":1248,"context_line":"cli\u003d"},{"line_number":1249,"context_line":"driver-impl-xenserver\u003dcomplete"},{"line_number":1250,"context_line":"driver-impl-libvirt-kvm-x86\u003dcomplete"},{"line_number":1251,"context_line":"driver-impl-libvirt-kvm-ppc64\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":9,"id":"7f287b81_ce92c64b","line":1248,"updated":"2017-08-25 20:21:50.000000000","message":"This could probably be \u0027nova boot\u0027.","commit_id":"625ab1b42fdb115e52bd409a667725f79c44a30d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"015ad79ffb362730b9ab14bc00522491dff0d883","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"driver-impl-libvirt-lxc\u003dunknown"},{"line_number":1255,"context_line":"driver-impl-libvirt-xen\u003dcomplete"},{"line_number":1256,"context_line":"driver-impl-vmware\u003dmissing"},{"line_number":1257,"context_line":"driver-impl-hyperv\u003dcomplete"},{"line_number":1258,"context_line":"driver-impl-ironic\u003dmissing"},{"line_number":1259,"context_line":"driver-impl-libvirt-vz-vm\u003dcomplete"},{"line_number":1260,"context_line":"driver-impl-libvirt-vz-ct\u003dunknown"}],"source_content_type":"text/x-properties","patch_set":10,"id":"7f287b81_0f679abf","line":1257,"range":{"start_line":1257,"start_character":0,"end_line":1257,"end_character":27},"updated":"2017-08-28 01:38:25.000000000","message":"yea, it worked for hyperV.","commit_id":"817ca18aa4a5b68f8ddd2d353a32371b23fd4c99"}]}