)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ece6f47b436a7b8cf4337c58fc3d7d4ff7817b02","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I7cacd76c63e0ad29eb2d448ce07fbb5176f62721"},{"line_number":16,"context_line":"Depends-On: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"ff82abbf_cbc44f62","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":53},"updated":"2017-11-22 13:57:03.000000000","message":"This should be I867b6728ff680ae24b31ee660f720e90774c106e now and we should bump the os-brick version in nova/requirements.txt.","commit_id":"49ba95c6e8d3e2b28625c67345af482f4aed1008"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36d5c8f46db50241488a7e0e9ab7a60d67460a88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"os-brick\u0027s NVMe Connector."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I7cacd76c63e0ad29eb2d448ce07fbb5176f62721"},{"line_number":16,"context_line":"Depends-On: I867b6728ff680ae24b31ee660f720e90774c106e"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ff82abbf_0ee42cdf","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2017-11-27 16:29:05.000000000","message":"This should probably be Depends-On because normally the os-brick changes don\u0027t merge until the Cinder backend changes merge, and then the nova change can just depend on the os-brick release, but that didn\u0027t happen this time, so we need the nova change to now depend on the cinder change as well.","commit_id":"415fa97e7dd76b1af38f904025e7ff5bc0235740"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"fef50019510701e6849483752664661a7b69f6bf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"os-brick\u0027s NVMe Connector."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I7cacd76c63e0ad29eb2d448ce07fbb5176f62721"},{"line_number":16,"context_line":"Depends-On: I867b6728ff680ae24b31ee660f720e90774c106e"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ff82abbf_4d96a840","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"in_reply_to":"ff82abbf_0ee42cdf","updated":"2017-11-28 08:00:05.000000000","message":"Done","commit_id":"415fa97e7dd76b1af38f904025e7ff5bc0235740"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Depends-On: I7cacd76c63e0ad29eb2d448ce07fbb5176f62721"},{"line_number":16,"context_line":"Depends-On: Ica15649dbf6c46b9306f0397d2b592575e3eec5b"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"5f7c97a3_d97b4e25","line":16,"updated":"2018-05-14 17:58:18.000000000","message":"This isn\u0027t released yet:\n\nhttps://review.openstack.org/#/c/561905/\n\nSo you need to get an os-brick release with that in it and then bump the lower-constraints to include that version, and put it in nova/requirements.txt too.","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"b1707024f7e61d001d3e99e72cd88faabafcab74","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Depends-On: I7cacd76c63e0ad29eb2d448ce07fbb5176f62721"},{"line_number":16,"context_line":"Depends-On: Ica15649dbf6c46b9306f0397d2b592575e3eec5b"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"5f7c97a3_84761ed8","line":16,"in_reply_to":"5f7c97a3_d97b4e25","updated":"2018-05-24 08:52:59.000000000","message":"Done","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"319b1cebcc2c8de5867fde74a935b4fc991c466d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"attaching and detaching volume from instaces through calling"},{"line_number":12,"context_line":"os-brick\u0027s NVMe Connector."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":16,"context_line":"Change-Id: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"5f7c97a3_43a76ebd","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":38},"updated":"2018-05-29 09:59:27.000000000","message":"yay for codified typos :)","commit_id":"fc8975270157bf15233a9d5787d89bbc3796c64a"}],"nova/conf/libvirt.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"3b0bfd44eddbbc509601a3086065f100e1fcbdb2","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"),"},{"line_number":1041,"context_line":"]"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"libvirt_num_nvme_discover_tries \u003d ["},{"line_number":1044,"context_line":"    cfg.IntOpt(\u0027num_nvme_discover_tries\u0027,"},{"line_number":1045,"context_line":"               default\u003d3,"},{"line_number":1046,"context_line":"               help\u003d\u0027Number of times to rediscover NVMe target to find\\"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff82abbf_23609001","line":1043,"range":{"start_line":1043,"start_character":0,"end_line":1043,"end_character":31},"updated":"2017-11-22 05:00:51.000000000","message":"rename to libvirt_volume_nvmeof_opts","commit_id":"49ba95c6e8d3e2b28625c67345af482f4aed1008"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ece6f47b436a7b8cf4337c58fc3d7d4ff7817b02","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"),"},{"line_number":1041,"context_line":"]"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"libvirt_num_nvme_discover_tries \u003d ["},{"line_number":1044,"context_line":"    cfg.IntOpt(\u0027num_nvme_discover_tries\u0027,"},{"line_number":1045,"context_line":"               default\u003d3,"},{"line_number":1046,"context_line":"               help\u003d\u0027Number of times to rediscover NVMe target to find\\"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff82abbf_ebcfd37c","line":1043,"range":{"start_line":1043,"start_character":0,"end_line":1043,"end_character":31},"in_reply_to":"ff82abbf_23609001","updated":"2017-11-22 13:57:03.000000000","message":"Done","commit_id":"49ba95c6e8d3e2b28625c67345af482f4aed1008"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"libvirt_volume_nvmeof_opts \u003d ["},{"line_number":1182,"context_line":"    cfg.IntOpt(\u0027num_nvme_discover_tries\u0027,"},{"line_number":1183,"context_line":"               default\u003d3,"},{"line_number":1184,"context_line":"               help\u003d\"\"\""},{"line_number":1185,"context_line":"Number of times to rediscover NVMe target to find volume"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_398da231","line":1182,"updated":"2018-05-14 17:58:18.000000000","message":"I kind of wish we could just rely in the more generic num_volume_scan_tries here but I see that there are other protocol-specific config options like this one, and might be necessary for supporting multiple cinder backends at the same time.","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"}],"nova/virt/libvirt/volume/nvme.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8191575dfbb6e0c3d02407097af3075e6873796b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              self).__init__(connection, is_block_dev\u003dTrue)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":34,"context_line":"            \u0027NVME\u0027, utils.get_root_helper(),"},{"line_number":35,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_config(self, connection_info, disk_info):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_ab778b3a","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":18},"updated":"2017-11-22 14:02:15.000000000","message":"Isn\u0027t there a constant we can re-use from os-brick now?\n\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/__init__.py#L64","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"642f9f04aa11720fc1754ffd0d6c45974eeb8e14","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              self).__init__(connection, is_block_dev\u003dTrue)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":34,"context_line":"            \u0027NVME\u0027, utils.get_root_helper(),"},{"line_number":35,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_config(self, connection_info, disk_info):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_5cbc87db","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":18},"in_reply_to":"ff82abbf_ab778b3a","updated":"2017-11-23 08:29:56.000000000","message":"Done","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8191575dfbb6e0c3d02407097af3075e6873796b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def connect_volume("},{"line_number":47,"context_line":"        self,"},{"line_number":48,"context_line":"        connection_info,"},{"line_number":49,"context_line":"        disk_info,"},{"line_number":50,"context_line":"        instance):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        device_info \u003d self.connector.connect_volume("},{"line_number":53,"context_line":"            connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_cba76fa7","line":50,"range":{"start_line":47,"start_character":8,"end_line":50,"end_character":16},"updated":"2017-11-22 14:02:15.000000000","message":"This looks odd, can\u0027t we just have this on one line?","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"642f9f04aa11720fc1754ffd0d6c45974eeb8e14","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def connect_volume("},{"line_number":47,"context_line":"        self,"},{"line_number":48,"context_line":"        connection_info,"},{"line_number":49,"context_line":"        disk_info,"},{"line_number":50,"context_line":"        instance):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        device_info \u003d self.connector.connect_volume("},{"line_number":53,"context_line":"            connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_bc4fd332","line":50,"range":{"start_line":47,"start_character":8,"end_line":50,"end_character":16},"in_reply_to":"ff82abbf_cba76fa7","updated":"2017-11-23 08:29:56.000000000","message":"Done","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8191575dfbb6e0c3d02407097af3075e6873796b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        device_info \u003d self.connector.connect_volume("},{"line_number":53,"context_line":"            connection_info[\u0027data\u0027])"},{"line_number":54,"context_line":"        LOG.debug("},{"line_number":55,"context_line":"            \"Connecting NVMe volume with device_info %s\\n\","},{"line_number":56,"context_line":"            device_info)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_2bb29be7","line":55,"range":{"start_line":55,"start_character":55,"end_line":55,"end_character":57},"updated":"2017-11-22 14:02:15.000000000","message":"don\u0027t need this","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"642f9f04aa11720fc1754ffd0d6c45974eeb8e14","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        device_info \u003d self.connector.connect_volume("},{"line_number":53,"context_line":"            connection_info[\u0027data\u0027])"},{"line_number":54,"context_line":"        LOG.debug("},{"line_number":55,"context_line":"            \"Connecting NVMe volume with device_info %s\\n\","},{"line_number":56,"context_line":"            device_info)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_1c5a7ff2","line":55,"range":{"start_line":55,"start_character":55,"end_line":55,"end_character":57},"in_reply_to":"ff82abbf_2bb29be7","updated":"2017-11-23 08:29:56.000000000","message":"Done","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8191575dfbb6e0c3d02407097af3075e6873796b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def disconnect_volume(self, connection_info, disk_dev, instance):"},{"line_number":61,"context_line":"        \"\"\"Detach the volume from instance_name.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.connector.disconnect_volume("},{"line_number":64,"context_line":"            connection_info[\u0027data\u0027], None)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_ebcb5350","line":61,"range":{"start_line":61,"start_character":34,"end_line":61,"end_character":47},"updated":"2017-11-22 14:02:15.000000000","message":"this isn\u0027t a parameter","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"642f9f04aa11720fc1754ffd0d6c45974eeb8e14","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def disconnect_volume(self, connection_info, disk_dev, instance):"},{"line_number":61,"context_line":"        \"\"\"Detach the volume from instance_name.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.connector.disconnect_volume("},{"line_number":64,"context_line":"            connection_info[\u0027data\u0027], None)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff82abbf_9c6d2f9a","line":61,"range":{"start_line":61,"start_character":34,"end_line":61,"end_character":47},"in_reply_to":"ff82abbf_ebcb5350","updated":"2017-11-23 08:29:56.000000000","message":"Done","commit_id":"5c26caacf3e3e698e3ebe0f00f0505f1cb76d7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class LibvirtNVMEVolumeDriver(libvirt_volume.LibvirtBaseVolumeDriver):"},{"line_number":28,"context_line":"    \"\"\"Driver to attach NVMe volumes to libvirt.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, connection):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_d9a02e93","line":27,"range":{"start_line":27,"start_character":45,"end_line":27,"end_character":68},"updated":"2018-05-14 17:58:18.000000000","message":"Extend LibvirtVolumeDriver and then get_config() can be solely handled by the parent class.","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"b1707024f7e61d001d3e99e72cd88faabafcab74","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class LibvirtNVMEVolumeDriver(libvirt_volume.LibvirtBaseVolumeDriver):"},{"line_number":28,"context_line":"    \"\"\"Driver to attach NVMe volumes to libvirt.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, connection):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_17686f1f","line":27,"range":{"start_line":27,"start_character":45,"end_line":27,"end_character":68},"in_reply_to":"5f7c97a3_d9a02e93","updated":"2018-05-24 08:52:59.000000000","message":"Done","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.connector.disconnect_volume("},{"line_number":61,"context_line":"            connection_info[\u0027data\u0027], None)"},{"line_number":62,"context_line":"        LOG.debug(\"Disconnecting NVMe disk\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        super(LibvirtNVMEVolumeDriver,"},{"line_number":65,"context_line":"              self).disconnect_volume(connection_info, instance)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_b9ce9260","line":62,"updated":"2018-05-14 17:58:18.000000000","message":"This should probably go before you call os-brick.","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"b1707024f7e61d001d3e99e72cd88faabafcab74","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.connector.disconnect_volume("},{"line_number":61,"context_line":"            connection_info[\u0027data\u0027], None)"},{"line_number":62,"context_line":"        LOG.debug(\"Disconnecting NVMe disk\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        super(LibvirtNVMEVolumeDriver,"},{"line_number":65,"context_line":"              self).disconnect_volume(connection_info, instance)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_14cde083","line":62,"in_reply_to":"5f7c97a3_b9ce9260","updated":"2018-05-24 08:52:59.000000000","message":"Done","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5f7c97a3_f9e5eadc","line":66,"updated":"2018-05-14 17:58:18.000000000","message":"The NVMeConnector in os-brick implements the extend_volume method, so we should also support that here.","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"b1707024f7e61d001d3e99e72cd88faabafcab74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5f7c97a3_d772f749","line":66,"in_reply_to":"5f7c97a3_f9e5eadc","updated":"2018-05-24 08:52:59.000000000","message":"Done","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"}],"releasenotes/notes/bp-nvme-over-fabric-nova-ae1ef46fb5a7fc02.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05db41a3d08cf47c81787bd1d75a29f8344b27e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding NVMEoF libvirt driver for supporting NVMEoF initiator CLI."},{"line_number":5,"context_line":"    Libvirt NVMe volume driver is added to handle required calls for"},{"line_number":6,"context_line":"    attaching and detaching volume from instaces through calling"},{"line_number":7,"context_line":"    os-brick\u0027s NVMe Connector."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_39092295","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":30},"updated":"2018-05-14 17:58:18.000000000","message":"You should probably mention the actual volume type in here somewhere (nvmeof).","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"b1707024f7e61d001d3e99e72cd88faabafcab74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding NVMEoF libvirt driver for supporting NVMEoF initiator CLI."},{"line_number":5,"context_line":"    Libvirt NVMe volume driver is added to handle required calls for"},{"line_number":6,"context_line":"    attaching and detaching volume from instaces through calling"},{"line_number":7,"context_line":"    os-brick\u0027s NVMe Connector."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_5738273c","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":30},"in_reply_to":"5f7c97a3_39092295","updated":"2018-05-24 08:52:59.000000000","message":"Done","commit_id":"e25e83006d499154d98db35a241bca0092c57bb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b7790c85b9dbdd9d2e57be0852d10285ebbba9c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding NVMEoF libvirt driver for supporting NVMEoF initiator CLI."},{"line_number":5,"context_line":"    Libvirt NVMe volume driver is added to handle required calls for"},{"line_number":6,"context_line":"    attaching and detaching volumes of type NVMeOF from instaces through"},{"line_number":7,"context_line":"    calling os-brick\u0027s NVMe Connector."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5f7c97a3_abb75df5","line":6,"range":{"start_line":6,"start_character":44,"end_line":6,"end_character":50},"updated":"2018-05-24 23:00:06.000000000","message":"The type is literally ``nvmeof`` so we should say that.","commit_id":"466e1296439b7b7697a6034d894dfb61310e94e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"849c57f62f53ec978c95901892988a275d73f45c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adding NVMEoF libvirt driver for supporting NVMEoF initiator CLI."},{"line_number":5,"context_line":"    Libvirt NVMe volume driver is added to handle required calls for"},{"line_number":6,"context_line":"    attaching and detaching volumes of type NVMeOF from instaces through"},{"line_number":7,"context_line":"    calling os-brick\u0027s NVMe Connector."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5f7c97a3_cb8ad919","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":38},"updated":"2018-05-24 23:02:09.000000000","message":"This is an implementation detail the operator doesn\u0027t need to know about.","commit_id":"466e1296439b7b7697a6034d894dfb61310e94e2"}]}