)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"3753a2ad6a2d2e45b94c3164554a0f8a4fe7d0e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ensures that the configuration succeeds. The only driver"},{"line_number":12,"context_line":"that actually uses this is the Xen driver."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug: 1229912"},{"line_number":15,"context_line":"Fixes bug: 1229911"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iee69e45d94047742b6a499a139bac96ad9dd971f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAS3%2F%2FeZg%3D","line":14,"updated":"2013-09-26 04:52:30.000000000","message":"nit: Please refer to https://wiki.openstack.org/wiki/GitCommitMessages for \"bug\" line.\n\nCloses-Bug: #1234567 -- use \u0027Closes-Bug\u0027 if the commit is intended to fully fix and close the bug being referenced.\nPartial-Bug: #1234567 -- use \u0027Partial-Bug\u0027 if the commit is only a partial fix and more work is needed.\nRelated-Bug: #1234567 -- use \u0027Related-Bug\u0027 if the commit is merely related to the referenced bug.","commit_id":"88df64f244dd20e0dd51bc439327833c220806be"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"73303280e38962023d8d0453cc0219ee71ac176e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-27 08:17:00 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix host aggregate configurations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Configuration of the host aggregates breaks tempest tests."},{"line_number":10,"context_line":"The change does not add in any new functionality but just"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAS3%2F%2FSMk%3D","line":7,"updated":"2013-09-30 21:44:21.000000000","message":"This title is ambiguous.\n\nAlso the commit message should say why raising an exception is better here.","commit_id":"2e4a86bcee88d85ee7c5767a445af5ef451c860a"}],"nova/compute/manager.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"61c182b3f5bdd3289cc4b45f25cc028a2aef0363","unresolved":false,"context_lines":[{"line_number":4992,"context_line":"            self.driver.add_to_aggregate(context, aggregate, host,"},{"line_number":4993,"context_line":"                                         slave_info\u003dslave_info)"},{"line_number":4994,"context_line":"        except NotImplementedError:"},{"line_number":4995,"context_line":"            LOG.debug(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":4996,"context_line":"                        \u0027add_aggregate_host\u0027))"},{"line_number":4997,"context_line":"        except exception.AggregateError:"},{"line_number":4998,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Feak%3D","line":4995,"updated":"2013-09-26 04:39:43.000000000","message":"Agree we should use debug log here as for non Xen hypervisor, we only care DB operations for host aggregation.","commit_id":"88df64f244dd20e0dd51bc439327833c220806be"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ad7e00c037603e1694ff069c6914c0c32d4758c0","unresolved":false,"context_lines":[{"line_number":4998,"context_line":"                                         slave_info\u003dslave_info)"},{"line_number":4999,"context_line":"        except NotImplementedError:"},{"line_number":5000,"context_line":"            LOG.debug(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":5001,"context_line":"                        \u0027add_aggregate_host\u0027))"},{"line_number":5002,"context_line":"        except exception.AggregateError:"},{"line_number":5003,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5004,"context_line":"                self.driver.undo_aggregate_operation("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F8Uo%3D","line":5001,"updated":"2013-10-07 17:45:22.000000000","message":"Instead of catching and logging this exception every time, why not just change the base driver class to implement this as a no-op function?","commit_id":"93695e60ec6136688fe5ca2d6d8494dcfd71eb22"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"068da32b6485f9ab5329e93d829dd5a60341459d","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    def undo_aggregate_operation(self, context, op, aggregate,"},{"line_number":387,"context_line":"                                  host, set_error\u003dTrue):"},{"line_number":388,"context_line":"        \"\"\"Undo for Resource Pools.\"\"\""},{"line_number":389,"context_line":"        pass"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Ffgo%3D","line":389,"updated":"2013-09-25 19:11:58.000000000","message":"shouldn\u0027t these be some kind of Unimplemented Exception?","commit_id":"d4f0c638e83599c07b897dd6ed23f1457446a1f9"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"31cd1709c6dab2608aa7579f2bc112c5248e6b68","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    def undo_aggregate_operation(self, context, op, aggregate,"},{"line_number":387,"context_line":"                                  host, set_error\u003dTrue):"},{"line_number":388,"context_line":"        \"\"\"Undo for Resource Pools.\"\"\""},{"line_number":389,"context_line":"        pass"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FfgE%3D","line":389,"in_reply_to":"AAAAS3%2F%2Ffgo%3D","updated":"2013-09-25 19:15:28.000000000","message":"Shawn, I don\u0027t think so... this implementation matches the libvirt implementation: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4654","commit_id":"d4f0c638e83599c07b897dd6ed23f1457446a1f9"}]}