)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"447b9907fc7710914a65e4cc4e35ac7d699a48db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing ephemeral disk creation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"       * Formatting disk/images only once."},{"line_number":10,"context_line":"       * Distinguishing between block devices and not."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1204424"},{"line_number":13,"context_line":"Change-Id: I2bf7abc982e20eaaf7bca7cd798b4134b76d10a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATH%2F%2F0LY%3D","line":10,"updated":"2013-10-09 13:41:50.000000000","message":"You need to more clearly explain what is broken about the current code and how it is being fixed. The bug report should not be relied on to provide this info, and in any case the bug report is fairy useless explaining what is actually wrong here.","commit_id":"059af1b29d89139a8db6eed49dc97c165a0927ae"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"07075cb93060e60382ae94fe62c2d04df4a37b1e","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self._create_local(target, ephemeral_size)"},{"line_number":2254,"context_line":""},{"line_number":2255,"context_line":"        # Run as root only for block devices."},{"line_number":2256,"context_line":"        disk.mkfs(os_type, fs_label, target, run_as_root\u003dis_block_dev)"},{"line_number":2257,"context_line":""},{"line_number":2258,"context_line":"    @staticmethod"},{"line_number":2259,"context_line":"    def _create_swap(target, swap_mb):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FZ6c%3D","line":2256,"updated":"2013-10-16 16:06:53.000000000","message":"how this passed the tests? the mkfs method doesn\u0027t have the run_as_root param at all https://github.com/openstack/nova/blob/master/nova/virt/disk/api.py#L103","commit_id":"f4b47fd55228f5f3fd596722a8e8fee777000e0e"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"4564560e37c2c6ee391962c57c9fba6f68921fd2","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self._create_local(target, ephemeral_size)"},{"line_number":2254,"context_line":""},{"line_number":2255,"context_line":"        # Run as root only for block devices."},{"line_number":2256,"context_line":"        disk.mkfs(os_type, fs_label, target, run_as_root\u003dis_block_dev)"},{"line_number":2257,"context_line":""},{"line_number":2258,"context_line":"    @staticmethod"},{"line_number":2259,"context_line":"    def _create_swap(target, swap_mb):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FQQQ%3D","line":2256,"in_reply_to":"AAAATH%2F%2FZ2w%3D","updated":"2013-10-19 02:47:03.000000000","message":"You are right, I didn\u0027t notice it, thanks.","commit_id":"f4b47fd55228f5f3fd596722a8e8fee777000e0e"},{"author":{"_account_id":8076,"name":"Vladik Romanovsky","email":"vladik.romanovsky@gmail.com","username":"vladik"},"change_message_id":"4d7b7b2bd4cbd4d47b89c8c71bea707a8aa9fe0a","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self._create_local(target, ephemeral_size)"},{"line_number":2254,"context_line":""},{"line_number":2255,"context_line":"        # Run as root only for block devices."},{"line_number":2256,"context_line":"        disk.mkfs(os_type, fs_label, target, run_as_root\u003dis_block_dev)"},{"line_number":2257,"context_line":""},{"line_number":2258,"context_line":"    @staticmethod"},{"line_number":2259,"context_line":"    def _create_swap(target, swap_mb):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FZ2w%3D","line":2256,"in_reply_to":"AAAATH%2F%2FZ6c%3D","updated":"2013-10-16 16:15:41.000000000","message":"Hi, thanks for the review, but this patch has a dependency:\nhttps://review.openstack.org/#/c/48527/\nThis is how it passes the test.","commit_id":"f4b47fd55228f5f3fd596722a8e8fee777000e0e"}]}