)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ba68d7ae75b4d48af31602971c83a8f9b0ac43e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     manas.mandlekar \u003cmanas.mandlekar@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-14 07:34:44 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"An unexpected failure during live migration leaves the insatnce"},{"line_number":8,"context_line":"to migrating state forever."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The issue is that in case of unexpected failure the task state is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_88b4e736","line":7,"range":{"start_line":7,"start_character":55,"end_line":7,"end_character":63},"updated":"2017-07-14 14:06:37.000000000","message":"`instance`\n\nAnd the commit header is too long.  Needs to be \u003c\u003d50c","commit_id":"6654367960edb11477025502740139e134ff23a7"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"7f69a30425f5a441bd6765a3b504b76d4d53aad7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     manas.mandlekar \u003cmanas.mandlekar@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-14 07:34:44 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"An unexpected failure during live migration leaves the insatnce"},{"line_number":8,"context_line":"to migrating state forever."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The issue is that in case of unexpected failure the task state is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_c5c981ac","line":7,"range":{"start_line":7,"start_character":55,"end_line":7,"end_character":63},"in_reply_to":"1f1a1f67_88b4e736","updated":"2017-07-17 08:12:09.000000000","message":"Done","commit_id":"6654367960edb11477025502740139e134ff23a7"}],"nova/conductor/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9d3aaae8cbdf1198295b78dae6be91cd2b7fdfc3","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                          \u0027 %(dest)s unexpectedly failed.\u0027),"},{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR)"},{"line_number":447,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":448,"context_line":"            migration.save()"},{"line_number":449,"context_line":"            raise exception.MigrationError(reason\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_62f1ac6b","line":446,"updated":"2017-07-14 13:32:26.000000000","message":"I think it would be clearer to say explicitly task_state\u003dNone.","commit_id":"6654367960edb11477025502740139e134ff23a7"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"7f69a30425f5a441bd6765a3b504b76d4d53aad7","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                          \u0027 %(dest)s unexpectedly failed.\u0027),"},{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR)"},{"line_number":447,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":448,"context_line":"            migration.save()"},{"line_number":449,"context_line":"            raise exception.MigrationError(reason\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_e5efdd1b","line":446,"in_reply_to":"1f1a1f67_62f1ac6b","updated":"2017-07-17 08:12:09.000000000","message":"Done","commit_id":"6654367960edb11477025502740139e134ff23a7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7b9d4b9ce9902b2712ad3d0cb4eb2173c2f51e8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_6cd2e95e","line":447,"range":{"start_line":447,"start_character":42,"end_line":447,"end_character":69},"updated":"2017-07-25 12:41:35.000000000","message":"Do you mean like on L438?","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7b9d4b9ce9902b2712ad3d0cb4eb2173c2f51e8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_4cecc528","line":447,"range":{"start_line":447,"start_character":34,"end_line":447,"end_character":36},"updated":"2017-07-25 12:41:35.000000000","message":"is?","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"e8d0d7004ffd724a676e8eaef9d6b492e53cad7d","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_b1b245e5","line":447,"range":{"start_line":447,"start_character":34,"end_line":447,"end_character":36},"in_reply_to":"ff346bd7_4cecc528","updated":"2017-07-26 10:27:16.000000000","message":"Done","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"e8d0d7004ffd724a676e8eaef9d6b492e53cad7d","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_71ccdd69","line":447,"range":{"start_line":447,"start_character":42,"end_line":447,"end_character":69},"in_reply_to":"ff346bd7_6cd2e95e","updated":"2017-07-26 10:27:16.000000000","message":"Yes.","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6422da3430fdd7bfb01d938069e49605b568888b","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                      {\u0027instance_id\u0027: instance.uuid, \u0027dest\u0027: destination},"},{"line_number":445,"context_line":"                      exc_info\u003dTrue)"},{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_87172646","line":447,"range":{"start_line":447,"start_character":42,"end_line":447,"end_character":69},"in_reply_to":"ff346bd7_6cd2e95e","updated":"2017-07-25 13:02:41.000000000","message":"Yup, I think so.","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6422da3430fdd7bfb01d938069e49605b568888b","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":451,"context_line":"            migration.save()"},{"line_number":452,"context_line":"            raise exception.MigrationError(reason\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_ec0db93e","line":449,"range":{"start_line":449,"start_character":26,"end_line":449,"end_character":41},"updated":"2017-07-25 13:02:41.000000000","message":"we default task_state to None in _set_vm_state() so there is no need to be explicit here.","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"e8d0d7004ffd724a676e8eaef9d6b492e53cad7d","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":451,"context_line":"            migration.save()"},{"line_number":452,"context_line":"            raise exception.MigrationError(reason\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_71d17dfb","line":449,"range":{"start_line":449,"start_character":26,"end_line":449,"end_character":41},"in_reply_to":"ff346bd7_58dd9c40","updated":"2017-07-26 10:27:16.000000000","message":"Yes I updated it based on Eric\u0027s comment as it sounds reasonable to me. I\u0027ve retained it for now, let me know if there are any concerns around that.","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aff9e694dc938c7f106d9a2836d05aa066a1f7e5","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # Reset the task state to None to indicate completion of"},{"line_number":447,"context_line":"            # the operation as it in done in case of known exceptions."},{"line_number":448,"context_line":"            _set_vm_state(context, instance, ex, vm_states.ERROR,"},{"line_number":449,"context_line":"                          task_state\u003dNone)"},{"line_number":450,"context_line":"            migration.status \u003d \u0027error\u0027"},{"line_number":451,"context_line":"            migration.save()"},{"line_number":452,"context_line":"            raise exception.MigrationError(reason\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_58dd9c40","line":449,"range":{"start_line":449,"start_character":26,"end_line":449,"end_character":41},"in_reply_to":"ff346bd7_ec0db93e","updated":"2017-07-25 15:20:54.000000000","message":"This was my ask (see PS1).  I thought being explicit made it very clear that we\u0027re intentionally clearing the task_state.\n\n\"Explicit is better than implicit.\" [1]\n\n[1] https://www.python.org/dev/peps/pep-0020/","commit_id":"3a659a0e4c304a82b7f1843e219e9a147842ca02"}]}