)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"943ba502d3aca272383bab47a76b768c5518a3ca","unresolved":false,"context_lines":[{"line_number":4434,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4435,"context_line":"            context, instance.uuid)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"        block_device_info \u003d self._get_instance_block_device_info(context,"},{"line_number":4438,"context_line":"                                                                 instance,"},{"line_number":4439,"context_line":"                                                                 bdms\u003dbdms)"},{"line_number":4440,"context_line":"        self.driver.destroy(context, instance, network_info,"},{"line_number":4441,"context_line":"                block_device_info)"},{"line_number":4442,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_f4fda108","side":"PARENT","line":4439,"range":{"start_line":4437,"start_character":8,"end_line":4439,"end_character":75},"updated":"2017-10-04 18:38:02.000000000","message":"didn\u0027t really need to move this but ok","commit_id":"35e6c3197275d34e5aa59892ba0ffdeb3685389b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"943ba502d3aca272383bab47a76b768c5518a3ca","unresolved":false,"context_lines":[{"line_number":4311,"context_line":""},{"line_number":4312,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4313,"context_line":"            context, instance.uuid)"},{"line_number":4314,"context_line":"        block_device_info \u003d self._get_instance_block_device_info("},{"line_number":4315,"context_line":"            context, instance, bdms)"},{"line_number":4316,"context_line":""},{"line_number":4317,"context_line":"        compute_utils.notify_about_instance_action(context, instance,"},{"line_number":4318,"context_line":"            self.host, action\u003dfields.NotificationAction.RESUME,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_7411b153","line":4315,"range":{"start_line":4314,"start_character":8,"end_line":4315,"end_character":36},"updated":"2017-10-04 18:38:02.000000000","message":"this didn\u0027t need to move","commit_id":"55ecf8c1d31123d5cd3fec4d08c3cdfca5ffefb9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aaa8f51a9e3c7273b9010c6667dfd73dc6d16e15","unresolved":false,"context_lines":[{"line_number":4367,"context_line":"        compute_utils.notify_usage_exists(self.notifier, context, instance,"},{"line_number":4368,"context_line":"                                          current_period\u003dTrue)"},{"line_number":4369,"context_line":"        self._notify_about_instance_usage(context, instance, \u0027shelve.start\u0027)"},{"line_number":4370,"context_line":"        compute_utils.notify_about_instance_action(context, instance,"},{"line_number":4371,"context_line":"                self.host, action\u003dfields.NotificationAction.SHELVE,"},{"line_number":4372,"context_line":"                phase\u003dfields.NotificationPhase.START)"},{"line_number":4373,"context_line":""},{"line_number":4374,"context_line":"        def update_task_state(task_state, expected_state\u003dtask_states.SHELVING):"},{"line_number":4375,"context_line":"            shelving_state_map \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_14315ded","line":4372,"range":{"start_line":4370,"start_character":8,"end_line":4372,"end_character":53},"updated":"2017-10-04 18:39:03.000000000","message":"If we know we\u0027re going to shelve offload, which is the default behavior, we can get the BDMs in here and use them, and pass to _shelve_offload_instance. I\u0027m going to add that to the bottom change.","commit_id":"55ecf8c1d31123d5cd3fec4d08c3cdfca5ffefb9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"385a6799dfb3804b1b340adb2f4b2711457d82b5","unresolved":false,"context_lines":[{"line_number":5440,"context_line":"        :param dest_check_data: result of check_can_live_migrate_destination"},{"line_number":5441,"context_line":"        :returns: a dict containing migration info"},{"line_number":5442,"context_line":"        \"\"\""},{"line_number":5443,"context_line":"        is_volume_backed \u003d compute_utils.is_volume_backed_instance(ctxt,"},{"line_number":5444,"context_line":"                                                                      instance)"},{"line_number":5445,"context_line":"        # TODO(tdurakov): remove dict to object conversion once RPC API version"},{"line_number":5446,"context_line":"        # is bumped to 5.x"},{"line_number":5447,"context_line":"        got_migrate_data_object \u003d isinstance(dest_check_data,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_67f8e17b","line":5444,"range":{"start_line":5443,"start_character":8,"end_line":5444,"end_character":79},"updated":"2017-10-04 19:32:35.000000000","message":"This is another case that takes bdms and will look them up if you don\u0027t provide them.\n\nBut it doesn\u0027t look like we have a notification here anyway, so ignore me.","commit_id":"b6ba82f470d833f1e2c61deac6e09aefe5c9ec1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"385a6799dfb3804b1b340adb2f4b2711457d82b5","unresolved":false,"context_lines":[{"line_number":5451,"context_line":"                migrate_data_obj.LiveMigrateData.detect_implementation("},{"line_number":5452,"context_line":"                    dest_check_data)"},{"line_number":5453,"context_line":"        dest_check_data.is_volume_backed \u003d is_volume_backed"},{"line_number":5454,"context_line":"        block_device_info \u003d self._get_instance_block_device_info("},{"line_number":5455,"context_line":"                            ctxt, instance, refresh_conn_info\u003dFalse)"},{"line_number":5456,"context_line":"        result \u003d self.driver.check_can_live_migrate_source(ctxt, instance,"},{"line_number":5457,"context_line":"                                                           dest_check_data,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_27f2e99b","line":5454,"range":{"start_line":5454,"start_character":33,"end_line":5454,"end_character":64},"updated":"2017-10-04 19:32:35.000000000","message":"and passed in here","commit_id":"b6ba82f470d833f1e2c61deac6e09aefe5c9ec1a"}]}
