)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d18abeb10cb70fff834015432be3491ef00ad947","unresolved":false,"context_lines":[{"line_number":20,"context_line":"defaults modified to be unset. This allows us to warn users with libvirt"},{"line_number":21,"context_line":"hypervisors that have configured the options about the pitfalls of the"},{"line_number":22,"context_line":"option and give them time to prepare migration strategies, if necessary."},{"line_number":23,"context_line":"An replacement option is added to the VMWare group to allow us to retain"},{"line_number":24,"context_line":"this functionality for that hypervisor. Combined with the above, this"},{"line_number":25,"context_line":"will allow us to remove the options in a future release."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_ef2712b6","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":2},"updated":"2017-08-23 13:04:48.000000000","message":"s/An/A/","commit_id":"2818fff4d5248037ffa5172bab8d5b9dd0657d61"}],"nova/conf/vmware.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d18abeb10cb70fff834015432be3491ef00ad947","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* A keyboard layout which is supported by the underlying hypervisor on"},{"line_number":187,"context_line":"  this node. This is usually an \u0027IETF language tag\u0027 (for example"},{"line_number":188,"context_line":"  \u0027en-us\u0027).  If you use QEMU as hypervisor, you should find the  list"},{"line_number":189,"context_line":"  of supported keyboard layouts at ``/usr/share/qemu/keymaps``."},{"line_number":190,"context_line":"\"\"\"),"},{"line_number":191,"context_line":"    cfg.BoolOpt(\u0027use_linked_clone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_af08ea27","line":188,"range":{"start_line":188,"start_character":13,"end_line":188,"end_character":42},"updated":"2017-08-23 13:04:48.000000000","message":"this is the VMWare hypervisor configuration section, so pretty sure this will be false.","commit_id":"2818fff4d5248037ffa5172bab8d5b9dd0657d61"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2eeb71928ee01271312e81d5d68ce89e4b2cbffe","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* A keyboard layout which is supported by the underlying hypervisor on"},{"line_number":187,"context_line":"  this node. This is usually an \u0027IETF language tag\u0027 (for example"},{"line_number":188,"context_line":"  \u0027en-us\u0027).  If you use QEMU as hypervisor, you should find the  list"},{"line_number":189,"context_line":"  of supported keyboard layouts at ``/usr/share/qemu/keymaps``."},{"line_number":190,"context_line":"\"\"\"),"},{"line_number":191,"context_line":"    cfg.BoolOpt(\u0027use_linked_clone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_4fc2a687","line":188,"range":{"start_line":188,"start_character":13,"end_line":188,"end_character":42},"in_reply_to":"7f287b81_af08ea27","updated":"2017-08-23 13:10:08.000000000","message":"Damn it. Done","commit_id":"2818fff4d5248037ffa5172bab8d5b9dd0657d61"}],"nova/conf/vnc.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3516b9b246f87288647d470f391d1fef1edbff5f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_since\u003d\u002717.0.0\u0027,"},{"line_number":44,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":45,"context_line":"Configuring this option forces QEMU to do keymap conversions. These conversions"},{"line_number":46,"context_line":"are lossy and can result in significant issues for users of non en-US"},{"line_number":47,"context_line":"keyboards. Refer to bug #1682020 for more information.\"\"\","},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Keymap for VNC."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_f48daf7b","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":54},"updated":"2017-09-22 14:11:28.000000000","message":"At the PTG we said we wouldn\u0027t remove this until there was an alternative available, and I thought that was going to be an unreleased change in noVNC, which from the thread on that change in noVNC for the request request was probably going to be the 1.0.0 package, so if that\u0027s still true, we should put something in here about not removing this until noVNC 1.0.0 is available.","commit_id":"bf26dbdd3284804455e3b626445d4ab81040eeba"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0659489889cdc67a7fa530fc622ff1b292d28d2a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_since\u003d\u002717.0.0\u0027,"},{"line_number":44,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":45,"context_line":"Configuring this option forces QEMU to do keymap conversions. These conversions"},{"line_number":46,"context_line":"are lossy and can result in significant issues for users of non en-US"},{"line_number":47,"context_line":"keyboards. Refer to bug #1682020 for more information.\"\"\","},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Keymap for VNC."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_347a2724","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":54},"in_reply_to":"7f515b1d_f48daf7b","updated":"2017-09-22 14:22:26.000000000","message":"Yup, see my -workflow and message. I\u0027m only rebasing this to stop bit rot. Once noVNC 1.0 is out, I\u0027ll remove said -workflow","commit_id":"bf26dbdd3284804455e3b626445d4ab81040eeba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":44,"context_line":"        deprecated_since\u003d\u002717.0.0\u0027,"},{"line_number":45,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":46,"context_line":"Configuring this option forces QEMU to do keymap conversions. These conversions"},{"line_number":47,"context_line":"are lossy and can result in significant issues for users of non en-US"},{"line_number":48,"context_line":"keyboards. Refer to bug #1682020 for more information.\"\"\","},{"line_number":49,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_79cf477f","line":46,"updated":"2018-03-06 16:13:33.000000000","message":"We should probably mention that novnc \u003e\u003d 1.0.0 should be used for native keymap support.","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b43fe9938eb26fb90ec4c176aff5bd38ef1350","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":44,"context_line":"        deprecated_since\u003d\u002717.0.0\u0027,"},{"line_number":45,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":46,"context_line":"Configuring this option forces QEMU to do keymap conversions. These conversions"},{"line_number":47,"context_line":"are lossy and can result in significant issues for users of non en-US"},{"line_number":48,"context_line":"keyboards. Refer to bug #1682020 for more information.\"\"\","},{"line_number":49,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_1c7b998c","line":46,"in_reply_to":"ff6b8bd7_79cf477f","updated":"2018-03-06 17:17:30.000000000","message":"Done","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cfg.URIOpt("},{"line_number":94,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_auto.html\u0027,"},{"line_number":96,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":97,"context_line":"        help\u003d\"\"\""},{"line_number":98,"context_line":"Public address of noVNC VNC console proxy."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_79942745","line":95,"range":{"start_line":95,"start_character":39,"end_line":95,"end_character":47},"updated":"2018-03-06 16:13:33.000000000","message":"Given your testing, novnc \u003e\u003d 1.0.0 means this needs to be vnc_lite.html right? We should probably mention that in the help docs.","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89b39b6839e6d17c92170295563ecd222a3c20bc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cfg.URIOpt("},{"line_number":94,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_auto.html\u0027,"},{"line_number":96,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":97,"context_line":"        help\u003d\"\"\""},{"line_number":98,"context_line":"Public address of noVNC VNC console proxy."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_509250f8","line":95,"range":{"start_line":95,"start_character":39,"end_line":95,"end_character":47},"in_reply_to":"ff6b8bd7_5fed83ed","updated":"2018-03-06 19:28:08.000000000","message":"It is used in devstack:\n\nhttps://github.com/openstack-dev/devstack/blob/af43b825029c2288a76734f7a08be9e16196eb45/lib/nova#L521\n\nSo you\u0027ll be breaking devstack by this change since it\u0027s not installing novnc 1.0.0.","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b43fe9938eb26fb90ec4c176aff5bd38ef1350","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cfg.URIOpt("},{"line_number":94,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_auto.html\u0027,"},{"line_number":96,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":97,"context_line":"        help\u003d\"\"\""},{"line_number":98,"context_line":"Public address of noVNC VNC console proxy."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_5fed83ed","line":95,"range":{"start_line":95,"start_character":39,"end_line":95,"end_character":47},"in_reply_to":"ff6b8bd7_79942745","updated":"2018-03-06 17:17:30.000000000","message":"Given that this default is never used in DevStack [1] (and presumably configured manually by every other deployment tool) I\u0027ve just gone an updated this\n\n[1] https://github.com/openstack-dev/devstack/blob/af43b825029c2288a76734f7a08be9e16196eb45/stackrc#L603-L606","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e76328b85d1dadd619896c3941d11e48c6fdf36","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.URIOpt("},{"line_number":95,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":96,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_lite.html\u0027,"},{"line_number":97,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"        help\u003d\"\"\""},{"line_number":99,"context_line":"Public address of noVNC VNC console proxy."}],"source_content_type":"text/x-python","patch_set":8,"id":"ff6b8bd7_f04a847e","line":96,"updated":"2018-03-06 19:32:54.000000000","message":"Let\u0027s leave this as it was before.","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da13603cb8c5730f7ccc72a739f508db1569d5ff","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.URIOpt("},{"line_number":95,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":96,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_lite.html\u0027,"},{"line_number":97,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"        help\u003d\"\"\""},{"line_number":99,"context_line":"Public address of noVNC VNC console proxy."}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_7b0432c7","line":96,"in_reply_to":"ff6b8bd7_f04a847e","updated":"2018-03-07 10:18:38.000000000","message":"Done","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e76328b85d1dadd619896c3941d11e48c6fdf36","unresolved":false,"context_lines":[{"line_number":106,"context_line":"connect. noVNC clients can use this address to connect to the noVNC"},{"line_number":107,"context_line":"instance and, by extension, the VNC sessions."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"If using noVNC \u003c 1.0.0, you should use ``vnc_auto.html`` instead of"},{"line_number":110,"context_line":"``vnc_lite.html``."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff6b8bd7_3036bc05","line":109,"updated":"2018-03-06 19:32:54.000000000","message":"And change this to be \u003e\u003d 1.0.0 and say use \u0027vnc_lite.html\u0027 instead of \u0027vnc_auto.html\u0027.","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da13603cb8c5730f7ccc72a739f508db1569d5ff","unresolved":false,"context_lines":[{"line_number":106,"context_line":"connect. noVNC clients can use this address to connect to the noVNC"},{"line_number":107,"context_line":"instance and, by extension, the VNC sessions."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"If using noVNC \u003c 1.0.0, you should use ``vnc_auto.html`` instead of"},{"line_number":110,"context_line":"``vnc_lite.html``."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_3b0ebae5","line":109,"in_reply_to":"ff6b8bd7_3036bc05","updated":"2018-03-07 10:18:38.000000000","message":"Done","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":5169,"context_line":"            graphics.type \u003d \"vnc\""},{"line_number":5170,"context_line":"            if CONF.vnc.keymap:"},{"line_number":5171,"context_line":"                graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":5172,"context_line":"                LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated \u0027"},{"line_number":5173,"context_line":"                            \u0027in favor of configuration within the guest. \u0027"},{"line_number":5174,"context_line":"                            \u0027Update nova.conf to address this change and \u0027"},{"line_number":5175,"context_line":"                            \u0027refer to bug #1682020 for more information.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_f9891726","line":5172,"updated":"2018-03-06 16:13:33.000000000","message":"This warning is going to get logged for every guest created on this host, which seems excessive. One the one hand, blasting operators with warnings to fix their config might not be all bad. If we wanted, we could track a class variable to see if we\u0027ve logged this already per restart of nova-compute and then only log it once.","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b43fe9938eb26fb90ec4c176aff5bd38ef1350","unresolved":false,"context_lines":[{"line_number":5169,"context_line":"            graphics.type \u003d \"vnc\""},{"line_number":5170,"context_line":"            if CONF.vnc.keymap:"},{"line_number":5171,"context_line":"                graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":5172,"context_line":"                LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated \u0027"},{"line_number":5173,"context_line":"                            \u0027in favor of configuration within the guest. \u0027"},{"line_number":5174,"context_line":"                            \u0027Update nova.conf to address this change and \u0027"},{"line_number":5175,"context_line":"                            \u0027refer to bug #1682020 for more information.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_9f1ebb0a","line":5172,"in_reply_to":"ff6b8bd7_f9891726","updated":"2018-03-06 17:17:30.000000000","message":"Agree, especially as it\u0027s a WARNING level. Moved to driver init code","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":5181,"context_line":"            graphics.type \u003d \"spice\""},{"line_number":5182,"context_line":"            if CONF.spice.keymap:"},{"line_number":5183,"context_line":"                graphics.keymap \u003d CONF.spice.keymap"},{"line_number":5184,"context_line":"                LOG.warning(\u0027The option \"[spice] keymap\" has been deprecated \u0027"},{"line_number":5185,"context_line":"                            \u0027in favor of configuration within the guest. \u0027"},{"line_number":5186,"context_line":"                            \u0027Update nova.conf to address this change and \u0027"},{"line_number":5187,"context_line":"                            \u0027refer to bug #1682020 for more information.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_d988d320","line":5184,"updated":"2018-03-06 16:13:33.000000000","message":"same","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e76328b85d1dadd619896c3941d11e48c6fdf36","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":348,"context_line":"            libvirt_migrate.libvirt \u003d libvirt"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if CONF.vnc.keymap:"},{"line_number":351,"context_line":"            LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated \u0027"},{"line_number":352,"context_line":"                        \u0027in favor of configuration within the guest. \u0027"},{"line_number":353,"context_line":"                        \u0027Update nova.conf to address this change and \u0027"},{"line_number":354,"context_line":"                        \u0027refer to bug #1682020 for more information.\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if CONF.spice.keymap:"},{"line_number":357,"context_line":"            LOG.warning(\u0027The option \"[spice] keymap\" has been deprecated \u0027"},{"line_number":358,"context_line":"                        \u0027in favor of configuration within the guest. \u0027"},{"line_number":359,"context_line":"                        \u0027Update nova.conf to address this change and \u0027"},{"line_number":360,"context_line":"                        \u0027refer to bug #1682020 for more information.\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        self._host \u003d host.Host(self._uri(), read_only,"},{"line_number":363,"context_line":"                               lifecycle_event_handler\u003dself.emit_event,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff6b8bd7_b00acc23","line":360,"range":{"start_line":350,"start_character":8,"end_line":360,"end_character":70},"updated":"2018-03-06 19:32:54.000000000","message":"Let\u0027s move these to _do_quality_warnings.","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da13603cb8c5730f7ccc72a739f508db1569d5ff","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":348,"context_line":"            libvirt_migrate.libvirt \u003d libvirt"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if CONF.vnc.keymap:"},{"line_number":351,"context_line":"            LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated \u0027"},{"line_number":352,"context_line":"                        \u0027in favor of configuration within the guest. \u0027"},{"line_number":353,"context_line":"                        \u0027Update nova.conf to address this change and \u0027"},{"line_number":354,"context_line":"                        \u0027refer to bug #1682020 for more information.\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if CONF.spice.keymap:"},{"line_number":357,"context_line":"            LOG.warning(\u0027The option \"[spice] keymap\" has been deprecated \u0027"},{"line_number":358,"context_line":"                        \u0027in favor of configuration within the guest. \u0027"},{"line_number":359,"context_line":"                        \u0027Update nova.conf to address this change and \u0027"},{"line_number":360,"context_line":"                        \u0027refer to bug #1682020 for more information.\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        self._host \u003d host.Host(self._uri(), read_only,"},{"line_number":363,"context_line":"                               lifecycle_event_handler\u003dself.emit_event,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_3bdc7a45","line":360,"range":{"start_line":350,"start_character":8,"end_line":360,"end_character":70},"in_reply_to":"ff6b8bd7_b00acc23","updated":"2018-03-07 10:18:38.000000000","message":"Done","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    opt_keymap \u003d client_factory.create(\u0027ns0:OptionValue\u0027)"},{"line_number":1003,"context_line":"    opt_keymap.key \u003d \"RemoteDisplay.vnc.keyMap\""},{"line_number":1004,"context_line":"    if CONF.vnc.keymap:"},{"line_number":1005,"context_line":"        LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated in favor \u0027"},{"line_number":1006,"context_line":"                    \u0027of the VMWare-specific \"[vmware] vnc_keymap\" option. \u0027"},{"line_number":1007,"context_line":"                    \u0027Please update nova.conf to address this change\u0027)"},{"line_number":1008,"context_line":"        opt_keymap.value \u003d CONF.vnc.keymap"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_b9b15fe4","line":1005,"updated":"2018-03-06 16:13:33.000000000","message":"Similar, this is going to get logged for every guest created. But this is also in a utility method, so it gets harder to set a flag that we\u0027ve logged it already...maybe we should check this on driver startup?","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b43fe9938eb26fb90ec4c176aff5bd38ef1350","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    opt_keymap \u003d client_factory.create(\u0027ns0:OptionValue\u0027)"},{"line_number":1003,"context_line":"    opt_keymap.key \u003d \"RemoteDisplay.vnc.keyMap\""},{"line_number":1004,"context_line":"    if CONF.vnc.keymap:"},{"line_number":1005,"context_line":"        LOG.warning(\u0027The option \"[vnc] keymap\" has been deprecated in favor \u0027"},{"line_number":1006,"context_line":"                    \u0027of the VMWare-specific \"[vmware] vnc_keymap\" option. \u0027"},{"line_number":1007,"context_line":"                    \u0027Please update nova.conf to address this change\u0027)"},{"line_number":1008,"context_line":"        opt_keymap.value \u003d CONF.vnc.keymap"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff6b8bd7_1f338bad","line":1005,"in_reply_to":"ff6b8bd7_b9b15fe4","updated":"2018-03-06 17:17:30.000000000","message":"Yup, moved to driver startup. Good idea, that","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"035ceb030b52eb22a192d22a4c53cad6684b2b93","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    opt_port.value \u003d port"},{"line_number":1002,"context_line":"    opt_keymap \u003d client_factory.create(\u0027ns0:OptionValue\u0027)"},{"line_number":1003,"context_line":"    opt_keymap.key \u003d \"RemoteDisplay.vnc.keyMap\""},{"line_number":1004,"context_line":"    if CONF.vnc.keymap:"},{"line_number":1005,"context_line":"        opt_keymap.value \u003d CONF.vnc.keymap"},{"line_number":1006,"context_line":"    else:"},{"line_number":1007,"context_line":"        opt_keymap.value \u003d CONF.vmware.vnc_keymap"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"    extras \u003d [opt_enabled, opt_port, opt_keymap]"},{"line_number":1010,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_83f5f9cd","line":1007,"range":{"start_line":1004,"start_character":4,"end_line":1007,"end_character":49},"updated":"2018-03-08 15:16:25.000000000","message":"nit: this could just be:\n\n  opt_keymap.value \u003d CONF.vnc.keymap or CONF.vmware.vnc_keymap","commit_id":"cab8139498c7ea6b05cfdc8b4997276051b943fc"}],"releasenotes/notes/deprecate-keymap-options-b41ad9f33a5923e1.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d8d7126984c7f3307c1b0a7d092b3878f58cddf9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    option only affects libvirt. For the libvirt driver, configuring these"},{"line_number":11,"context_line":"    options resulted in lossy keymap conversions for the given graphics method."},{"line_number":12,"context_line":"    It is recommended that users should unset these options and configure their"},{"line_number":13,"context_line":"    guests as necessary instead. In the case of noVNC, this requires noVNC 1.0"},{"line_number":14,"context_line":"    which provides support for the QEMU RFB extensions. Refer to `bug"},{"line_number":15,"context_line":"    #1682020`__ and the `QEMU RFB pull request`__ for more information."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    For the VMWare driver, only the VNC option applies. However, this option"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff6b8bd7_19e2cbd6","line":14,"range":{"start_line":13,"start_character":33,"end_line":14,"end_character":55},"updated":"2018-03-06 16:13:33.000000000","message":"We should mention something in here about the impact to the vnc proxy base url default value if you\u0027re using novnc \u003e\u003d 1.0.0 (the auto -\u003e lite thing).","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b43fe9938eb26fb90ec4c176aff5bd38ef1350","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    option only affects libvirt. For the libvirt driver, configuring these"},{"line_number":11,"context_line":"    options resulted in lossy keymap conversions for the given graphics method."},{"line_number":12,"context_line":"    It is recommended that users should unset these options and configure their"},{"line_number":13,"context_line":"    guests as necessary instead. In the case of noVNC, this requires noVNC 1.0"},{"line_number":14,"context_line":"    which provides support for the QEMU RFB extensions. Refer to `bug"},{"line_number":15,"context_line":"    #1682020`__ and the `QEMU RFB pull request`__ for more information."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    For the VMWare driver, only the VNC option applies. However, this option"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff6b8bd7_df13d30c","line":14,"range":{"start_line":13,"start_character":33,"end_line":14,"end_character":55},"in_reply_to":"ff6b8bd7_19e2cbd6","updated":"2018-03-06 17:17:30.000000000","message":"Done","commit_id":"dd5a677c14230ccab6cc2997bcdeb1e86cbf5d87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e76328b85d1dadd619896c3941d11e48c6fdf36","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    __ https://bugs.launchpad.net/nova/+bug/1682020"},{"line_number":27,"context_line":"    __ https://github.com/novnc/noVNC/pull/596"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    noVNC 1.0.0 introduced a breaking change in the URLs used to access the"},{"line_number":30,"context_line":"    console. Previously, the ``vnc_auto.html`` path was used but it is now"},{"line_number":31,"context_line":"    necessary to use the ``vnc_lite.html`` path. When noVNC is updated to"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff6b8bd7_ab0fbd2c","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":5},"updated":"2018-03-06 19:32:54.000000000","message":"This is going to be listed under the deprecations section of the release notes, but what you\u0027re really noting here is an upgrade impact, so it should go in the \u0027upgrades\u0027 section.","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da13603cb8c5730f7ccc72a739f508db1569d5ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    __ https://bugs.launchpad.net/nova/+bug/1682020"},{"line_number":27,"context_line":"    __ https://github.com/novnc/noVNC/pull/596"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    noVNC 1.0.0 introduced a breaking change in the URLs used to access the"},{"line_number":30,"context_line":"    console. Previously, the ``vnc_auto.html`` path was used but it is now"},{"line_number":31,"context_line":"    necessary to use the ``vnc_lite.html`` path. When noVNC is updated to"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df7087c5_fbe5a20b","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":5},"in_reply_to":"ff6b8bd7_ab0fbd2c","updated":"2018-03-07 10:18:38.000000000","message":"I meant to do that. Not sure what happened","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e76328b85d1dadd619896c3941d11e48c6fdf36","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    console. Previously, the ``vnc_auto.html`` path was used but it is now"},{"line_number":31,"context_line":"    necessary to use the ``vnc_lite.html`` path. When noVNC is updated to"},{"line_number":32,"context_line":"    1.0.0, ``[vnc] novncproxy_base_url`` configuration value must be updated on"},{"line_number":33,"context_line":"    each compute node to reflect this change. The default has been updated."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff6b8bd7_eb2615b8","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":75},"updated":"2018-03-06 19:32:54.000000000","message":"Let\u0027s not update the default here. We could consider changing the default when novnc 1.0.0 is actually in some widely used distros.","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da13603cb8c5730f7ccc72a739f508db1569d5ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    console. Previously, the ``vnc_auto.html`` path was used but it is now"},{"line_number":31,"context_line":"    necessary to use the ``vnc_lite.html`` path. When noVNC is updated to"},{"line_number":32,"context_line":"    1.0.0, ``[vnc] novncproxy_base_url`` configuration value must be updated on"},{"line_number":33,"context_line":"    each compute node to reflect this change. The default has been updated."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df7087c5_7bbbd2e4","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":75},"in_reply_to":"ff6b8bd7_eb2615b8","updated":"2018-03-07 10:18:38.000000000","message":"Done","commit_id":"a1cb196dd755742b83d2f083a85d31d3d380e160"}]}