)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"102193ef332a6d3f157bbbad47863b1a2d2c9fa5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 17:06:42 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refctor hw_verb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_e96101ab","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2017-07-16 15:53:26.000000000","message":"Refactor","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"102193ef332a6d3f157bbbad47863b1a2d2c9fa5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 17:06:42 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refctor hw_verb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_c96645c2","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"updated":"2017-07-16 15:53:26.000000000","message":"What\u0027s hw_verb? is that like the thing that follows hw_noun? :)","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f52f1fbcd4b0d776a244af0bacb7fe70eeed44d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 17:06:42 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refctor hw_verb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_496b551d","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"1f1a1f67_2975b932","updated":"2017-07-16 17:17:17.000000000","message":"oh, I know :) I was just making a funny. ;)","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f8b959199aaaf3cfbce6b093ec3a97c07b4b4989","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 17:06:42 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refctor hw_verb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_69dcd1e3","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"1f1a1f67_496b551d","updated":"2017-07-16 17:41:42.000000000","message":"Jay always fix my typo :)  he is like a human spell checker","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"82bd0a3573ab8c0ce162c0535a16ab21abfc8f0d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 17:06:42 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refctor hw_verb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_2975b932","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"1f1a1f67_c96645c2","updated":"2017-07-16 16:43:47.000000000","message":"It\u0027s probably \"hw_veb\" pronounced by a pirate. Or just an errant r.","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-16 20:38:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refctor hw_veb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_d26ed32d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2017-07-17 17:00:50.000000000","message":"s/Refctor/Refactor/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refctor hw_veb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"},{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_9274dbff","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":30},"updated":"2017-07-17 17:00:50.000000000","message":"s/support/supports/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refctor hw_veb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"},{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_72713f0c","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":42},"updated":"2017-07-17 17:00:50.000000000","message":"types: direct and macvtap","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refctor hw_veb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"},{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_5264034a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2017-07-17 17:00:50.000000000","message":"s/Echa/Each/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refctor hw_veb get config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"},{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_125a0b82","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":26},"updated":"2017-07-17 17:00:50.000000000","message":"s/diffrent/different/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hw_veb get config support 2 vnic types direct and macvtap"},{"line_number":10,"context_line":"Echa vnic type is diffrent libvirt vif backends (hostdev and"},{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change split logic to 2 diffrent function so the vif backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_d257f357","line":11,"range":{"start_line":11,"start_character":41,"end_line":11,"end_character":50},"updated":"2017-07-17 17:00:50.000000000","message":"s/configurs/configures/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change split logic to 2 diffrent function so the vif backend"},{"line_number":15,"context_line":"code can be reuse by other os-vif plugins."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_f2d30fd4","line":14,"range":{"start_line":14,"start_character":29,"end_line":14,"end_character":37},"updated":"2017-07-17 17:00:50.000000000","message":"s/diffrent/different/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"direct). The set_vif_host_backend_hw_veb configurs the"},{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change split logic to 2 diffrent function so the vif backend"},{"line_number":15,"context_line":"code can be reuse by other os-vif plugins."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_724a5fac","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":24},"updated":"2017-07-17 17:00:50.000000000","message":"s/split logic to/splits the logic into/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"vif backend according to vnic_type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change split logic to 2 diffrent function so the vif backend"},{"line_number":15,"context_line":"code can be reuse by other os-vif plugins."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iba6907d23fed30e45b6da077e075e60c5f67868f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_d2dc93e5","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":17},"updated":"2017-07-17 17:00:50.000000000","message":"s/reuse/reused/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"}],"nova/tests/unit/virt/libvirt/test_designer.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"102193ef332a6d3f157bbbad47863b1a2d2c9fa5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @mock.patch.object(pci_utils, \u0027get_pci_address_fields\u0027,"},{"line_number":144,"context_line":"                       return_value\u003d(\u0027fake-domain\u0027, \u0027fake-bus\u0027,"},{"line_number":145,"context_line":"                                     \u0027fake-slot\u0027, \u0027fake-function\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_set_vif_host_backend_hostdev_pci_config(self, mock_pci_fields):"},{"line_number":148,"context_line":"        conf \u003d config.LibvirtConfigGuestInterface()"},{"line_number":149,"context_line":"        designer.set_vif_host_backend_hostdev_pci_config(conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_094f9d34","line":146,"updated":"2017-07-16 15:53:26.000000000","message":"this line needs to go :)","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f8b959199aaaf3cfbce6b093ec3a97c07b4b4989","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @mock.patch.object(pci_utils, \u0027get_pci_address_fields\u0027,"},{"line_number":144,"context_line":"                       return_value\u003d(\u0027fake-domain\u0027, \u0027fake-bus\u0027,"},{"line_number":145,"context_line":"                                     \u0027fake-slot\u0027, \u0027fake-function\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_set_vif_host_backend_hostdev_pci_config(self, mock_pci_fields):"},{"line_number":148,"context_line":"        conf \u003d config.LibvirtConfigGuestInterface()"},{"line_number":149,"context_line":"        designer.set_vif_host_backend_hostdev_pci_config(conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_2946d9c1","line":146,"in_reply_to":"1f1a1f67_094f9d34","updated":"2017-07-16 17:41:42.000000000","message":"Done","commit_id":"3b814b073bb6b5a2bedf13c5f266d9f62f7be9fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        conf \u003d config.LibvirtConfigGuestInterface()"},{"line_number":126,"context_line":"        designer.set_vif_host_backend_direct(conf,"},{"line_number":127,"context_line":"                                             \u0027fake-devname\u0027,"},{"line_number":128,"context_line":"                                              \u0027fake-vlan\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027direct\u0027, conf.net_type)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027fake-devname\u0027, conf.source_dev)"},{"line_number":131,"context_line":"        self.assertEqual(\u0027passthrough\u0027, conf.source_mode)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_f2ec2f90","line":128,"range":{"start_line":128,"start_character":45,"end_line":128,"end_character":57},"updated":"2017-07-17 17:00:50.000000000","message":"nit: alignment","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"}],"nova/virt/libvirt/designer.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f73de1d1dded3ef1dc8a076ed0c7e5d3b585d948","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        conf.target_dev \u003d tapname"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def set_vif_host_backend_direct(conf, devname, vlan\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":115,"context_line":"    with host backend details for an device that uses a macvtap \"direct\""},{"line_number":116,"context_line":"    connection in \"passthrough\" mode to connect each guest to the network"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_b87b4d79","line":113,"in_reply_to":"","updated":"2017-07-17 05:05:25.000000000","message":"I think it would be better too name this function by its vnic type. e. g. macvtap","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        conf.target_dev \u003d tapname"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def set_vif_host_backend_direct(conf, devname, vlan\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":115,"context_line":"    with host backend details for an device that uses a macvtap \"direct\""},{"line_number":116,"context_line":"    connection in \"passthrough\" mode to connect each guest to the network"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_527be3f3","line":113,"in_reply_to":"1f1a1f67_926bbb83","updated":"2017-07-17 17:00:50.000000000","message":"Yeah, I think the only thing that is clear about the current naming is that it\u0027s entirely unclear. :)","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4730c3623dc418b786278c49413072c3a724ab97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        conf.target_dev \u003d tapname"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def set_vif_host_backend_direct(conf, devname, vlan\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":115,"context_line":"    with host backend details for an device that uses a macvtap \"direct\""},{"line_number":116,"context_line":"    connection in \"passthrough\" mode to connect each guest to the network"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_926bbb83","line":113,"in_reply_to":"1f1a1f67_b87b4d79","updated":"2017-07-17 16:43:07.000000000","message":"it will cause confusion when we will refactor the macvtap vif type. see https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L345-L374\n\nI think we need to be close here to the os-vif types see https://github.com/openstack/os-vif/blob/master/os_vif/objects/vif.py","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def set_vif_host_backend_direct(conf, devname, vlan\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":115,"context_line":"    with host backend details for an device that uses a macvtap \"direct\""},{"line_number":116,"context_line":"    connection in \"passthrough\" mode to connect each guest to the network"},{"line_number":117,"context_line":"    (note that this is not the same thing as \"PCI passthrough\")."},{"line_number":118,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_120c4b92","line":115,"range":{"start_line":115,"start_character":34,"end_line":115,"end_character":44},"updated":"2017-07-17 17:00:50.000000000","message":"s/an device/a device/","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":115,"context_line":"    with host backend details for an device that uses a macvtap \"direct\""},{"line_number":116,"context_line":"    connection in \"passthrough\" mode to connect each guest to the network"},{"line_number":117,"context_line":"    (note that this is not the same thing as \"PCI passthrough\")."},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    conf.net_type \u003d \"direct\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_d28a53bd","line":117,"updated":"2017-07-17 17:00:50.000000000","message":"It\u0027s good that you say \"this is not the same thing as PCI passthrough\", however it would be even better to include a more in-depth explanation as to what the differences actually are. :)","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f73de1d1dded3ef1dc8a076ed0c7e5d3b585d948","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    conf.vlan \u003d vlan"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def set_vif_host_backend_hostdev_ethernet(conf, pci_address, vlan\u003dNone):"},{"line_number":128,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":129,"context_line":"    with host backend details for a SR-IOV (Single Root I/O Virtualization)"},{"line_number":130,"context_line":"    virtual function (VF) device."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_d8ef291c","line":127,"updated":"2017-07-17 05:05:25.000000000","message":"This would be direct","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4730c3623dc418b786278c49413072c3a724ab97","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    conf.vlan \u003d vlan"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def set_vif_host_backend_hostdev_ethernet(conf, pci_address, vlan\u003dNone):"},{"line_number":128,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":129,"context_line":"    with host backend details for a SR-IOV (Single Root I/O Virtualization)"},{"line_number":130,"context_line":"    virtual function (VF) device."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_320ce7eb","line":127,"in_reply_to":"1f1a1f67_d8ef291c","updated":"2017-07-17 16:43:07.000000000","message":"same response has above","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f73de1d1dded3ef1dc8a076ed0c7e5d3b585d948","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        pci_address \u003d profile[\u0027pci_slot\u0027]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT:"},{"line_number":329,"context_line":"            designer.set_vif_host_backend_hostdev_ethernet("},{"line_number":330,"context_line":"                conf, pci_address, vlan)"},{"line_number":331,"context_line":"        elif vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP:"},{"line_number":332,"context_line":"            # NOTE(vladikr): Not setting vlan tags for macvtap on SR-IOV VFs"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_18e1212b","line":329,"updated":"2017-07-17 05:05:25.000000000","message":"This would become direct","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f73de1d1dded3ef1dc8a076ed0c7e5d3b585d948","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                vlan \u003d None"},{"line_number":337,"context_line":"            devname \u003d pci_utils.get_ifname_by_pci_address(pci_address)"},{"line_number":338,"context_line":"            designer.set_vif_host_backend_direct(conf, devname, vlan)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_98ce51b2","line":339,"updated":"2017-07-17 05:05:25.000000000","message":"And this would become macvtap","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"893a7697e0995dc44f975a3ef8681886df466755","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                vlan \u003d None"},{"line_number":337,"context_line":"            devname \u003d pci_utils.get_ifname_by_pci_address(pci_address)"},{"line_number":338,"context_line":"            designer.set_vif_host_backend_direct(conf, devname, vlan)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_e24e8a6d","line":339,"in_reply_to":"1f1a1f67_1ce20ba1","updated":"2017-07-18 08:33:20.000000000","message":"If you do hold a hangout, I\u0027d like to observe if you don\u0027t mind.","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"405b338e5d48fd1805adffc0e75e2d381dea2ec5","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                vlan \u003d None"},{"line_number":337,"context_line":"            devname \u003d pci_utils.get_ifname_by_pci_address(pci_address)"},{"line_number":338,"context_line":"            designer.set_vif_host_backend_direct(conf, devname, vlan)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_f248af87","line":339,"in_reply_to":"1f1a1f67_98ce51b2","updated":"2017-07-17 17:00:50.000000000","message":"Yes, after looking at this, it does indeed look like Sean is correct here.","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"485a32a658199a4baf5871528142d74d15f790b4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                vlan \u003d None"},{"line_number":337,"context_line":"            devname \u003d pci_utils.get_ifname_by_pci_address(pci_address)"},{"line_number":338,"context_line":"            designer.set_vif_host_backend_direct(conf, devname, vlan)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_1ce20ba1","line":339,"in_reply_to":"1f1a1f67_f248af87","updated":"2017-07-18 07:52:38.000000000","message":"I still disagree can we do google hangout? we need to sort all the vic_type/vif_type and plugin now everything is like wild wild west here","commit_id":"59d5c6e8392779e6300a8cdbedb4ee7641ded228"}]}