)]}'
{"nova/tests/test_linux_net.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0e3e98c6c08adf6e541695432234db6874fc023c","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        @classmethod"},{"line_number":450,"context_line":"        def test_ensure(_self, bridge, interface, network, gateway):"},{"line_number":451,"context_line":"            self.passed_interface \u003d interface"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        self.stubs.Set(linux_net.LinuxBridgeInterfaceDriver,"},{"line_number":454,"context_line":"                       \u0027ensure_bridge\u0027, test_ensure)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fy6U%3D","line":451,"updated":"2012-03-02 23:41:43.000000000","message":"Johannes has been cleaning up memory usage in tests.  Class instances live for the lifetime of tests... so using a lot of self.\u003cwhatever\u003e causes extra memory usage until the test run completes.  I think perhaps we should start recommending:\n\ninfo \u003d {\u0027passed_interface\u0027: None}\ndef test_ensure(....)\n    info[\u0027passed_interface\u0027] \u003d passed_interface\n\nand then self.assert*(info[\u0027passed_interface\u0027]) below.\n\nThat saves from polluting \u0027self\u0027 and building memory usage throughout the test run.  In this case, I realize it\u0027s minimal memory usage... but something I thought I\u0027d point out.","commit_id":"514c3270c5e76f4233257354a1c3b12f88de7647"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f95d30da8a17a9da3ec5e101d3ac1800c9034b8b","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        @classmethod"},{"line_number":450,"context_line":"        def test_ensure(_self, bridge, interface, network, gateway):"},{"line_number":451,"context_line":"            self.passed_interface \u003d interface"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        self.stubs.Set(linux_net.LinuxBridgeInterfaceDriver,"},{"line_number":454,"context_line":"                       \u0027ensure_bridge\u0027, test_ensure)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fyxw%3D","line":451,"in_reply_to":"AAAAEn%2F%2Fy0I%3D","updated":"2012-03-03 01:45:19.000000000","message":"Yeah.  This is probably not widely known...","commit_id":"514c3270c5e76f4233257354a1c3b12f88de7647"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a4a3841f139bad5e4595dcced66207ba44c6ad62","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        @classmethod"},{"line_number":450,"context_line":"        def test_ensure(_self, bridge, interface, network, gateway):"},{"line_number":451,"context_line":"            self.passed_interface \u003d interface"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        self.stubs.Set(linux_net.LinuxBridgeInterfaceDriver,"},{"line_number":454,"context_line":"                       \u0027ensure_bridge\u0027, test_ensure)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fy0I%3D","line":451,"in_reply_to":"AAAAEn%2F%2Fy6U%3D","updated":"2012-03-03 01:14:18.000000000","message":"good to know. I didn\u0027t realize that there was an issue there. I will update this and the test above.","commit_id":"514c3270c5e76f4233257354a1c3b12f88de7647"}]}