)]}'
{"nova/tests/virt/libvirt/test_libvirt_blockinfo.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c737e5e336796847aba1dd5a258bfa70af6afa2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(dev, \u0027vda\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        dev \u003d blockinfo.find_disk_dev_for_disk_bus(mapping, \u0027fdc\u0027)"},{"line_number":115,"context_line":"        self.assertEqual(dev, \u0027fda\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_get_next_disk_dev(self):"},{"line_number":118,"context_line":"        mapping \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FRyg%3D","line":115,"updated":"2013-10-01 01:13:25.000000000","message":"nit: self.assertEqual arguments are (expected, observed).","commit_id":"2dafbd871259cb9b3230402605b8b2d3e4ebaaf8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c69e38628e3a8b4eb977dff8cf85cf0d4ce61b8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(dev, \u0027vda\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        dev \u003d blockinfo.find_disk_dev_for_disk_bus(mapping, \u0027fdc\u0027)"},{"line_number":115,"context_line":"        self.assertEqual(dev, \u0027fda\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_get_next_disk_dev(self):"},{"line_number":118,"context_line":"        mapping \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FQhQ%3D","line":115,"in_reply_to":"AAAAS3%2F%2FRJQ%3D","updated":"2013-10-01 12:25:34.000000000","message":"Meh, it\u0027s a nit, I don\u0027t care all that much since the results are the same.  You\u0027ll have a harder time just getting it past Jenkins.","commit_id":"2dafbd871259cb9b3230402605b8b2d3e4ebaaf8"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c09ff27242368920578aaf68bdc63143d49daba0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(dev, \u0027vda\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        dev \u003d blockinfo.find_disk_dev_for_disk_bus(mapping, \u0027fdc\u0027)"},{"line_number":115,"context_line":"        self.assertEqual(dev, \u0027fda\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_get_next_disk_dev(self):"},{"line_number":118,"context_line":"        mapping \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FRJQ%3D","line":115,"in_reply_to":"AAAAS3%2F%2FRyg%3D","updated":"2013-10-01 08:17:46.000000000","message":"I totally copy pasted it from above. Not sure it\u0027s worth fixing without fixing all the cases above - which is a job for a separate patch","commit_id":"2dafbd871259cb9b3230402605b8b2d3e4ebaaf8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c737e5e336796847aba1dd5a258bfa70af6afa2","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        bus \u003d blockinfo.get_disk_bus_for_device_type(\u0027kvm\u0027,"},{"line_number":519,"context_line":"                                                     device_type\u003d\u0027floppy\u0027)"},{"line_number":520,"context_line":"        self.assertEqual(bus, \u0027fdc\u0027)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        image_meta \u003d {\u0027properties\u0027: {\u0027hw_disk_bus\u0027: \u0027scsi\u0027}}"},{"line_number":523,"context_line":"        bus \u003d blockinfo.get_disk_bus_for_device_type(\u0027kvm\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FRyY%3D","line":520,"updated":"2013-10-01 01:13:25.000000000","message":"Same as above.","commit_id":"2dafbd871259cb9b3230402605b8b2d3e4ebaaf8"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4e1269aa441a0eeda97b7189607677634a14820c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"       exception if the disk bus is unknown."},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if CONF.libvirt_disk_prefix:"},{"line_number":121,"context_line":"        return CONF.libvirt_disk_prefix"},{"line_number":122,"context_line":"    if disk_bus \u003d\u003d \"ide\":"},{"line_number":123,"context_line":"        return \"hd\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FJxA%3D","line":120,"updated":"2013-10-03 12:31:16.000000000","message":"Not related to this patch but this code certainly looks like it can be in a dictionary.","commit_id":"94a3073e60c7baa8613dbdc1841210636352f526"}]}