)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c46885fbbb99d3101e79d7c89ea8dd7508875402","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle missing volume vmdk during detach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During storage vMotion, the volume\u0027s vmdk may be moved"},{"line_number":10,"context_line":"to the instance\u0027s datastore folder. We handle this case"},{"line_number":11,"context_line":"during detach volume by catching FileNotFoundException"},{"line_number":12,"context_line":"raised by shadow VM relocate operation. The shadow VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_95bc576d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":22},"updated":"2017-07-20 10:54:13.000000000","message":"Huh?","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6e807d54ac3a9fa993c5418fc79492180183de19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle missing volume vmdk during detach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During storage vMotion, the volume\u0027s vmdk may be moved"},{"line_number":10,"context_line":"to the instance\u0027s datastore folder. We handle this case"},{"line_number":11,"context_line":"during detach volume by catching FileNotFoundException"},{"line_number":12,"context_line":"raised by shadow VM relocate operation. The shadow VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_e66be382","line":9,"in_reply_to":"1f1a1f67_50a24d4d","updated":"2017-07-20 12:14:36.000000000","message":"for sake of avoiding future confusion, might change to:\n\nDuring storage vMotion (live migration of a virtual machine and its disk files from one datastore to another), the volume\u0027s","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e90836e3f3749445dd1783df1ffb7532479065cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle missing volume vmdk during detach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During storage vMotion, the volume\u0027s vmdk may be moved"},{"line_number":10,"context_line":"to the instance\u0027s datastore folder. We handle this case"},{"line_number":11,"context_line":"during detach volume by catching FileNotFoundException"},{"line_number":12,"context_line":"raised by shadow VM relocate operation. The shadow VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_50a24d4d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":22},"in_reply_to":"1f1a1f67_95bc576d","updated":"2017-07-20 11:27:28.000000000","message":"This is VMware specific feature:\nhttps://pubs.vmware.com/vsphere-51/index.jsp?topic\u003d%2Fcom.vmware.vsphere.vcenterhost.doc%2FGUID-AB266895-BAA4-4BF3-894E-47F99DC7B77F.html","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"11cd840d03a8624a57d36aea28154f3ff0d3f6bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle missing volume vmdk during detach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During storage vMotion, the volume\u0027s vmdk may be moved"},{"line_number":10,"context_line":"to the instance\u0027s datastore folder. We handle this case"},{"line_number":11,"context_line":"during detach volume by catching FileNotFoundException"},{"line_number":12,"context_line":"raised by shadow VM relocate operation. The shadow VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_f9193d22","line":9,"in_reply_to":"1f1a1f67_e66be382","updated":"2017-07-20 14:30:46.000000000","message":"Done","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b75ed38f700ddb383ca81531804fc79ae798c0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle missing volume vmdk during detach"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During storage vMotion, the volume\u0027s vmdk may be moved"},{"line_number":10,"context_line":"to the instance\u0027s datastore folder. We handle this case"},{"line_number":11,"context_line":"during detach volume by catching FileNotFoundException"},{"line_number":12,"context_line":"raised by shadow VM relocate operation. The shadow VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_3a745699","line":9,"in_reply_to":"1f1a1f67_f9193d22","updated":"2017-08-22 16:32:34.000000000","message":"Ta","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c46885fbbb99d3101e79d7c89ea8dd7508875402","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.detach_disk_from_vm(volume_ref, instance,"},{"line_number":495,"context_line":"                                         original_device, destroy_disk\u003dTrue)"},{"line_number":496,"context_line":"            except oslo_vmw_exceptions.FileNotFoundException:"},{"line_number":497,"context_line":"                LOG.debug(\"Volume backing: %s is missing.\","},{"line_number":498,"context_line":"                          original_device.backing.fileName)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Attach the current volume to the volume_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_d5908ff0","line":497,"range":{"start_line":497,"start_character":20,"end_line":497,"end_character":25},"updated":"2017-07-20 10:54:13.000000000","message":"Should this not be a higher level warning?","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"11cd840d03a8624a57d36aea28154f3ff0d3f6bf","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.detach_disk_from_vm(volume_ref, instance,"},{"line_number":495,"context_line":"                                         original_device, destroy_disk\u003dTrue)"},{"line_number":496,"context_line":"            except oslo_vmw_exceptions.FileNotFoundException:"},{"line_number":497,"context_line":"                LOG.debug(\"Volume backing: %s is missing.\","},{"line_number":498,"context_line":"                          original_device.backing.fileName)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Attach the current volume to the volume_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_99d6c927","line":497,"in_reply_to":"1f1a1f67_6626b36b","updated":"2017-07-20 14:30:46.000000000","message":"Done","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6e807d54ac3a9fa993c5418fc79492180183de19","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.detach_disk_from_vm(volume_ref, instance,"},{"line_number":495,"context_line":"                                         original_device, destroy_disk\u003dTrue)"},{"line_number":496,"context_line":"            except oslo_vmw_exceptions.FileNotFoundException:"},{"line_number":497,"context_line":"                LOG.debug(\"Volume backing: %s is missing.\","},{"line_number":498,"context_line":"                          original_device.backing.fileName)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Attach the current volume to the volume_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_6626b36b","line":497,"in_reply_to":"1f1a1f67_70b6698d","updated":"2017-07-20 12:14:36.000000000","message":"debug is fine since it is a somewhat expected situation, but the message could be more clear about the fact that the situation is being handled.","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b75ed38f700ddb383ca81531804fc79ae798c0b","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.detach_disk_from_vm(volume_ref, instance,"},{"line_number":495,"context_line":"                                         original_device, destroy_disk\u003dTrue)"},{"line_number":496,"context_line":"            except oslo_vmw_exceptions.FileNotFoundException:"},{"line_number":497,"context_line":"                LOG.debug(\"Volume backing: %s is missing.\","},{"line_number":498,"context_line":"                          original_device.backing.fileName)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Attach the current volume to the volume_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_da62f2d8","line":497,"in_reply_to":"1f1a1f67_99d6c927","updated":"2017-08-22 16:32:34.000000000","message":"(y)","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e90836e3f3749445dd1783df1ffb7532479065cd","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.detach_disk_from_vm(volume_ref, instance,"},{"line_number":495,"context_line":"                                         original_device, destroy_disk\u003dTrue)"},{"line_number":496,"context_line":"            except oslo_vmw_exceptions.FileNotFoundException:"},{"line_number":497,"context_line":"                LOG.debug(\"Volume backing: %s is missing.\","},{"line_number":498,"context_line":"                          original_device.backing.fileName)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Attach the current volume to the volume_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_70b6698d","line":497,"range":{"start_line":497,"start_character":20,"end_line":497,"end_character":25},"in_reply_to":"1f1a1f67_d5908ff0","updated":"2017-07-20 11:27:28.000000000","message":"I think debug is fine because we can handle this exception well","commit_id":"992ec93a6aee2b13f18bcbfae8e16d7cc835ea49"}]}