)]}'
{"nova/tests/functional/api/openstack/placement/gabbits/shared-resources.yaml":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"461d7fffb9a971210de1b755c6092a105a9f1745","unresolved":false,"context_lines":[{"line_number":76,"context_line":"              total: 5"},{"line_number":77,"context_line":"  status: 200"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# no aggregate association"},{"line_number":80,"context_line":"- name: get resources no agg"},{"line_number":81,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":82,"context_line":"  response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_f587dd0e","line":79,"updated":"2017-07-21 11:41:49.000000000","message":"+1","commit_id":"b4b4a016bca65b1101deb07c5770f0ff5139e106"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"461d7fffb9a971210de1b755c6092a105a9f1745","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  data:"},{"line_number":100,"context_line":"      - f3dc0f36-97d4-4daf-be0c-d71466da9c85"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# no shared trait"},{"line_number":103,"context_line":"- name: get resources no shared"},{"line_number":104,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":105,"context_line":"  response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_15837906","line":102,"updated":"2017-07-21 11:41:49.000000000","message":"+1","commit_id":"b4b4a016bca65b1101deb07c5770f0ff5139e106"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2b4c932777f8987be2c561809e8e577ca66e8da0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  xfail: true"},{"line_number":125,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":126,"context_line":"  response_json_paths:"},{"line_number":127,"context_line":"      $.resource_providers.`len`: 1"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- name: get allocation candidates shared"},{"line_number":130,"context_line":"  desc: this sometimes fails, with 0 results"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_575fb10d","line":127,"updated":"2017-07-21 14:34:20.000000000","message":"This actually is correct. GET /resource_providers returns resource providers that either have the requested resources locally *or* have some of the requested resources and the remainder are filled by a sharing provider. GET /resource_providers does *not* (and was not intended to) return information about providers that share resources. It is only intended to return the root resource providers that are able to satisfy ALL of the requested resources (either locally or via some sharing link). GET /allocation_candidates is intended to return the HTTP request bodies for calls to PUT /allocations/{consumer_uuid} which would fulfill the request for resources.","commit_id":"b4b4a016bca65b1101deb07c5770f0ff5139e106"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b4c5cd414c7fa5f05fea3895dbc9c1f3f4ae73b3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  xfail: true"},{"line_number":125,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":126,"context_line":"  response_json_paths:"},{"line_number":127,"context_line":"      $.resource_providers.`len`: 1"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- name: get allocation candidates shared"},{"line_number":130,"context_line":"  desc: this sometimes fails, with 0 results"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_9e2d61ff","line":127,"in_reply_to":"1f1a1f67_575fb10d","updated":"2017-07-21 15:48:10.000000000","message":"Okay, thanks for making that explicit, I\u0027m not sure it has been stated as such before (at least not where I\u0027ve been able to digest it). I\u0027ll adjust the test so it asserts those things properly.","commit_id":"b4b4a016bca65b1101deb07c5770f0ff5139e106"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ae5c863f3b3ec83088aefd9efb936dbea147dc64","unresolved":false,"context_lines":[{"line_number":119,"context_line":"      traits:"},{"line_number":120,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# this should be zero because we only expect those resource which can"},{"line_number":123,"context_line":"# fully satisfy the resources query when making requests of"},{"line_number":124,"context_line":"# /resource_providers. This may change in the future depending on use"},{"line_number":125,"context_line":"# cases."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_be39a6d7","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":59},"updated":"2017-09-29 12:09:11.000000000","message":"those resource providers?","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"76ac6fba929bc3ab9624e42c94cd4785ffd0a3c8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"      traits:"},{"line_number":120,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# this should be zero because we only expect those resource which can"},{"line_number":123,"context_line":"# fully satisfy the resources query when making requests of"},{"line_number":124,"context_line":"# /resource_providers. This may change in the future depending on use"},{"line_number":125,"context_line":"# cases."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_fef4bef2","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":59},"in_reply_to":"7f515b1d_be39a6d7","updated":"2017-09-29 12:20:58.000000000","message":"yeah will fix that","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5bf897dc141c85c0622e970956694c8ff13d23bc","unresolved":false,"context_lines":[{"line_number":119,"context_line":"      traits:"},{"line_number":120,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# this should be zero because we only expect those resource which can"},{"line_number":123,"context_line":"# fully satisfy the resources query when making requests of"},{"line_number":124,"context_line":"# /resource_providers. This may change in the future depending on use"},{"line_number":125,"context_line":"# cases."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_8fe0f227","line":122,"range":{"start_line":122,"start_character":45,"end_line":122,"end_character":59},"in_reply_to":"7f515b1d_fef4bef2","updated":"2017-09-29 15:03:21.000000000","message":"Done","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ae5c863f3b3ec83088aefd9efb936dbea147dc64","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  xfail: true"},{"line_number":128,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":129,"context_line":"  response_json_paths:"},{"line_number":130,"context_line":"      $.resource_providers.`len`: 0"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# this is one allocation request and two resource providers because"},{"line_number":133,"context_line":"# at /allocation_candiates we expect those resource providers which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_3e537619","line":130,"updated":"2017-09-29 12:09:11.000000000","message":"Is this empty because there is no single resource provider that provides both VCPU and CUSTOM_MAGIC?\nJust want to validate my understanding.","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"76ac6fba929bc3ab9624e42c94cd4785ffd0a3c8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  xfail: true"},{"line_number":128,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":129,"context_line":"  response_json_paths:"},{"line_number":130,"context_line":"      $.resource_providers.`len`: 0"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# this is one allocation request and two resource providers because"},{"line_number":133,"context_line":"# at /allocation_candiates we expect those resource providers which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_fecddeb6","line":130,"in_reply_to":"7f515b1d_3e537619","updated":"2017-09-29 12:20:58.000000000","message":"yes, that\u0027s the case. There\u0027s discussion further up the comment stack but it\u0027s pretty clear the commentary here needs to be more explicit about what\u0027s going on so I\u0027ll do another version.","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5bf897dc141c85c0622e970956694c8ff13d23bc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  xfail: true"},{"line_number":128,"context_line":"  GET: /resource_providers?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":129,"context_line":"  response_json_paths:"},{"line_number":130,"context_line":"      $.resource_providers.`len`: 0"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# this is one allocation request and two resource providers because"},{"line_number":133,"context_line":"# at /allocation_candiates we expect those resource providers which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_6fd5b643","line":130,"in_reply_to":"7f515b1d_fecddeb6","updated":"2017-09-29 15:03:21.000000000","message":"Done","commit_id":"3c8e471f7579c308982dcdcae6bcb44f30d73d59"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"747549ac71152af4cbb202516a08fa07956c8a90","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      $.resource_providers.`len`: 0"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- name: get allocation candidates no shared"},{"line_number":109,"context_line":"  desc: this sometimes fails"},{"line_number":110,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":111,"context_line":"  response_json_paths:"},{"line_number":112,"context_line":"      $.allocation_requests.`len`: 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_9afd9db3","line":109,"updated":"2017-10-03 15:59:57.000000000","message":"Does this still fail sometimes?","commit_id":"89173dbe5971286141d70963e831445d7f521096"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3f823f8ca9fbeed7e5c9c8cb0db38aa781698cc3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      $.resource_providers.`len`: 0"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- name: get allocation candidates no shared"},{"line_number":109,"context_line":"  desc: this sometimes fails"},{"line_number":110,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1,CUSTOM_MAGIC:1"},{"line_number":111,"context_line":"  response_json_paths:"},{"line_number":112,"context_line":"      $.allocation_requests.`len`: 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_5a65e544","line":109,"in_reply_to":"7f515b1d_9afd9db3","updated":"2017-10-03 16:13:30.000000000","message":"no, I meant to fix that\n\nAfter this inevitably fails its next gate run I\u0027ll fix this and the typo below.","commit_id":"89173dbe5971286141d70963e831445d7f521096"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d6d88ed397125b9b52aa301f62d23751f2dcb371","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          - MISC_SHARES_VIA_AGGREGATE"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# this should be zero because we only expect those resource providers which"},{"line_number":123,"context_line":"# can fully satisfy the resources query themsevles when making requests of"},{"line_number":124,"context_line":"# /resource_providers. This may change in the future depending on use"},{"line_number":125,"context_line":"# cases. This test and the next demonstrate and confirm that"},{"line_number":126,"context_line":"# /resource_providers and /allocation_candidates have different behaviors."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_1c1549e5","line":123,"range":{"start_line":123,"start_character":40,"end_line":123,"end_character":50},"updated":"2017-10-02 08:19:53.000000000","message":"nit: themselves","commit_id":"89173dbe5971286141d70963e831445d7f521096"}]}