)]}'
{"id":"openstack%2Fnova~4856","triplet_id":"openstack%2Fnova~master~I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6","project":"openstack/nova","branch":"master","topic":"bug891756","hashtags":[],"change_id":"I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6","subject":"Clean up the shared storage check (#891756)","status":"MERGED","created":"2012-03-03 01:52:19.000000000","updated":"2012-03-26 21:30:46.000000000","submitted":"2012-03-26 21:30:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":22,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a37db11f6637f6a1cde7832ce20dc5862ab7c65f","_number":4856,"virtual_id_number":4856,"owner":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-03-26 21:30:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":2,"date":"2012-03-26 20:38:11.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-03-26 21:03:40.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-03-26 21:30:43.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"date":"2012-03-26 20:38:11.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-03-26 21:03:40.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-12 18:37:25.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-03-15 00:28:03.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2012-03-26 19:31:49.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-03-26 20:38:11.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2012-03-26 21:03:40.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-03-26 21:30:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c4f682709cacdd9ea6c7dbc851f1676bb050dda3","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-03-03 02:06:49.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nThanks for taking this on.  Comment inline.","accounts_in_message":[],"_revision_number":1},{"id":"32ce80e9ab03ac0493d9a815b8196735842d4370","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-06 23:27:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"97dfa7390d5565f4e72592bd12f37828f0925fdb","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-07 11:30:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nI think we can clean this up significantly by just removing the exception handling","accounts_in_message":[],"_revision_number":2},{"id":"465a3ac4c2dc8f1170cc330af2fec9bf46a1e2c6","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-09 23:36:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"88ac8a951a839b2d59941ae9cd1df6a37ef633d4","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-03-12 18:37:25.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nOne tiny thing.","accounts_in_message":[],"_revision_number":3},{"id":"4479366cd3ec02dff633d8ef26c454f4a175cb75","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-03-12 22:54:07.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nNeeds info.  Comments inline.","accounts_in_message":[],"_revision_number":3},{"id":"3612396c897ea6585c4bf34dd6f77e221f7c9e39","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-15 00:02:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"9743d174d65f6430fa31bab038cb43ca13c8ed54","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-03-15 00:28:03.000000000","message":"Patch Set 4: (1 inline comment)\n\nQuestion/comment inline.","accounts_in_message":[],"_revision_number":4},{"id":"8ffdfb793a887a88e0dfda4ad453659bf9010313","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-15 00:36:56.000000000","message":"Patch Set 4: (1 inline comment)\n\nIn line response.","accounts_in_message":[],"_revision_number":4},{"id":"fd9a7c30251433604dac3e17328852fe0dbcd14a","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-03-16 22:17:20.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nok, I\u0027m cool with that response.","accounts_in_message":[],"_revision_number":4},{"id":"1aae8aecf2e30f5165a4d0dd2c6d8e4f1b0c7847","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-17 22:56:38.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"db7f07201e7e4150b8e8b291a22ffd5ecc6ef395","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-17 23:07:15.000000000","message":"Patch Set 4: Fails; I would prefer that you didn\u0027t submit this\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2677/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1929/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1585/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3310/ : UNSTABLE","accounts_in_message":[],"_revision_number":4},{"id":"d0b8ffeb4d3f8e5e2c2482f0886497d064368af7","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-17 23:09:59.000000000","message":"Patch Set 4:\n\nlooks like you need some more updates on tests and a pep8 fix.","accounts_in_message":[],"_revision_number":4},{"id":"d4e195c4c9e63537ebfddb691545cb264fb9f06e","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-17 23:10:08.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this; No score\n\n","accounts_in_message":[],"_revision_number":4},{"id":"0aba6c4d71fe9d17b281109657a4b7abe6a0c924","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-17 23:27:08.000000000","message":"Patch Set 4:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2679/ : ABORTED \nhttps://jenkins.openstack.org/job/gate-nova-merge/1931/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1587/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3312/ : UNSTABLE","accounts_in_message":[],"_revision_number":4},{"id":"a362167a1e3e1be408667c9f4d9ec703eb15cf65","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-20 12:20:01.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this\n\n(6 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"f6a931c08684ccf2156b1f5197c17d636f4bd120","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-26 17:48:14.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ccad2d12176794a7e97521a7aa3c76b09e26a92e","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-26 17:48:43.000000000","message":"Patch Set 4: (5 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"694f68580e9db63eb199c656c3b99f949b540f25","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-03-26 19:31:49.000000000","message":"Patch Set 5:\n\nSmokeStack Results (patch set 5):\n\tUnit Failed:Nova tests failed. Nova pep8 failed.  http://smokestack.openstack.org/?go\u003d/jobs/16497\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/16495\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/16496","accounts_in_message":[],"_revision_number":5},{"id":"950dbcd9d330864178acaa77052c9818afc814e9","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-26 20:04:20.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t submit this\n\n(3 inline comments)\n\nThanks for your patience on this - I think it\u0027s been worth it, this is a really great improvement","accounts_in_message":[],"_revision_number":5},{"id":"c238511bc517669b35ed8ab93cf889efd6e10667","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-26 20:29:38.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"368fc5e5aebe5f965e42bd00d18c62f3b6435128","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-26 20:35:00.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f0943f6f65b203301d931192cd67fcb7614b74db","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-26 20:35:58.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\nThanks","accounts_in_message":[],"_revision_number":7},{"id":"9a19ae7ae2e3f1372c841af653560f6f8b942146","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2012-03-26 20:36:49.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"34e9e73769c9d0d9712ebfea9bd15e74cd659961","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-03-26 20:38:11.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"3bae60d556049833481403a69723e2edc982657c","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-26 21:03:40.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\nlooks good.  FFR, you need to put \u0027bug\u0027 before the number for it to automatically link.","accounts_in_message":[],"_revision_number":8},{"id":"5e3ae06e41c2fe68112188ba9c59c83e48a62a85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-26 21:30:43.000000000","message":"Patch Set 8: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2988/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/2031/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1687/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3420/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"834234e8794761fe466ffdce6fd258a8d3972585","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-26 21:30:45.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"30aec4a3f67144d55caded298c691503a6a57ed1","revisions":{"df13fd48fedcf084f3bec8b93cb84f98fb0c4acf":{"kind":"REWORK","_number":1,"created":"2012-03-03 01:52:19.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/1"}}},"commit":{"parents":[{"commit":"d9097f35cd391fcd5a8ec735abd3b53e634bfa14","subject":"Merge \"Adds soft-reboot support to libvirt\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d9097f35cd391fcd5a8ec735abd3b53e634bfa14"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-03 01:51:47.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/df13fd48fedcf084f3bec8b93cb84f98fb0c4acf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/df13fd48fedcf084f3bec8b93cb84f98fb0c4acf"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d9097f35cd391fcd5a8ec735abd3b53e634bfa14","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9c29ab810c34065baa9a21e0a7805cf02344ec16":{"kind":"REWORK","_number":2,"created":"2012-03-06 23:27:09.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/2"}}},"commit":{"parents":[{"commit":"67715309a1cda8cc56bf4e528774f75e652bf6d5","subject":"Merge \"Ensure image status filter matches glance format\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67715309a1cda8cc56bf4e528774f75e652bf6d5"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-06 23:26:30.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\nProperly check for Remote Exception.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9c29ab810c34065baa9a21e0a7805cf02344ec16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9c29ab810c34065baa9a21e0a7805cf02344ec16"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"67715309a1cda8cc56bf4e528774f75e652bf6d5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"61d68b107eab3ff090b578f8989cb8ece4028f27":{"kind":"REWORK","_number":3,"created":"2012-03-09 23:36:15.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/3"}}},"commit":{"parents":[{"commit":"f936594d9e37abf4d8c22c2545a9b67ed8f25c90","subject":"Reduce duplicated code in xenapi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f936594d9e37abf4d8c22c2545a9b67ed8f25c90"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-09 23:34:23.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\nProperly check for Remote Exception.\nImplement Mark\u0027s suggestions and fix test to match.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61d68b107eab3ff090b578f8989cb8ece4028f27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61d68b107eab3ff090b578f8989cb8ece4028f27"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f936594d9e37abf4d8c22c2545a9b67ed8f25c90","is_merged_in_target_branch":true,"change_id":"I34ea03fc1fb3cb5d5d343cffa28da5bf3dff888b","change_number":5165,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"66f10936db5524196de2c69ea9f70b9fd37fef2a":{"kind":"REWORK","_number":4,"created":"2012-03-15 00:02:50.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/4"}}},"commit":{"parents":[{"commit":"e0d14ca213198500014bf53d5843fa07aaded366","subject":"Merge \"metadata speed - revert logic changes, just caching\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e0d14ca213198500014bf53d5843fa07aaded366"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-15 00:02:19.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\nProperly check for Remote Exception.\nImplement Mark\u0027s suggestions and fix test to match.\nRemoved unneeded initializer and changed file removal to a cast per\nChris Behrens\u0027 suggestions.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66f10936db5524196de2c69ea9f70b9fd37fef2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66f10936db5524196de2c69ea9f70b9fd37fef2a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e0d14ca213198500014bf53d5843fa07aaded366","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"60a8a01c4fd08c88a6644d5772c5c37ecbb07c25":{"kind":"REWORK","_number":5,"created":"2012-03-26 17:48:14.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/5"}}},"commit":{"parents":[{"commit":"129150c853c635b28238b2ac6bd3193c453b08a7","subject":"Merge \"Reordered the alphabet.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/129150c853c635b28238b2ac6bd3193c453b08a7"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-26 17:47:34.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\nProperly check for Remote Exception.\nImplement Mark\u0027s suggestions and fix test to match.\nRemoved unneeded initializer and changed file removal to a cast per\nChris Behrens\u0027 suggestions.\nChanges suggested by Mark McLoughlin\nAlso fixed tests.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/60a8a01c4fd08c88a6644d5772c5c37ecbb07c25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/60a8a01c4fd08c88a6644d5772c5c37ecbb07c25"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"129150c853c635b28238b2ac6bd3193c453b08a7","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"2a491bcff7f430594b1935148d1208cd20130408":{"kind":"REWORK","_number":6,"created":"2012-03-26 20:29:38.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/6"}}},"commit":{"parents":[{"commit":"3433fd65d5f70d83ffa4db013f96c55970ea293e","subject":"Merge \"Improve performance of safe_log().\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3433fd65d5f70d83ffa4db013f96c55970ea293e"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-26 20:29:22.000000000","tz":0},"subject":"Proposed fix for bug 891756","message":"Proposed fix for bug 891756\n\nCleans up the objectionable exception paths.\nProperly check for Remote Exception.\nImplement Mark\u0027s suggestions and fix test to match.\nRemoved unneeded initializer and changed file removal to a cast per\nChris Behrens\u0027 suggestions.\nChanges suggested by Mark McLoughlin\nAlso fixed tests.\nPEP8 fix\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a491bcff7f430594b1935148d1208cd20130408"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a491bcff7f430594b1935148d1208cd20130408"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3433fd65d5f70d83ffa4db013f96c55970ea293e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"8f1aa5b1db8153eb7a02dc85f8b401600094f705":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2012-03-26 20:35:00.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/7"}}},"commit":{"parents":[{"commit":"3433fd65d5f70d83ffa4db013f96c55970ea293e","subject":"Merge \"Improve performance of safe_log().\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3433fd65d5f70d83ffa4db013f96c55970ea293e"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-26 20:32:18.000000000","tz":0},"subject":"Clean up the live/block migration shared storage check (#891756)","message":"Clean up the live/block migration shared storage check (#891756)\n\nThe shared storage check for live and block migration is currently\nvery confusing e.g.\n\n  * The mounted_on_same_shared_storage() method raises FileNotFound\n    for the caller to catch rather than just returning a boolean to\n    indicate whether the hosts share storage\n\n  * mounted_on_same_shared_storage() has a \"filename is not None\" check\n    in its finally clause which doesn\u0027t make sense\n\n  * InvalidSharedStorage is not raised in the live migration case,\n\n  * instead\n    FileNotFound is raised\n\nClean all this up by having mounted_on_same_shared_storage() simply\nreturn a boolean and have simple logic to raise InvalidSharedStorage for live\nmigration where no shared storage is available or for block migration where\nshared storage is available.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8f1aa5b1db8153eb7a02dc85f8b401600094f705"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8f1aa5b1db8153eb7a02dc85f8b401600094f705"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3433fd65d5f70d83ffa4db013f96c55970ea293e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"30aec4a3f67144d55caded298c691503a6a57ed1":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2012-03-26 20:36:49.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/56/4856/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/4856/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/4856/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/4856/8"}}},"commit":{"parents":[{"commit":"3433fd65d5f70d83ffa4db013f96c55970ea293e","subject":"Merge \"Improve performance of safe_log().\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3433fd65d5f70d83ffa4db013f96c55970ea293e"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-02 21:25:25.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2012-03-26 20:36:04.000000000","tz":0},"subject":"Clean up the shared storage check (#891756)","message":"Clean up the shared storage check (#891756)\n\nThe shared storage check for live and block migration is currently\nvery confusing e.g.\n\n  * The mounted_on_same_shared_storage() method raises FileNotFound\n    for the caller to catch rather than just returning a boolean to\n    indicate whether the hosts share storage\n\n  * mounted_on_same_shared_storage() has a \"filename is not None\" check\n    in its finally clause which doesn\u0027t make sense\n\n  * InvalidSharedStorage is not raised in the live migration case,\n\n  * instead\n    FileNotFound is raised\n\nClean all this up by having mounted_on_same_shared_storage() simply\nreturn a boolean and have simple logic to raise InvalidSharedStorage for live\nmigration where no shared storage is available or for block migration where\nshared storage is available.\n\nChange-Id: I96f354fe41d9ce77c4cc98903f0d5a9de99ac4f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30aec4a3f67144d55caded298c691503a6a57ed1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30aec4a3f67144d55caded298c691503a6a57ed1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3433fd65d5f70d83ffa4db013f96c55970ea293e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}