)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"902b8fcb195467f769657f877d4f7eb50b4a7070","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kashyap Chamarthy \u003ckchamart@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-20 19:25:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt/driver.py: Set cache value for Cinder volume post-migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was noticed in a downstream bug when a Nova instance with Cinder"},{"line_number":10,"context_line":"volume (in this case, both the Nova instance storage _and_ Cinder volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_7d6647f0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"updated":"2017-07-24 09:59:23.000000000","message":"supernit - libvirt: is enough, I\u0027ve not seen anyone reference files like this in a commit subject tbh.","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4bc1f7fbafcc66aba268380f8383dad7c66c0302","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kashyap Chamarthy \u003ckchamart@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-20 19:25:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt/driver.py: Set cache value for Cinder volume post-migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was noticed in a downstream bug when a Nova instance with Cinder"},{"line_number":10,"context_line":"volume (in this case, both the Nova instance storage _and_ Cinder volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_6e27a814","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"in_reply_to":"ff346bd7_7d6647f0","updated":"2017-07-24 13:23:55.000000000","message":"Fixed in PS-2.\n\nBut sometimes I find it useful to refer a subsystem *within* libvirt, as libvirt supports multiple hypervisors. E.g.: \"libvirt: qemu: [...]\"","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"902b8fcb195467f769657f877d4f7eb50b4a7070","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"From a chat with Daniel Berrangé on IRC: Prior to live migration, Nova"},{"line_number":44,"context_line":"rewrites all the \u003cdisk\u003e elements, and passes this updated guest XML"},{"line_number":45,"context_line":"across to target libvirt.  And it is never calling _set_disk_cache()"},{"line_number":46,"context_line":"when doing this.  So `nova.conf`\u0027s `writeback` setting is getting lost,"},{"line_number":47,"context_line":"leaving the default `cache\u003dnone` setting.  And this mistake (of leaving"},{"line_number":48,"context_line":"the default cache value to \u0027none\u0027) will of course be correct when you"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_5d4a6355","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":66},"updated":"2017-07-24 09:59:23.000000000","message":"_set_cache_mode","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4bc1f7fbafcc66aba268380f8383dad7c66c0302","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"From a chat with Daniel Berrangé on IRC: Prior to live migration, Nova"},{"line_number":44,"context_line":"rewrites all the \u003cdisk\u003e elements, and passes this updated guest XML"},{"line_number":45,"context_line":"across to target libvirt.  And it is never calling _set_disk_cache()"},{"line_number":46,"context_line":"when doing this.  So `nova.conf`\u0027s `writeback` setting is getting lost,"},{"line_number":47,"context_line":"leaving the default `cache\u003dnone` setting.  And this mistake (of leaving"},{"line_number":48,"context_line":"the default cache value to \u0027none\u0027) will of course be correct when you"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_ee7838f9","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":66},"in_reply_to":"ff346bd7_5d4a6355","updated":"2017-07-24 13:23:55.000000000","message":"Fixed in PS-2","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"902b8fcb195467f769657f877d4f7eb50b4a7070","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            disk_info[\u0027unit\u0027] \u003d self._get_scsi_controller_max_unit(guest) + 1"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1238,"context_line":"        self._set_cache_mode(conf)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"        self._check_discard_for_attach_volume(conf, instance)"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_7d94078c","line":1238,"range":{"start_line":1238,"start_character":8,"end_line":1238,"end_character":34},"updated":"2017-07-24 09:59:23.000000000","message":"We can also remove this.","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4bc1f7fbafcc66aba268380f8383dad7c66c0302","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            disk_info[\u0027unit\u0027] \u003d self._get_scsi_controller_max_unit(guest) + 1"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1238,"context_line":"        self._set_cache_mode(conf)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"        self._check_discard_for_attach_volume(conf, instance)"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_2e764008","line":1238,"range":{"start_line":1238,"start_character":8,"end_line":1238,"end_character":34},"in_reply_to":"ff346bd7_7d94078c","updated":"2017-07-24 13:23:55.000000000","message":"Good catch, done in PS-2.","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"902b8fcb195467f769657f877d4f7eb50b4a7070","unresolved":false,"context_lines":[{"line_number":3785,"context_line":"            vol[\u0027connection_info\u0027] \u003d connection_info"},{"line_number":3786,"context_line":"            vol.save()"},{"line_number":3787,"context_line":""},{"line_number":3788,"context_line":"        for d in devices:"},{"line_number":3789,"context_line":"            self._set_cache_mode(d)"},{"line_number":3790,"context_line":""},{"line_number":3791,"context_line":"        if scsi_controller:"},{"line_number":3792,"context_line":"            devices.append(scsi_controller)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_dd089329","line":3789,"range":{"start_line":3788,"start_character":0,"end_line":3789,"end_character":35},"updated":"2017-07-24 09:59:23.000000000","message":"We can remove this now given the _get_volume_config call for each item in devices above.","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4bc1f7fbafcc66aba268380f8383dad7c66c0302","unresolved":false,"context_lines":[{"line_number":3785,"context_line":"            vol[\u0027connection_info\u0027] \u003d connection_info"},{"line_number":3786,"context_line":"            vol.save()"},{"line_number":3787,"context_line":""},{"line_number":3788,"context_line":"        for d in devices:"},{"line_number":3789,"context_line":"            self._set_cache_mode(d)"},{"line_number":3790,"context_line":""},{"line_number":3791,"context_line":"        if scsi_controller:"},{"line_number":3792,"context_line":"            devices.append(scsi_controller)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_eec6f816","line":3789,"range":{"start_line":3788,"start_character":0,"end_line":3789,"end_character":35},"in_reply_to":"ff346bd7_dd089329","updated":"2017-07-24 13:23:55.000000000","message":"Likewise, done in PS-2.","commit_id":"ce01bb5cfd14f3d78ae2a6047023960bad690b35"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"5dca5d494d5cc74ae5cada746c0f4504189d01be","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027:"},{"line_number":1233,"context_line":"            disk_info[\u0027unit\u0027] \u003d self._get_scsi_controller_max_unit(guest) + 1"},{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1236,"context_line":"        self._set_cache_mode(conf)"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        self._check_discard_for_attach_volume(conf, instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_ba9eea04","side":"PARENT","line":1235,"updated":"2017-07-24 15:07:49.000000000","message":"This \u0027conf\u0027 line should not be removed, will add it back in the next iteration.","commit_id":"79f6920eac135ab67476f75cc1d281e295cf0c84"}]}