)]}'
{"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":988,"context_line":"        self.assertEqual(instance.vm_state, vm_states.ERROR)"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def test_unshelve_offloaded_instance_image_id_is_none(self):"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":993,"context_line":"        instance.vm_state \u003d vm_states.SHELVED_OFFLOADED"},{"line_number":994,"context_line":"        instance.task_state \u003d task_states.UNSHELVING"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_ed4c5043","side":"PARENT","line":991,"updated":"2017-07-27 03:02:06.000000000","message":"unrelated","commit_id":"f590636b596708955026c9a90f1cc93eaba4a015"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                    populate_retry, populate_filter_properties,"},{"line_number":945,"context_line":"                    unshelve_instance, get_by_instance_uuid):"},{"line_number":946,"context_line":"            cell_mapping \u003d objects.CellMapping.get_by_uuid(self.context,"},{"line_number":947,"context_line":"                                                         uuids.cell1)"},{"line_number":948,"context_line":"            get_by_instance_uuid.return_value \u003d objects.InstanceMapping("},{"line_number":949,"context_line":"                cell_mapping\u003dcell_mapping)"},{"line_number":950,"context_line":"            to_filtprops.return_value \u003d filter_properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_8dba6407","line":947,"updated":"2017-07-27 03:02:06.000000000","message":"nit: alignment","commit_id":"476caa0884eadf7ad4e42c17fe953a6df84c2f7d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":957,"context_line":"                    filter_properties)"},{"line_number":958,"context_line":"            sched_instances.assert_called_once_with(self.context, fake_spec,"},{"line_number":959,"context_line":"                    [instance.uuid])"},{"line_number":960,"context_line":"            self.assertEqual(fake_spec.requested_destination.cell,"},{"line_number":961,"context_line":"                             cell_mapping)"},{"line_number":962,"context_line":"            # NOTE(sbauza): Since the instance is dehydrated when passing"},{"line_number":963,"context_line":"            # through the RPC API, we can only assert mock.ANY for it"},{"line_number":964,"context_line":"            unshelve_instance.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_2d3ff887","line":961,"range":{"start_line":960,"start_character":29,"end_line":961,"end_character":41},"updated":"2017-07-27 03:02:06.000000000","message":"nit: The args should be reversed (expected, actual).","commit_id":"476caa0884eadf7ad4e42c17fe953a6df84c2f7d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"                                           \u0027nodename\u0027: \u0027fake_node\u0027,"},{"line_number":1014,"context_line":"                                           \u0027limits\u0027: {}}]"},{"line_number":1015,"context_line":"            get_by_instance_uuid.return_value \u003d objects.InstanceMapping("},{"line_number":1016,"context_line":"                cell_mapping\u003dobjects.CellMapping.get_by_uuid("},{"line_number":1017,"context_line":"                    self.context, uuids.cell1))"},{"line_number":1018,"context_line":"            self.conductor_manager.unshelve_instance(self.context, instance)"},{"line_number":1019,"context_line":"            self.assertEqual(1, unshelve_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_2d5818f8","line":1016,"range":{"start_line":1016,"start_character":49,"end_line":1016,"end_character":60},"updated":"2017-07-27 03:02:06.000000000","message":"nit: this could just be a fake cell mapping, we don\u0027t really need to pull it from the db","commit_id":"476caa0884eadf7ad4e42c17fe953a6df84c2f7d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"            host\u003d\"dummy\", cell\u003dNone)"},{"line_number":1029,"context_line":"        fp.return_value \u003d fake_spec"},{"line_number":1030,"context_line":"        cell_mapping \u003d objects.CellMapping.get_by_uuid(self.context,"},{"line_number":1031,"context_line":"                                                         uuids.cell1)"},{"line_number":1032,"context_line":"        mock_im.return_value \u003d objects.InstanceMapping("},{"line_number":1033,"context_line":"            cell_mapping\u003dcell_mapping)"},{"line_number":1034,"context_line":"        instance \u003d self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_ad6be882","line":1031,"updated":"2017-07-27 03:02:06.000000000","message":"alignment","commit_id":"476caa0884eadf7ad4e42c17fe953a6df84c2f7d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d1183cde05005581734b3f32e85da5eaa023f43","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        system_metadata[\u0027shelved_host\u0027] \u003d \u0027fake-mini\u0027"},{"line_number":1066,"context_line":"        self.conductor_manager.unshelve_instance(self.context, instance)"},{"line_number":1067,"context_line":"        fp.assert_called_once_with(self.context, \u0027req_spec\u0027, mock.ANY)"},{"line_number":1068,"context_line":"        self.assertEqual(fake_spec.requested_destination.cell, cell_mapping)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"    def test_unshelve_instance_schedule_and_rebuild_novalid_host(self):"},{"line_number":1071,"context_line":"        instance \u003d self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_edfa10bb","line":1068,"updated":"2017-07-27 03:02:06.000000000","message":"nit: reverse the order","commit_id":"476caa0884eadf7ad4e42c17fe953a6df84c2f7d"}]}