)]}'
{"nova/tests/functional/notification_sample_tests/notification_sample_base.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"c5ef1b8c1066cbc35728695d582c302c9673e800","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        :returns: the migrations"},{"line_number":268,"context_line":"        \"\"\""},{"line_number":269,"context_line":"        retries \u003d 0"},{"line_number":270,"context_line":"        while retries \u003c max_retries:"},{"line_number":271,"context_line":"            retries +\u003d 1"},{"line_number":272,"context_line":"            migrations \u003d self.admin_api.get_active_migrations(server[\u0027id\u0027])"},{"line_number":273,"context_line":"            if (len(migrations) \u003e 0 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_28063b88","line":270,"updated":"2017-07-24 10:42:32.000000000","message":"should there be a brief sleep in this loop or is the call to get_active_migrations slow enough that this won\u0027t be a very tight loop?","commit_id":"8b321cf04f680966a7d846917478f01acab8d3cd"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"e09b01addb103f311821cb0d4abc7c6f36a52fb5","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        :returns: the migrations"},{"line_number":268,"context_line":"        \"\"\""},{"line_number":269,"context_line":"        retries \u003d 0"},{"line_number":270,"context_line":"        while retries \u003c max_retries:"},{"line_number":271,"context_line":"            retries +\u003d 1"},{"line_number":272,"context_line":"            migrations \u003d self.admin_api.get_active_migrations(server[\u0027id\u0027])"},{"line_number":273,"context_line":"            if (len(migrations) \u003e 0 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_482bbf93","line":270,"in_reply_to":"ff346bd7_28063b88","updated":"2017-07-24 10:54:57.000000000","message":"Hi Chris, I checked your questions in the past and I have so conclusion, that in every case good this solution. On average will be between 7 and 8 finished this method (with success). The sleeping unneccessary, faster without sleep. We can time save if do loop without sleep with retries limit.","commit_id":"8b321cf04f680966a7d846917478f01acab8d3cd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"52cae99ae7706e91d5c5aac54e62d8496c78948c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        :returns: the migrations"},{"line_number":268,"context_line":"        \"\"\""},{"line_number":269,"context_line":"        retries \u003d 0"},{"line_number":270,"context_line":"        while retries \u003c max_retries:"},{"line_number":271,"context_line":"            retries +\u003d 1"},{"line_number":272,"context_line":"            migrations \u003d self.admin_api.get_active_migrations(server[\u0027id\u0027])"},{"line_number":273,"context_line":"            if (len(migrations) \u003e 0 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_96b2c1e5","line":270,"in_reply_to":"ff346bd7_482bbf93","updated":"2017-07-25 10:04:07.000000000","message":"Yup, I think it\u0027s reasonable to not implement a timer and rather see how things work because a timer could be suboptimal.","commit_id":"8b321cf04f680966a7d846917478f01acab8d3cd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31f8f70d43f9bdd9689810f55b1407376c17ea93","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        retries \u003d 0"},{"line_number":270,"context_line":"        while retries \u003c max_retries:"},{"line_number":271,"context_line":"            retries +\u003d 1"},{"line_number":272,"context_line":"            migrations \u003d self.admin_api.get_active_migrations(server[\u0027id\u0027])"},{"line_number":273,"context_line":"            if (len(migrations) \u003e 0 and"},{"line_number":274,"context_line":"                        migrations[0][\u0027status\u0027] !\u003d \u0027preparing\u0027):"},{"line_number":275,"context_line":"                return migrations"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_468ecbd0","line":272,"range":{"start_line":272,"start_character":40,"end_line":272,"end_character":61},"updated":"2017-07-26 00:27:23.000000000","message":"This doesn\u0027t actually exist...at least not in this patch, and not in trunk master nova. Are you missing a dependent change in your series?","commit_id":"8b321cf04f680966a7d846917478f01acab8d3cd"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"5a9be031b3e54e9305842aaffe53dca1b9362c20","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        retries \u003d 0"},{"line_number":270,"context_line":"        while retries \u003c max_retries:"},{"line_number":271,"context_line":"            retries +\u003d 1"},{"line_number":272,"context_line":"            migrations \u003d self.admin_api.get_active_migrations(server[\u0027id\u0027])"},{"line_number":273,"context_line":"            if (len(migrations) \u003e 0 and"},{"line_number":274,"context_line":"                        migrations[0][\u0027status\u0027] !\u003d \u0027preparing\u0027):"},{"line_number":275,"context_line":"                return migrations"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_0ec8d11f","line":272,"range":{"start_line":272,"start_character":40,"end_line":272,"end_character":61},"in_reply_to":"ff346bd7_468ecbd0","updated":"2017-07-26 08:28:28.000000000","message":"Uhh, thanks for pointing this out. They were represented in the subsequent patches, so that\u0027s why there were no errors. But I fixed it in ps2","commit_id":"8b321cf04f680966a7d846917478f01acab8d3cd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f84266ce6d592543673c18d0c9d257ab4100b14f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                if server[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":212,"context_line":"                    self.fail(\u0027Server went to error state instead of\u0027"},{"line_number":213,"context_line":"                              \u0027disappearing.\u0027)"},{"line_number":214,"context_line":"                time.sleep(0.5)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"            self.fail(\u0027Server failed to delete.\u0027)"},{"line_number":217,"context_line":"        except api_client.OpenStackApiNotFoundException:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_b63fc2b2","line":214,"updated":"2017-07-26 21:27:26.000000000","message":"This wait function is using a sleep of 0.5 seconds.","commit_id":"47469ac8683e914d4dcc26ae38bcea1e4a22587a"}]}