)]}'
{"etc/nova/rootwrap.d/compute.filters":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8775b7c73f85ed2662cc41614b9ba267ea3669e1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# nova/virt/disk/vfs/localfs.py: \u0027chown\u0027"},{"line_number":49,"context_line":"# nova/virt/libvirt/utils.py: def chown(): execute(\u0027chown\u0027, owner, path,"},{"line_number":50,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, os.getuid( console_log"},{"line_number":51,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, os.getuid( console_log"},{"line_number":52,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, \u0027root\u0027, basepath(\u0027disk\u0027)"},{"line_number":53,"context_line":"chown: CommandFilter, chown, root"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff346bd7_bf4c3542","line":51,"range":{"start_line":50,"start_character":1,"end_line":51,"end_character":62},"updated":"2017-07-26 23:32:24.000000000","message":"Not caused by your change, but are these supposed to be duplicated?","commit_id":"0edd176dffe1aeb1861d651257899938868bd969"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1a71883a030900b2b864130f37a2acbb38571d43","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# nova/virt/disk/vfs/localfs.py: \u0027chown\u0027"},{"line_number":49,"context_line":"# nova/virt/libvirt/utils.py: def chown(): execute(\u0027chown\u0027, owner, path,"},{"line_number":50,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, os.getuid( console_log"},{"line_number":51,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, os.getuid( console_log"},{"line_number":52,"context_line":"# nova/virt/libvirt/driver.py: \u0027chown\u0027, \u0027root\u0027, basepath(\u0027disk\u0027)"},{"line_number":53,"context_line":"chown: CommandFilter, chown, root"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff346bd7_ff32bd5d","line":51,"range":{"start_line":50,"start_character":1,"end_line":51,"end_character":62},"in_reply_to":"ff346bd7_bf4c3542","updated":"2017-07-26 23:56:55.000000000","message":"They were before chown() was factored out into utils.py so rather than update those 2 they should be removed.\n\nNot entirely sure how I failed to notice that.","commit_id":"0edd176dffe1aeb1861d651257899938868bd969"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6623288548b1e0199fbd20688fc44789d4695991","unresolved":false,"context_lines":[{"line_number":236,"context_line":"# nova/virt/libvirt/utils.py: \u0027shred\u0027, \u0027-n3\u0027, \u0027-s%d\u0027 % volume_size, path"},{"line_number":237,"context_line":"shred: CommandFilter, shred, root"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# nova/virt/libvirt/volume/volume.py: \u0027cp\u0027, \u0027/dev/stdin\u0027, delete_control.."},{"line_number":240,"context_line":"cp: CommandFilter, cp, root"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"# nova/virt/xenapi/vm_utils.py:"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff346bd7_5f72e94a","line":239,"range":{"start_line":239,"start_character":38,"end_line":239,"end_character":74},"updated":"2017-07-26 23:44:53.000000000","message":"I don\u0027t find this command being run anywhere either, so I\u0027m guessing it can be removed.","commit_id":"0edd176dffe1aeb1861d651257899938868bd969"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"6aa815f301a1ccc807e318c9223988495c459dd2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"privsep-rootwrap: RegExpFilter, privsep-helper, root, privsep-helper, --config-file, /etc/(?!\\.\\.).*, --privsep_context, os_brick.privileged.default, --privsep_sock_path, /tmp/.*"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# nova/storage/linuxscsi.py: sg_scan device"},{"line_number":225,"context_line":"sg_scan: CommandFilter, sg_scan, root"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"# nova/virt/libvirt/storage/dmcrypt.py:"},{"line_number":228,"context_line":"cryptsetup: CommandFilter, cryptsetup, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"df3967d1_b6e96d81","side":"PARENT","line":225,"updated":"2017-07-31 12:18:11.000000000","message":"do we need a reno in dropping rules?","commit_id":"f41a91b1e8fbcade81b44bb075c3957fc5999ee8"}]}
