)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4552edb75c802330979e33e94242eae3a5c6280e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucian Petrut \u003clpetrut@cloudbasesolutions.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-30 14:50:26 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hyper-V: Perform proper cleanp after cold migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, vif ports and volume connections are not cleaned up"},{"line_number":10,"context_line":"on the source node after a cold migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_43252808","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":30},"updated":"2017-08-30 17:49:59.000000000","message":"cleanup","commit_id":"0ff30669b3af0ffa43333c29566feacf7ec05349"}],"nova/virt/hyperv/migrationops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f6246f578fd3af7940ac7555746176f6cd277f68","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def migrate_disk_and_power_off(self, context, instance, dest,"},{"line_number":117,"context_line":"                                   flavor, network_info,"},{"line_number":118,"context_line":"                                   block_device_info\u003dNone, timeout\u003d0,"},{"line_number":119,"context_line":"                                   retry_interval\u003d0):"},{"line_number":120,"context_line":"        LOG.debug(\"migrate_disk_and_power_off called\", instance\u003dinstance)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d376a370","line":118,"range":{"start_line":118,"start_character":35,"end_line":118,"end_character":52},"updated":"2017-08-29 22:33:27.000000000","message":"Why isn\u0027t this also passed through to disconnect volumes from the source host?","commit_id":"14d7c370197ac0e531a4ff2a71b6ed8312270202"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"44cb1c7ccebca3636fec728067b87c185fbae4f3","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def migrate_disk_and_power_off(self, context, instance, dest,"},{"line_number":117,"context_line":"                                   flavor, network_info,"},{"line_number":118,"context_line":"                                   block_device_info\u003dNone, timeout\u003d0,"},{"line_number":119,"context_line":"                                   retry_interval\u003d0):"},{"line_number":120,"context_line":"        LOG.debug(\"migrate_disk_and_power_off called\", instance\u003dinstance)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_eb0cf894","line":118,"range":{"start_line":118,"start_character":35,"end_line":118,"end_character":52},"in_reply_to":"7f287b81_d376a370","updated":"2017-08-30 11:29:05.000000000","message":"Thanks a lot for bringing this up. It\u0027s a bug, volumes will not be disconnected unless we pass it.\n\nMost probably we\u0027ve relied on volumes being disconnected in some other place (maybe some old code path that\u0027s not here anymore).\n\nI guess it\u0027s best if I\u0027ll just update the patch/bug report to include this as well.","commit_id":"14d7c370197ac0e531a4ff2a71b6ed8312270202"}]}