)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b87e5efd6fa6571321a664caed0dcefad200d4cf","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"            if \u0027id\u0027 in alloc:"},{"line_number":1813,"context_line":"                raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":1814,"context_line":"                                                  reason\u003d\u0027already created\u0027)"},{"line_number":1815,"context_line":"            _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"        # Before writing any allocation records, we check that the submitted"},{"line_number":1818,"context_line":"        # allocations do not cause any inventory capacity to be exceeded for"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_367be0be","side":"PARENT","line":1815,"updated":"2017-07-26 15:24:39.000000000","message":"Why is this removed?","commit_id":"ac442b4f178273e4a6dedea8a5a1fe649161665e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a6cdbd4f186701286316ba6f513df9850c143726","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"            if \u0027id\u0027 in alloc:"},{"line_number":1813,"context_line":"                raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":1814,"context_line":"                                                  reason\u003d\u0027already created\u0027)"},{"line_number":1815,"context_line":"            _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"        # Before writing any allocation records, we check that the submitted"},{"line_number":1818,"context_line":"        # allocations do not cause any inventory capacity to be exceeded for"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_562c24ab","side":"PARENT","line":1815,"in_reply_to":"ff346bd7_367be0be","updated":"2017-07-26 15:26:24.000000000","message":"Jesus, you\u0027re quick. I meant to add a comment in here that I removed the above useless line of code instead of putting it in a separate patch. The code above does nothing at all.","commit_id":"ac442b4f178273e4a6dedea8a5a1fe649161665e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5003cb5840e8f7629f92bc362f555f1b2bbb4892","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"            if \u0027id\u0027 in alloc:"},{"line_number":1813,"context_line":"                raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":1814,"context_line":"                                                  reason\u003d\u0027already created\u0027)"},{"line_number":1815,"context_line":"            _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"        # Before writing any allocation records, we check that the submitted"},{"line_number":1818,"context_line":"        # allocations do not cause any inventory capacity to be exceeded for"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_31e1aa2b","side":"PARENT","line":1815,"in_reply_to":"ff346bd7_562c24ab","updated":"2017-07-26 15:33:52.000000000","message":"Heh good point, it gets a resource class id from a string and sends it nowhere.","commit_id":"ac442b4f178273e4a6dedea8a5a1fe649161665e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b87e5efd6fa6571321a664caed0dcefad200d4cf","unresolved":false,"context_lines":[{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"        :raises `exception.InvalidAllocationCapacityExceeded` if any inventory"},{"line_number":1808,"context_line":"                would be exhausted by the allocation. Raises an"},{"line_number":1809,"context_line":"                InvalidAllocationConstraintsViolated exception if any of the"},{"line_number":1810,"context_line":"                `step_size`, `min_unit` or `max_unit` constraints in an"},{"line_number":1811,"context_line":"                inventory will be violated by any one of the allocations."},{"line_number":1812,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_968a8cbc","line":1809,"range":{"start_line":1809,"start_character":16,"end_line":1809,"end_character":52},"updated":"2017-07-26 15:24:39.000000000","message":"This or InvalidAllocationCapacityExceeded? Or both? If both, we should have separate :raises: entries for them.","commit_id":"76d0c64ec076722e678a1a7e3ea79f2c4930bcf0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a6cdbd4f186701286316ba6f513df9850c143726","unresolved":false,"context_lines":[{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"        :raises `exception.InvalidAllocationCapacityExceeded` if any inventory"},{"line_number":1808,"context_line":"                would be exhausted by the allocation. Raises an"},{"line_number":1809,"context_line":"                InvalidAllocationConstraintsViolated exception if any of the"},{"line_number":1810,"context_line":"                `step_size`, `min_unit` or `max_unit` constraints in an"},{"line_number":1811,"context_line":"                inventory will be violated by any one of the allocations."},{"line_number":1812,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_d106de1c","line":1809,"range":{"start_line":1809,"start_character":16,"end_line":1809,"end_character":52},"in_reply_to":"ff346bd7_968a8cbc","updated":"2017-07-26 15:26:24.000000000","message":"I just cleaned up the docstring to specify that we\u0027re already raising that exception from the _check_capacity_exceeded() call. Was just trying to make the method docstring accurate.","commit_id":"76d0c64ec076722e678a1a7e3ea79f2c4930bcf0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5003cb5840e8f7629f92bc362f555f1b2bbb4892","unresolved":false,"context_lines":[{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"        :raises `exception.InvalidAllocationCapacityExceeded` if any inventory"},{"line_number":1808,"context_line":"                would be exhausted by the allocation. Raises an"},{"line_number":1809,"context_line":"                InvalidAllocationConstraintsViolated exception if any of the"},{"line_number":1810,"context_line":"                `step_size`, `min_unit` or `max_unit` constraints in an"},{"line_number":1811,"context_line":"                inventory will be violated by any one of the allocations."},{"line_number":1812,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_31688a85","line":1809,"range":{"start_line":1809,"start_character":16,"end_line":1809,"end_character":52},"in_reply_to":"ff346bd7_d106de1c","updated":"2017-07-26 15:33:52.000000000","message":"Right, it\u0027s just this should be more like:\n\n:raises `exception.InvalidAllocationCapacityExceeded` if any inventory would be exhausted by the allocation.\n:raises `exception.InvalidAllocationConstraintsViolated` if any of the `step_size`, `min_unit` or `max_unit` constraints in an inventory will be violated by any one of the allocations.\n\nYeah?","commit_id":"76d0c64ec076722e678a1a7e3ea79f2c4930bcf0"}]}