)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"faad29d8888bcbbe6b7d29121f662e21b9ea27d6","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        rp_to_rpt_join, t_tbl,"},{"line_number":739,"context_line":"        sa.and_("},{"line_number":740,"context_line":"            rpt_tbl.c.trait_id \u003d\u003d t_tbl.c.id,"},{"line_number":741,"context_line":"            t_tbl.c.name \u003d\u003d six.text_type(os_traits.MISC_SHARES_VIA_AGGREGATE),"},{"line_number":742,"context_line":"        ),"},{"line_number":743,"context_line":"    )"},{"line_number":744,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_22a6a8ac","line":741,"range":{"start_line":741,"start_character":28,"end_line":741,"end_character":41},"updated":"2017-07-28 14:02:54.000000000","message":"Someone in a year from now will probably wonder why this is here and push a change to remove it since they\u0027ll think it\u0027s redundant. Maybe a comment here is necessary?","commit_id":"4fe45c93e1230f73383a93840f0faa5c7084859e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f7d83b5c7daf380fb6463c33abbe3c8bac453fc","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        rp_to_rpt_join, t_tbl,"},{"line_number":739,"context_line":"        sa.and_("},{"line_number":740,"context_line":"            rpt_tbl.c.trait_id \u003d\u003d t_tbl.c.id,"},{"line_number":741,"context_line":"            t_tbl.c.name \u003d\u003d six.text_type(os_traits.MISC_SHARES_VIA_AGGREGATE),"},{"line_number":742,"context_line":"        ),"},{"line_number":743,"context_line":"    )"},{"line_number":744,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_82fc3470","line":741,"range":{"start_line":741,"start_character":28,"end_line":741,"end_character":41},"in_reply_to":"ff346bd7_22a6a8ac","updated":"2017-07-28 14:16:36.000000000","message":"Well, SQLA provides some unicode management if you use a flag when defining the engine [1], but to me it\u0027s pretty clear that *by default* SQLA expects unicode so should we really comment that ?\n\n[1] http://docs.sqlalchemy.org/en/latest/core/engines.html#sqlalchemy.create_engine.params.convert_unicode","commit_id":"4fe45c93e1230f73383a93840f0faa5c7084859e"}]}