)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cc005cdeb141ec791749dbdff43a51a40b987b6a","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        try:"},{"line_number":433,"context_line":"            _try_detach_device(conf, persistent, live)"},{"line_number":434,"context_line":"        except exception.DeviceNotFound:"},{"line_number":435,"context_line":"            # NOTE(melwitt): If the persistent domain device wasn\u0027t found, we"},{"line_number":436,"context_line":"            # should still try to detach the live device, so continue."},{"line_number":437,"context_line":"            if persistent:"},{"line_number":438,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_993788b1","line":435,"range":{"start_line":435,"start_character":61,"end_line":435,"end_character":67},"updated":"2017-08-01 19:23:04.000000000","message":"was?\n\nIf persistent is not Falsey (False boolean or 1 integer or something), then we found the persistent domain device didn\u0027t we? Or is this something about how _try_detach_device behaves?","commit_id":"7e4cd421e0bee9185b13d7afaa79a560ead1dc2a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bc0d9cc24c17993345cd5ccf4bd77b58b09a5921","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        try:"},{"line_number":433,"context_line":"            _try_detach_device(conf, persistent, live)"},{"line_number":434,"context_line":"        except exception.DeviceNotFound:"},{"line_number":435,"context_line":"            # NOTE(melwitt): If the persistent domain device wasn\u0027t found, we"},{"line_number":436,"context_line":"            # should still try to detach the live device, so continue."},{"line_number":437,"context_line":"            if persistent:"},{"line_number":438,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b9c00c2c","line":435,"range":{"start_line":435,"start_character":61,"end_line":435,"end_character":67},"in_reply_to":"df3967d1_993788b1","updated":"2017-08-01 19:36:36.000000000","message":"If we passed persistent\u003dTrue to _try_detach_device and we caught DeviceNotFound, that means we didn\u0027t find the device in the persistent config. So if we also have live\u003dTrue then we need to try to detach from the live config too. So I should have \"if persistent and live:\" in the conditional.","commit_id":"7e4cd421e0bee9185b13d7afaa79a560ead1dc2a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2a7448e9c61baffa502c29f83dca0e9fb35bd83","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        try:"},{"line_number":433,"context_line":"            _try_detach_device(conf, persistent, live)"},{"line_number":434,"context_line":"        except exception.DeviceNotFound:"},{"line_number":435,"context_line":"            # NOTE(melwitt): If the persistent domain device wasn\u0027t found, we"},{"line_number":436,"context_line":"            # should still try to detach the live device, so continue."},{"line_number":437,"context_line":"            if persistent:"},{"line_number":438,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_99dd4816","line":435,"range":{"start_line":435,"start_character":61,"end_line":435,"end_character":67},"in_reply_to":"df3967d1_993788b1","updated":"2017-08-01 19:34:20.000000000","message":"Nevermind, the comment make sense to me now. But sounds like you need to also check the live flag here before continuing.","commit_id":"7e4cd421e0bee9185b13d7afaa79a560ead1dc2a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa70572e4b39f4520a7248176cdf2542345da8e0","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        try:"},{"line_number":433,"context_line":"            _try_detach_device(conf, persistent, live)"},{"line_number":434,"context_line":"        except exception.DeviceNotFound:"},{"line_number":435,"context_line":"            # NOTE(melwitt): There are effectively two configs for an instance."},{"line_number":436,"context_line":"            # The persistent config (affects instance upon next boot) and the"},{"line_number":437,"context_line":"            # live config (affects running instance). When we detach a device,"},{"line_number":438,"context_line":"            # we need to detach it from both configs if the instance has a"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_c5fd1f3b","line":435,"updated":"2017-08-01 22:20:24.000000000","message":"Maybe this would make more sense within the \"if persistent and live:\" block, but I get it now.","commit_id":"d39934ad6afb7e2729bb45235f363ada86012d15"}]}