)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aa7580b3af4f9703173c4217e04055218332c906","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"        image_id \u003d None"},{"line_number":2351,"context_line":"        bdms \u003d self.get_instance_bdms(context, instance)"},{"line_number":2352,"context_line":"        if not self.is_volume_backed_instance(context, instance, bdms):"},{"line_number":2353,"context_line":"            name \u003d \u0027%s-shelved\u0027 % instance[\u0027display_name\u0027]"},{"line_number":2354,"context_line":"            image_meta \u003d self._create_image(context, instance, name,"},{"line_number":2355,"context_line":"                    \u0027snapshot\u0027)"},{"line_number":2356,"context_line":"            image_id \u003d image_meta[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FHAE%3D","line":2353,"updated":"2013-10-04 08:16:49.000000000","message":"consider using the uuid here. that is unique\n\nname \u003d \u0027%s-shelved\u0027 % instance[\u0027uuid\u0027]","commit_id":"eb07027f74182494fbcf3b5d694cdc10357037b7"}],"nova/tests/compute/test_shelve.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"bf160ec678df7bb03f5c2cd11563621cd174b9b2","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        def fake_create(self2, ctxt, metadata):"},{"line_number":326,"context_line":"            if metadata[\u0027name\u0027].endswith(\u0027-shelved\u0027):"},{"line_number":327,"context_line":"                self.assertEqual(metadata[\u0027name\u0027], \u0027vm01-shelved\u0027)"},{"line_number":328,"context_line":"                metadata[\u0027id\u0027] \u003d \u00278b24ed3f-ee57-43bc-bc2e-fb2e9482bc42\u0027"},{"line_number":329,"context_line":"                return metadata"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FJhA%3D","line":327,"updated":"2013-10-03 14:15:01.000000000","message":"I don\u0027t think this test is quite right, because we only verify that the name is correct if we get a name that ends with \u0027-shelved\u0027.  I\u0027d like the test to fail if that never happens.","commit_id":"512c6722336a6ebb9db3dbab0595f4935e18febc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"388e4a81dbf1f4558fff3bae10337860690df4c0","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        def fake_create(self2, ctxt, metadata):"},{"line_number":326,"context_line":"            if metadata[\u0027name\u0027].endswith(\u0027-shelved\u0027):"},{"line_number":327,"context_line":"                self.assertEqual(metadata[\u0027name\u0027], \u0027vm01-shelved\u0027)"},{"line_number":328,"context_line":"                metadata[\u0027id\u0027] \u003d \u00278b24ed3f-ee57-43bc-bc2e-fb2e9482bc42\u0027"},{"line_number":329,"context_line":"                return metadata"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FHKY%3D","line":327,"in_reply_to":"AAAAS3%2F%2FJhA%3D","updated":"2013-10-04 06:30:02.000000000","message":"Thanks, David.\n\nYou\u0027re right. I will change here for verifying right snapshot name any time.","commit_id":"512c6722336a6ebb9db3dbab0595f4935e18febc"}]}