)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ad4a6781be17f2183b88dd44c2e0d8182b33e9da","unresolved":false,"context_lines":[{"line_number":16,"context_line":"for a consumer a proper overwrite operation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I0835e5b4f22277465012aab9a5bf474608cb533b"},{"line_number":19,"context_line":"Fixes-bug: #1707669"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df3967d1_95384d3d","line":19,"range":{"start_line":19,"start_character":1,"end_line":19,"end_character":19},"updated":"2017-08-02 16:09:39.000000000","message":"nit: Closes-Bug\n\nnot sure the Gerrit hook will work correctly.","commit_id":"afab0ca0c8f4c68b8d6d8646f408e9522596870e"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"78d1985ad3f0f0b712abf76afff988f957831877","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        with conn.begin():"},{"line_number":1827,"context_line":"            # First delete any existing allocations for that rp/consumer combo."},{"line_number":1828,"context_line":"            consumer_id \u003d allocs[0].consumer_id"},{"line_number":1829,"context_line":"            _delete_current_allocs(conn, consumer_id)"},{"line_number":1830,"context_line":"            before_gens \u003d _check_capacity_exceeded(conn, allocs)"},{"line_number":1831,"context_line":"            self._ensure_consumer_project_user(conn, consumer_id)"},{"line_number":1832,"context_line":"            # Now add the allocations that were passed in."}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_1b99796d","line":1829,"updated":"2017-07-31 16:38:22.000000000","message":"this looks like it makes the requirement/assumption that an AllocationList  will always be from the same consumer. The HTTP API enforces this, but the object API does not. Do we care?","commit_id":"3ff2f18979398ae810b3f6d9acadabfe37578f45"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec2aa3d73ec75d3dd29f92bd523987d40ecbda7c","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        with conn.begin():"},{"line_number":1827,"context_line":"            # First delete any existing allocations for that rp/consumer combo."},{"line_number":1828,"context_line":"            consumer_id \u003d allocs[0].consumer_id"},{"line_number":1829,"context_line":"            _delete_current_allocs(conn, consumer_id)"},{"line_number":1830,"context_line":"            before_gens \u003d _check_capacity_exceeded(conn, allocs)"},{"line_number":1831,"context_line":"            self._ensure_consumer_project_user(conn, consumer_id)"},{"line_number":1832,"context_line":"            # Now add the allocations that were passed in."}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_7b1e45bb","line":1829,"in_reply_to":"df3967d1_1b99796d","updated":"2017-07-31 16:44:27.000000000","message":"Perhaps we could/should since we make assumptions like this in the object layer. I\u0027m not sure what we\u0027d use to validate that on insert to the list though. Probably safe to do this for now and have someone follow up with an object-layer-assertion later on.","commit_id":"3ff2f18979398ae810b3f6d9acadabfe37578f45"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7d1ff9c70e4d5c91a3f0054ea345e18a72fc8282","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        # objects are used at the end of the allocation transaction as a guard"},{"line_number":1827,"context_line":"        # against concurrent updates."},{"line_number":1828,"context_line":"        with conn.begin():"},{"line_number":1829,"context_line":"            # First delete any existing allocations for that rp/consumer combo."},{"line_number":1830,"context_line":"            consumer_id \u003d allocs[0].consumer_id"},{"line_number":1831,"context_line":"            _delete_current_allocs(conn, consumer_id)"},{"line_number":1832,"context_line":"            before_gens \u003d _check_capacity_exceeded(conn, allocs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_9503ad73","line":1829,"range":{"start_line":1829,"start_character":60,"end_line":1829,"end_character":79},"updated":"2017-08-02 16:08:53.000000000","message":"rp/consumer combo meaning all allocs share the same consumer UUID (so we can take only the first one) but it\u0027s a comment nit.","commit_id":"afab0ca0c8f4c68b8d6d8646f408e9522596870e"}]}