)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2f0aafec5df154b4e637750f38b697ad4cf0a7b4","unresolved":false,"context_lines":[{"line_number":6381,"context_line":"        config \u003d drvr._get_volume_config(connection_info, disk_info)"},{"line_number":6382,"context_line":"        get_config.assert_called_once_with(connection_info, disk_info)"},{"line_number":6383,"context_line":"        _set_cache_mode.assert_called_once_with(config)"},{"line_number":6384,"context_line":"        self.assertEqual(config_guest_disk.to_xml(), config.to_xml())"},{"line_number":6385,"context_line":""},{"line_number":6386,"context_line":"    def test_attach_invalid_volume_type(self):"},{"line_number":6387,"context_line":"        self.create_fake_libvirt_mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f8c5853d","line":6384,"updated":"2017-08-01 08:12:02.000000000","message":"We still don\u0027t test anything meaningful here IMO. The method under test \"_get_volume_config\" consists only of two methods, which are both mocked here:\n\n* libvirt driver\u0027s `_set_cache_mode`\n* volume driver\u0027s `get_config`\n\nThe `_set_cache_mode` is already tested with https://github.com/openstack/nova/blob/3fe1ec95f386176924b34997b3fb76b7714e02af/nova/tests/unit/virt/libvirt/test_driver.py#L13805-L13830\n\nThe volume driver\u0027s method `get_config` is already tested with https://github.com/openstack/nova/blob/03cb9c04f071a19fe4fd8f106cfd7e65e2045639/nova/tests/unit/virt/libvirt/volume/test_volume.py#L132-L162 (and others)\n\nI\u0027m a bit on the fence about how to proceed here. I\u0027m inclined to say we should delete that unit test completely, as it doesn\u0027t reduce the risk nor documents the expected behavior, but increases maintenance costs.","commit_id":"3fe1ec95f386176924b34997b3fb76b7714e02af"}]}