)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"70f0a7da999df0017691c7114e83506dd1e69a63","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_52c6ad9c","line":3135,"updated":"2017-08-01 09:38:58.000000000","message":"The only problem I see with that is that it\u0027s a virt driver problem. AFAIK, libvirt and VMware drivers don\u0027t support shrinking, but looks like Xen does that and Ironic too.\n\nI wonder if we shouldn\u0027t rather just erroring the instance before resizing.","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46d7d7582abb12caf4b08e8ebab732a44948dc1d","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_3511645e","line":3135,"in_reply_to":"3f79a3b5_bae6ec13","updated":"2019-05-13 15:16:27.000000000","message":"Ironic doesn\u0027t support resize / migrate so I\u0027m not sure why that\u0027s mentioned here. And where in the xenapi driver code does it allow resizing the root disk down?","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c89bc8d04d3525944d8f3378f64c62a72ba3618f","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_bae6ec13","line":3135,"in_reply_to":"5f2577a7_8189aa27","updated":"2018-12-17 07:52:54.000000000","message":"Yes we can catch the exception and re-raise should we update the support matrix about the ability to re-size down?","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"02f01af1819d13369531d48bf176e6855d4b509a","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_8189aa27","line":3135,"in_reply_to":"df3967d1_19b94f79","updated":"2017-09-08 17:31:49.000000000","message":"I agree with Alex here we don\u0027t need a microversion bump only for different behaviors between drivers.\n\nBut I can see the first Sylvain\u0027s point, and this additional check could break Xen and Ironic as he said. It would be enough to check this kind of capacity on drivers side and catch the exception on this API side.","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9553c6d63c9762186eab989d6111727340653db8","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_4b4b942a","line":3135,"in_reply_to":"df3967d1_329e8954","updated":"2017-08-01 10:45:52.000000000","message":"So, let me clarify :\n- either we consider Nova won\u0027t support shrinking resizes and in that case, it would require a new API microversion because we accepted that previously.\n- or we say it\u0027s a per-driver capability and we need to find a solution that would allow shrinking resizes for drivers than can support that.\n\nThe latter means either virt drivers expose that capability to the API (that\u0027s something we thought of already but we don\u0027t have yet a clear interface for that), or we just error out operations where the virt driver doesn\u0027t support that.","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"100aff55a6ad38071c9b51e90c5fef9c6ecf6e48","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_19b94f79","line":3135,"in_reply_to":"df3967d1_4b4b942a","updated":"2017-08-02 02:21:38.000000000","message":"@Sylvain, if we are in the case that no virt driver works with shrinking resize, then we needn\u0027t API microversion. We can consider that is an API bug since the API execution failed silently","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"},{"author":{"_account_id":25632,"name":"Zhaokun Fu","email":"fuzk@inspur.com","username":"fuzk"},"change_message_id":"d0374b5e8970d5cae400c1524a07e6ae5c3546f3","unresolved":false,"context_lines":[{"line_number":3132,"context_line":"            if (new_instance_root_gb \u003c current_instance_root_gb and"},{"line_number":3133,"context_line":"                not compute_utils.is_volume_backed_instance(context,"},{"line_number":3134,"context_line":"                    instance)):"},{"line_number":3135,"context_line":"                reason \u003d _(\u0027Resize to smaller disk flavor is not allowed.\u0027)"},{"line_number":3136,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":3137,"context_line":""},{"line_number":3138,"context_line":"        if not new_instance_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_329e8954","line":3135,"in_reply_to":"df3967d1_52c6ad9c","updated":"2017-08-01 09:50:10.000000000","message":"Disk shrinking may lose data.\nSo, how about error shrinking operation for libvirt and VMware?","commit_id":"c46aca8164d95825175db76395ed1ad7ef6a5a19"}]}