)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"db1190a0dc0ece1acffa770f16079991dabbd203","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move common definition into common layer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"move common definition into common layer, so follow up patches"},{"line_number":10,"context_line":"can utilize the same defintion"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I17c2937e6b8ac3d09fabe273c50c81dd9b0babb6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_5e9ed054","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2017-08-18 17:10:07.000000000","message":"Ah, I could not understand the purpose, but I got it now according to you specified patch.\nCould you change the commit message like\n\n We have a plan to use the moved definitions on the other schemas\n like I64ad387ec7b532e9dbc791f683a005587825ff61\n So this patch moves these definitions as common ones.\n\nor something.","commit_id":"ce357475acd0500a853ea902fdad6e5f969d4799"}],"nova/api/openstack/common.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"597f86ecb4be1f2922492d581f6ea6eaffab63a3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    },"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# NOTE: We don\u0027t check actual values of queries on params"},{"line_number":114,"context_line":"# which are defined as the following common_param."},{"line_number":115,"context_line":"common_param \u003d multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":116,"context_line":"common_regex_param \u003d multi_params({\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027regex\u0027})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def status_from_state(vm_state, task_state\u003d\u0027default\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_432822e1","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":72},"updated":"2017-08-01 08:46:57.000000000","message":"if you want to add those in common place then parameter_types.py is right place for schema common things.","commit_id":"f943ea2f97116a47d869bbb0a19a9a22c6b78b8d"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe6e0eaba16e4c5ce7a16d8bccea8b00590dad4a","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":270,"context_line":"}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"common_param \u003d parameter_types.common_query_param"},{"line_number":273,"context_line":"common_regex_param \u003d parameter_types.common_query_regex_param"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"JOINED_TABLE_QUERY_PARAMS_SERVERS \u003d {"},{"line_number":276,"context_line":"    \u0027block_device_mapping\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_7eefe11d","line":273,"range":{"start_line":272,"start_character":0,"end_line":273,"end_character":61},"updated":"2017-08-14 11:04:30.000000000","message":"i think we do not need these alias now, i prefer to use those directly as parameter_types.common_query_param\n\nmore and more aliases make schema less readable.","commit_id":"d86c9cd72de62029ae4be67c52fbdde2b39e685f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ccaa3e90d321253cb98054a31453c2cbff92da5c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":270,"context_line":"}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"common_param \u003d parameter_types.common_query_param"},{"line_number":273,"context_line":"common_regex_param \u003d parameter_types.common_query_regex_param"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"JOINED_TABLE_QUERY_PARAMS_SERVERS \u003d {"},{"line_number":276,"context_line":"    \u0027block_device_mapping\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_abce0957","line":273,"range":{"start_line":272,"start_character":0,"end_line":273,"end_character":61},"in_reply_to":"9f436f4f_6ff5d6ec","updated":"2017-08-15 13:42:01.000000000","message":"yes but it will be in same line only. having direct parameter_types.common_query_param makes schema easy to read","commit_id":"d86c9cd72de62029ae4be67c52fbdde2b39e685f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0e87b68621fc4756b10d77d4f6b396eaafd8c0f9","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":270,"context_line":"}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"common_param \u003d parameter_types.common_query_param"},{"line_number":273,"context_line":"common_regex_param \u003d parameter_types.common_query_regex_param"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"JOINED_TABLE_QUERY_PARAMS_SERVERS \u003d {"},{"line_number":276,"context_line":"    \u0027block_device_mapping\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_6ff5d6ec","line":273,"range":{"start_line":272,"start_character":0,"end_line":273,"end_character":61},"in_reply_to":"9f436f4f_7eefe11d","updated":"2017-08-15 07:29:41.000000000","message":"yes, but if you take a look at following \na lot of common_param are used if we replace it with \nparameter_types.common_query_param, that means code will be \nexpanded ...so I want alias to make the shorter","commit_id":"d86c9cd72de62029ae4be67c52fbdde2b39e685f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f6329b440a1f9fd681743b11ba4ccb55e5680829","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":270,"context_line":"}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"common_param \u003d parameter_types.common_query_param"},{"line_number":273,"context_line":"common_regex_param \u003d parameter_types.common_query_regex_param"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"JOINED_TABLE_QUERY_PARAMS_SERVERS \u003d {"},{"line_number":276,"context_line":"    \u0027block_device_mapping\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_b11ac5c2","line":273,"range":{"start_line":272,"start_character":0,"end_line":273,"end_character":61},"in_reply_to":"9f436f4f_abce0957","updated":"2017-08-17 07:52:17.000000000","message":"ok, made changes accordingly, thanks","commit_id":"d86c9cd72de62029ae4be67c52fbdde2b39e685f"}],"nova/api/validation/parameter_types.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3b3873aa0e2fa53416a2e0edecb1e7832ade5625","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE: We don\u0027t check actual values of queries on params"},{"line_number":46,"context_line":"# which are defined as the following common_param."},{"line_number":47,"context_line":"common_param \u003d multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":48,"context_line":"common_regex_param \u003d multi_params({\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027regex\u0027})"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ValidationRegex(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_f36b11b4","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":72},"updated":"2017-08-14 07:00:17.000000000","message":"Maybe we should name them as \u0027common_query_param\u0027 and \u0027common_query_regex_param\u0027.\n\nAnd we should have comment explain when to use those two schemes. Basically, those are for backward-compatible existed query parameters, in the existed query parameter they are accept multiple parameters, that is why we use \u0027multi_params\u0027 micro func at here.","commit_id":"4d44357c89ab34ec3fc5988b1fcdedea8c68d312"}]}