)]}'
{"nova/api/openstack/compute/services.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"186a25c1f73d02b665428840d047f638196740e3","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            explanation \u003d _(\"Service id %s refers to multiple services.\") % id"},{"line_number":228,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexplanation)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.query_schema(services.index_query_schema_v20)"},{"line_number":231,"context_line":"    @extensions.expected_errors(())"},{"line_number":232,"context_line":"    def index(self, req):"},{"line_number":233,"context_line":"        \"\"\"Return a list of all running services. Filter by host \u0026 service"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf57530f_23943a8b","line":230,"range":{"start_line":230,"start_character":38,"end_line":230,"end_character":60},"updated":"2017-09-20 13:11:10.000000000","message":"This schema is used for base microversion also, why we need to name this as v20?","commit_id":"32d9a7919a2e3f65fb90bea8931ed8d391e241ce"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0840ac81938175ec619447878879dfdc1a881a26","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            explanation \u003d _(\"Service id %s refers to multiple services.\") % id"},{"line_number":228,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexplanation)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.query_schema(services.index_query_schema_v20)"},{"line_number":231,"context_line":"    @extensions.expected_errors(())"},{"line_number":232,"context_line":"    def index(self, req):"},{"line_number":233,"context_line":"        \"\"\"Return a list of all running services. Filter by host \u0026 service"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f5c4f37_f072767c","line":230,"range":{"start_line":230,"start_character":38,"end_line":230,"end_character":60},"in_reply_to":"bf57530f_23943a8b","updated":"2017-09-21 01:32:44.000000000","message":"ok, will fix it","commit_id":"32d9a7919a2e3f65fb90bea8931ed8d391e241ce"}],"nova/tests/unit/api/openstack/compute/test_services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"390222742872c0f5d0952254bd996111eddfce1a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self._process_output(response)"},{"line_number":310,"context_line":"        self.assertEqual(res_dict, response)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_services_list_with_host_service(self):"},{"line_number":313,"context_line":"        url \u003d \u0027/fake/services?host\u003dhost1\u0026binary\u003dnova-compute\u0027"},{"line_number":314,"context_line":"        self._test_services_list_with_param(url)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def test_services_list_with_host_service_dummy(self):"},{"line_number":317,"context_line":"        # This is for backward compatible, need remove it when"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_fb13490c","line":314,"range":{"start_line":312,"start_character":0,"end_line":314,"end_character":48},"updated":"2017-09-24 15:36:45.000000000","message":"can we add more tests. like in https://review.openstack.org/#/c/506950/\n\ntest_services_list_with_additional_filter\ntest_services_list_with_unknown_filter\ntest_services_list_with_multiple_host_filter\ntest_services_list_with_multiple_service_filter\ntest_agents_list_host_query_allow_int_as_string\ntest_agents_list_service_query_allow_int_as_string","commit_id":"58decc0d3453f897e7c000fd648f9a7bcbd1304e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"db4195b776c3afccd92dab90bfcdaa467821229f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self._process_output(response)"},{"line_number":310,"context_line":"        self.assertEqual(res_dict, response)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_services_list_with_host_service(self):"},{"line_number":313,"context_line":"        url \u003d \u0027/fake/services?host\u003dhost1\u0026binary\u003dnova-compute\u0027"},{"line_number":314,"context_line":"        self._test_services_list_with_param(url)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def test_services_list_with_host_service_dummy(self):"},{"line_number":317,"context_line":"        # This is for backward compatible, need remove it when"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_52ffda00","line":314,"range":{"start_line":312,"start_character":0,"end_line":314,"end_character":48},"in_reply_to":"7f515b1d_fb13490c","updated":"2017-09-25 03:04:28.000000000","message":"I think following test covers the \u0027additional_filter\u0027 cases\nso I won\u0027t add this one\nothers will be added in next PS, thanks","commit_id":"58decc0d3453f897e7c000fd648f9a7bcbd1304e"}]}