)]}'
{"nova/virt/ironic/client_wrapper.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2b98a0d153437a63374b7eba4fe2ca92dd88e515","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        kwargs[\u0027max_retries\u0027] \u003d max_retries"},{"line_number":89,"context_line":"        kwargs[\u0027retry_interval\u0027] \u003d retry_interval"},{"line_number":90,"context_line":"        kwargs[\u0027os_ironic_api_version\u0027] \u003d \u0027%d.%d\u0027 % IRONIC_API_VERSION"},{"line_number":91,"context_line":"        kwargs[\u0027os_endpoint_type\u0027] \u003d \u0027internal\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # NOTE(clenimar): by default, the endpoint is taken from the service"},{"line_number":94,"context_line":"        # catalog. Use `api_endpoint` if you want to override it."}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_725d31e8","line":91,"updated":"2017-08-01 09:41:58.000000000","message":"You\u0027ll need to update test_client_wrapper to add that new parameter in the expected args.","commit_id":"ac550ee9b06b2465e558bd74030a2c5c10cd8462"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"094ea963247010b91a1ead27e0b3e061a42052e6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        kwargs[\u0027max_retries\u0027] \u003d max_retries"},{"line_number":89,"context_line":"        kwargs[\u0027retry_interval\u0027] \u003d retry_interval"},{"line_number":90,"context_line":"        kwargs[\u0027os_ironic_api_version\u0027] \u003d \u0027%d.%d\u0027 % IRONIC_API_VERSION"},{"line_number":91,"context_line":"        kwargs[\u0027os_endpoint_type\u0027] \u003d \u0027internal\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # NOTE(clenimar): by default, the endpoint is taken from the service"},{"line_number":94,"context_line":"        # catalog. Use `api_endpoint` if you want to override it."}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_8f8f3622","line":91,"updated":"2017-08-01 20:47:15.000000000","message":"This should perhaps come from config, because otherwise you\u0027re forcing the internal type/interface. That may be a reasonable default, but as some catalogs may not have all types, it\u0027s presumably not ideal to force it.\n\nSee  Ic996e596f8473c0b8626e8d0e92e1bf58044b4f8 for some changes in placement that added the option to use other types.","commit_id":"d28bc4d55e12266efb93c7b069d897e0aba4e3f0"}]}
