)]}'
{"nova/tests/functional/notification_sample_tests/notification_sample_base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e63d0f10e416558926ef49bf943c8dfca9269af4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    if notification[\u0027event_type\u0027] \u003d\u003d event_type]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _wait_for_notification(self, event_type, timeout\u003d1.0):"},{"line_number":212,"context_line":"        received \u003d fake_notifier.wait_for_notification(event_type, timeout)"},{"line_number":213,"context_line":"        self.assertTrue("},{"line_number":214,"context_line":"            received,"},{"line_number":215,"context_line":"            \u0027notification %s hasn\\\u0027t been received\u0027 % event_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_07ed6124","line":212,"updated":"2017-08-02 07:52:45.000000000","message":"That could cause surprises in the future as the sample tests waiting and asserting versioned notifications. However after this change (if the even_type matches) the sample test could get a legacy notification.","commit_id":"1ae30fdd3773de5724d90a431b602b7b9edea45c"}],"nova/tests/unit/fake_notifier.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e63d0f10e416558926ef49bf943c8dfca9269af4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                       None)))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def wait_for_notification(event_type, timeout\u003d1.0):"},{"line_number":106,"context_line":"    # NOTE: The event stored in SUBSCRIBERS is not used for synchronizing"},{"line_number":107,"context_line":"    # the access to shared state as there is no parallel access to"},{"line_number":108,"context_line":"    # SUBSCRIBERS because the only parallelism is due to eventlet."}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_475009d5","line":105,"updated":"2017-08-02 07:52:45.000000000","message":"I would create two different wait_for function one for legacy notifications and one for the versioned ones. If I see correctly you only need this as the transformation of instance.resize_revert hasn\u0027t been merged yet[1]. \nI\u0027d like to keep the legacy and the versioned code path as separated as possible to make the future deprecation and removal of the legacy path easy.\n\n\n[1] https://review.openstack.org/#/c/396811","commit_id":"1ae30fdd3773de5724d90a431b602b7b9edea45c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"41b3291dec46257ffcd6eee2748d4ff3a1a5a648","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                       None)))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def wait_for_notification(event_type, timeout\u003d1.0):"},{"line_number":106,"context_line":"    # NOTE: The event stored in SUBSCRIBERS is not used for synchronizing"},{"line_number":107,"context_line":"    # the access to shared state as there is no parallel access to"},{"line_number":108,"context_line":"    # SUBSCRIBERS because the only parallelism is due to eventlet."}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_b8dd9471","line":105,"in_reply_to":"df3967d1_475009d5","updated":"2017-08-02 09:08:57.000000000","message":"Ok, this makes sense in that context. I\u0027ll split them.","commit_id":"1ae30fdd3773de5724d90a431b602b7b9edea45c"}]}