)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ba5fc58e9d38e236bbea6891e376f838db4f88","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"            # Ensure we subsequently get an exception"},{"line_number":1428,"context_line":"            fake_notifier.wait_for_notification(\u0027compute.exception\u0027)"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"            # Ensure we reverted the resize"},{"line_number":1431,"context_line":"            fake_notifier.wait_for_notification("},{"line_number":1432,"context_line":"                    \u0027compute.instance.resize.revert.end\u0027)"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        # Ensure resize_finish happened on host2"},{"line_number":1435,"context_line":"        resize_finish_notification \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_c712b909","line":1432,"range":{"start_line":1430,"start_character":0,"end_line":1432,"end_character":57},"updated":"2017-08-02 08:01:59.000000000","message":"Could you please add a TODO to replace this with waiting for the versioned notification after https://review.openstack.org/#/c/396811/ is merged?","commit_id":"fa333798f9bd7950f72b600463744c90f21789d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ba5fc58e9d38e236bbea6891e376f838db4f88","unresolved":false,"context_lines":[{"line_number":1432,"context_line":"                    \u0027compute.instance.resize.revert.end\u0027)"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        # Ensure resize_finish happened on host2"},{"line_number":1435,"context_line":"        resize_finish_notification \u003d None"},{"line_number":1436,"context_line":"        for n in fake_notifier.VERSIONED_NOTIFICATIONS:"},{"line_number":1437,"context_line":"            if n[\u0027event_type\u0027] \u003d\u003d \u0027instance.resize_finish.start\u0027:"},{"line_number":1438,"context_line":"                resize_finish_notification \u003d n"},{"line_number":1439,"context_line":"                break"},{"line_number":1440,"context_line":"        # This is a meta assertion, not related to the test"},{"line_number":1441,"context_line":"        assert resize_finish_notification is not None"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"        self.assertEqual(\u0027nova-compute:host2\u0027,"},{"line_number":1444,"context_line":"                         resize_finish_notification[\u0027publisher_id\u0027])"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        # Ensure finish_revert_resize happened on host1"},{"line_number":1447,"context_line":"        finish_revert_resize_notification \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_67ad4d87","line":1444,"range":{"start_line":1435,"start_character":1,"end_line":1444,"end_character":68},"updated":"2017-08-02 08:01:59.000000000","message":"nit: I think it can be written in a more python way:\n\nresize_finish_notifications \u003d [notification for notification in fake_notifier.VERSIONED_NOTIFICATIONS if notification[\u0027event_type\u0027] \u003d\u003d \u0027instance.resize_finish.start\u0027]\n\nself.assertEqual(1, len(resize_finish_notifications)\nself.assertEqual(\u0027nova-compute:host2\u0027, resize_finish_notifications[0][\u0027publisher_id\u0027])","commit_id":"fa333798f9bd7950f72b600463744c90f21789d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ba5fc58e9d38e236bbea6891e376f838db4f88","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"        self.assertEqual(\u0027nova-compute:host2\u0027,"},{"line_number":1444,"context_line":"                         resize_finish_notification[\u0027publisher_id\u0027])"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        # Ensure finish_revert_resize happened on host1"},{"line_number":1447,"context_line":"        finish_revert_resize_notification \u003d None"},{"line_number":1448,"context_line":"        for n in fake_notifier.NOTIFICATIONS:"},{"line_number":1449,"context_line":"            if n.event_type \u003d\u003d \u0027compute.instance.resize.revert.end\u0027:"},{"line_number":1450,"context_line":"                finish_revert_resize_notification \u003d n"},{"line_number":1451,"context_line":"                break"},{"line_number":1452,"context_line":"        # This is a meta assertion, not related to the test"},{"line_number":1453,"context_line":"        assert finish_revert_resize_notification is not None"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"        self.assertEqual(\u0027compute.host1\u0027,"},{"line_number":1456,"context_line":"                         finish_revert_resize_notification.publisher_id)"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        # Assert that the instance is ACTIVE on host1"},{"line_number":1459,"context_line":"        server \u003d self.api.get_server(created_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_87f4b1d0","line":1456,"range":{"start_line":1446,"start_character":0,"end_line":1456,"end_character":72},"updated":"2017-08-02 08:01:59.000000000","message":"Could you add a similar TODO I suggested at L1432?\nAlso this can also be transformed to list comprehension instead of for + break","commit_id":"fa333798f9bd7950f72b600463744c90f21789d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ba5fc58e9d38e236bbea6891e376f838db4f88","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"                         finish_revert_resize_notification.publisher_id)"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        # Assert that the instance is ACTIVE on host1"},{"line_number":1459,"context_line":"        server \u003d self.api.get_server(created_server[\u0027id\u0027])"},{"line_number":1460,"context_line":"        self.assertEqual(\u0027active\u0027, server[\u0027OS-EXT-STS:vm_state\u0027])"},{"line_number":1461,"context_line":"        self.assertEqual(\u0027host1\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_a7fa1572","line":1459,"updated":"2017-08-02 08:01:59.000000000","message":"First I wondered if this could be prone to race condition between resize_revert.end and setting the instance state back to ACTIVE but as I see the instance is first set to ACTIVE and then the notification is emitted. So it is safe.","commit_id":"fa333798f9bd7950f72b600463744c90f21789d2"}]}