)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_cf9dcb0a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"updated":"2017-08-15 22:36:44.000000000","message":"Now days","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_4f91dbf0","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":54},"updated":"2017-08-15 22:36:44.000000000","message":"so or let\u0027s","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_3e6243d9","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":54},"in_reply_to":"9f436f4f_4f91dbf0","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_1e5d3f14","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"9f436f4f_cf9dcb0a","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_6fafff29","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":33},"updated":"2017-08-15 22:36:44.000000000","message":"images","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_0f66332b","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":48},"updated":"2017-08-15 22:36:44.000000000","message":"with an external","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_fe9ddbbb","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":48},"in_reply_to":"9f436f4f_0f66332b","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_dea0d7f6","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":33},"in_reply_to":"9f436f4f_6fafff29","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"},{"line_number":14,"context_line":"Signed-off-by: Kevin Zhao \u003cKevin.Zhao@arm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_cf6b8bee","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":39},"updated":"2017-08-15 22:36:44.000000000","message":"this change doesn\u0027t","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowsday UEFI is essential boot method for AArch64, and"},{"line_number":10,"context_line":"make it as default. For the image that boot from initrd/"},{"line_number":11,"context_line":"kernel, add uefi as default will never affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"},{"line_number":14,"context_line":"Signed-off-by: Kevin Zhao \u003cKevin.Zhao@arm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_bea3d3ff","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":39},"in_reply_to":"9f436f4f_cf6b8bee","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"07d8e3bb576293d75fc70516aef938c9333a5899","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Zhao \u003ckevin.zhao@arm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-16 11:34:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make uefi as the default boot perproties for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nowadays UEFI is essential boot method for AArch64, so"},{"line_number":10,"context_line":"make it as default. For the images that boot with external"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_7f6410ba","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":40},"updated":"2017-08-22 16:07:22.000000000","message":"properties","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"07d8e3bb576293d75fc70516aef938c9333a5899","unresolved":false,"context_lines":[{"line_number":11,"context_line":"initrd/kernel, this change doesn\u0027t affect them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70ad5ecb420b7d469854e8743e38ba27fd204747"},{"line_number":14,"context_line":"Signed-off-by: Kevin Zhao \u003cKevin.Zhao@arm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_9f2d7c48","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":45},"updated":"2017-08-22 16:07:22.000000000","message":"I was going to look for proof until I saw this. I trust you know what you\u0027re saying","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96787fd6c3cf9ab268ddf071864eb1c31c224456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f91af0f_8b44151d","line":15,"updated":"2018-01-03 17:00:00.000000000","message":"We should really have a bug report here. What happens if this isn\u0027t defined? Something bad must happen to say this is necessary, I imagine","commit_id":"7a0f208666f60f1ed010631a53777d9db1517fe9"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b11e85ab846ea7e29a6540cb3e633cc9e0b071d4","unresolved":false,"context_lines":[{"line_number":5422,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5423,"context_line":"                       \"_get_guest_storage_config\")"},{"line_number":5424,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \"_has_numa_support\")"},{"line_number":5425,"context_line":"    def test_get_guest_config_aarch64(self, mock_numa, mock_storage):"},{"line_number":5426,"context_line":"        def get_host_capabilities_stub(self):"},{"line_number":5427,"context_line":"            cpu \u003d vconfig.LibvirtConfigGuestCPU()"},{"line_number":5428,"context_line":"            cpu.arch \u003d fields.Architecture.AARCH64"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_b07b2879","line":5425,"updated":"2017-08-14 21:11:36.000000000","message":"The mock should be at the test level rather than in the middle","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"6ea849ba2ed0849a3925eeee3235dc2d9d1dfca4","unresolved":false,"context_lines":[{"line_number":5422,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5423,"context_line":"                       \"_get_guest_storage_config\")"},{"line_number":5424,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \"_has_numa_support\")"},{"line_number":5425,"context_line":"    def test_get_guest_config_aarch64(self, mock_numa, mock_storage):"},{"line_number":5426,"context_line":"        def get_host_capabilities_stub(self):"},{"line_number":5427,"context_line":"            cpu \u003d vconfig.LibvirtConfigGuestCPU()"},{"line_number":5428,"context_line":"            cpu.arch \u003d fields.Architecture.AARCH64"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_eab2d448","line":5425,"in_reply_to":"9f436f4f_b07b2879","updated":"2017-08-15 08:19:26.000000000","message":"Done","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b11e85ab846ea7e29a6540cb3e633cc9e0b071d4","unresolved":false,"context_lines":[{"line_number":5445,"context_line":"        self.stubs.Set(host.Host, \"get_capabilities\","},{"line_number":5446,"context_line":"                       get_host_capabilities_stub)"},{"line_number":5447,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5448,"context_line":"        with mock.patch.object(drvr, \"_has_uefi_support\","},{"line_number":5449,"context_line":"                               return_value\u003dTrue) as mock_support:"},{"line_number":5450,"context_line":"            cfg \u003d drvr._get_guest_config(instance_ref,"},{"line_number":5451,"context_line":"                                         _fake_network_info(self, 1),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_10baf408","line":5448,"range":{"start_line":5448,"start_character":38,"end_line":5448,"end_character":55},"updated":"2017-08-14 21:11:36.000000000","message":"This is a line ball call but I think it\u0027s better to leave this function unmocked and instead do something like\n\n  mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)\n\nand then add another assertion that it\u0027s called with only the UEFI_LOADER as an arg.","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"6ea849ba2ed0849a3925eeee3235dc2d9d1dfca4","unresolved":false,"context_lines":[{"line_number":5445,"context_line":"        self.stubs.Set(host.Host, \"get_capabilities\","},{"line_number":5446,"context_line":"                       get_host_capabilities_stub)"},{"line_number":5447,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":5448,"context_line":"        with mock.patch.object(drvr, \"_has_uefi_support\","},{"line_number":5449,"context_line":"                               return_value\u003dTrue) as mock_support:"},{"line_number":5450,"context_line":"            cfg \u003d drvr._get_guest_config(instance_ref,"},{"line_number":5451,"context_line":"                                         _fake_network_info(self, 1),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_aa8a8c66","line":5448,"range":{"start_line":5448,"start_character":38,"end_line":5448,"end_character":55},"in_reply_to":"9f436f4f_10baf408","updated":"2017-08-15 08:19:26.000000000","message":"Done","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b11e85ab846ea7e29a6540cb3e633cc9e0b071d4","unresolved":false,"context_lines":[{"line_number":5450,"context_line":"            cfg \u003d drvr._get_guest_config(instance_ref,"},{"line_number":5451,"context_line":"                                         _fake_network_info(self, 1),"},{"line_number":5452,"context_line":"                                         image_meta, disk_info)"},{"line_number":5453,"context_line":"            mock_support.assert_called_once_with()"},{"line_number":5454,"context_line":"            self.assertEqual(cfg.os_mach_type, \"virt\")"},{"line_number":5455,"context_line":""},{"line_number":5456,"context_line":"    def test_get_guest_config_machine_type_s390(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_709940c2","line":5453,"range":{"start_line":5453,"start_character":12,"end_line":5453,"end_character":50},"updated":"2017-08-14 21:11:36.000000000","message":"This would be better as:\n\n self.assertTrue(mock_support.called)","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"6ea849ba2ed0849a3925eeee3235dc2d9d1dfca4","unresolved":false,"context_lines":[{"line_number":5450,"context_line":"            cfg \u003d drvr._get_guest_config(instance_ref,"},{"line_number":5451,"context_line":"                                         _fake_network_info(self, 1),"},{"line_number":5452,"context_line":"                                         image_meta, disk_info)"},{"line_number":5453,"context_line":"            mock_support.assert_called_once_with()"},{"line_number":5454,"context_line":"            self.assertEqual(cfg.os_mach_type, \"virt\")"},{"line_number":5455,"context_line":""},{"line_number":5456,"context_line":"    def test_get_guest_config_machine_type_s390(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_8a7b4879","line":5453,"range":{"start_line":5453,"start_character":12,"end_line":5453,"end_character":50},"in_reply_to":"9f436f4f_709940c2","updated":"2017-08-15 08:19:26.000000000","message":"Done","commit_id":"3638dcc2e9204934f871f980574c4ffafc7dd6bc"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":5428,"context_line":"                       \"_get_guest_storage_config\")"},{"line_number":5429,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \"_has_numa_support\")"},{"line_number":5430,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":5431,"context_line":"    def test_get_guest_config_aarch64(self, mock_support,"},{"line_number":5432,"context_line":"                                      mock_numa, mock_storage):"},{"line_number":5433,"context_line":"        def get_host_capabilities_stub(self):"},{"line_number":5434,"context_line":"            cpu \u003d vconfig.LibvirtConfigGuestCPU()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_4f755bf9","line":5431,"range":{"start_line":5431,"start_character":44,"end_line":5431,"end_character":56},"updated":"2017-08-15 22:36:44.000000000","message":"This name isn\u0027t appropriate as you\u0027re mocking os.path.exists nothing to do with support.  Perhaps mock_path_exists?","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":5428,"context_line":"                       \"_get_guest_storage_config\")"},{"line_number":5429,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \"_has_numa_support\")"},{"line_number":5430,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":5431,"context_line":"    def test_get_guest_config_aarch64(self, mock_support,"},{"line_number":5432,"context_line":"                                      mock_numa, mock_storage):"},{"line_number":5433,"context_line":"        def get_host_capabilities_stub(self):"},{"line_number":5434,"context_line":"            cpu \u003d vconfig.LibvirtConfigGuestCPU()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_a315004b","line":5431,"range":{"start_line":5431,"start_character":44,"end_line":5431,"end_character":56},"in_reply_to":"9f436f4f_4f755bf9","updated":"2017-08-16 03:16:08.000000000","message":"Done","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97c01bdb41fd992f972354124987b6a758b2d28e","unresolved":false,"context_lines":[{"line_number":5457,"context_line":"                                     image_meta, disk_info)"},{"line_number":5458,"context_line":"        self.assertTrue(mock_support.called)"},{"line_number":5459,"context_line":"        mock_support.assert_called_with("},{"line_number":5460,"context_line":"            DEFAULT_UEFI_LOADER_PATH[fields.Architecture.AARCH64])"},{"line_number":5461,"context_line":"        self.assertEqual(cfg.os_mach_type, \"virt\")"},{"line_number":5462,"context_line":""},{"line_number":5463,"context_line":"    def test_get_guest_config_machine_type_s390(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_af84c7d3","line":5460,"range":{"start_line":5460,"start_character":12,"end_line":5460,"end_character":36},"updated":"2017-08-15 22:36:44.000000000","message":"This could be:\n\n libvirt_driver.DEFAULT_UEFI_LOADER_PATH[fields.Architecture.AARCH64]\n\nThis avoids having to duplicate the dictionary which will lead to teat failures if the one in driver.py is updated without this being updated.  They have to be in sync so don\u0027t duplicate them.\n\nIf we use the Architecture.AARCH64 enum the line will probably need to be wrapped so it *might* be worth just opencoding the \u0027aarch64\u0027?  Try it both ways and see which is better to read.","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"8618fdf8ed0c690ea1e4850acbecc007b5b5dcee","unresolved":false,"context_lines":[{"line_number":5457,"context_line":"                                     image_meta, disk_info)"},{"line_number":5458,"context_line":"        self.assertTrue(mock_support.called)"},{"line_number":5459,"context_line":"        mock_support.assert_called_with("},{"line_number":5460,"context_line":"            DEFAULT_UEFI_LOADER_PATH[fields.Architecture.AARCH64])"},{"line_number":5461,"context_line":"        self.assertEqual(cfg.os_mach_type, \"virt\")"},{"line_number":5462,"context_line":""},{"line_number":5463,"context_line":"    def test_get_guest_config_machine_type_s390(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_7e6c4bcd","line":5460,"range":{"start_line":5460,"start_character":12,"end_line":5460,"end_character":36},"in_reply_to":"9f436f4f_af84c7d3","updated":"2017-08-16 03:16:08.000000000","message":"@Tony,\nThanks for this advice.\nI\u0027ve tried and find that using \u0027aarch64\u0027 is more easy reading.","commit_id":"e2efa9273024166ab25e3180b228b7d7a784f43c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"45185d308168a46ad128917efda98350d5357452","unresolved":false,"context_lines":[{"line_number":5589,"context_line":"                                     image_meta, disk_info)"},{"line_number":5590,"context_line":"        self.assertTrue(mock_path_exists.called)"},{"line_number":5591,"context_line":"        mock_path_exists.assert_called_with("},{"line_number":5592,"context_line":"            libvirt_driver.DEFAULT_UEFI_LOADER_PATH[\u0027aarch64\u0027])"},{"line_number":5593,"context_line":"        self.assertEqual(cfg.os_mach_type, \"virt\")"},{"line_number":5594,"context_line":""},{"line_number":5595,"context_line":"    def test_get_guest_config_machine_type_s390(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_ee44a11d","line":5592,"updated":"2018-01-05 15:32:20.000000000","message":"Note: os.path.exists is called inside _has_uefi_support.","commit_id":"6f54f5c1e37a42b395ca793f869b73aa902602ed"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fc6fe6a8eabb1026cb53115ecf87dce558dbce33","unresolved":false,"context_lines":[{"line_number":4482,"context_line":"                           fields.Architecture.AARCH64]"},{"line_number":4483,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4484,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":4485,"context_line":"                os.path.exists(DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]))"},{"line_number":4486,"context_line":""},{"line_number":4487,"context_line":"    def _get_supported_perf_events(self):"},{"line_number":4488,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_cb997bc4","line":4485,"updated":"2017-08-14 01:03:02.000000000","message":"This is probably what is tripping you up.  Try mocking os.path.exists in the failing test case.","commit_id":"e68aa01c0561f44d6108faab696ee42a4f7e1d5f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d0c2a9353b16e3f725bd9e07471f18b6b1f97026","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"},{"line_number":4530,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4531,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_d45dcde9","line":4528,"updated":"2017-08-25 08:27:51.000000000","message":"The problem I see here is that you are overriding the image property. I would say we should keep ability for users to configure it that at least to do not break any image already configured.","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d97fa56e0481356c23c30c7eba0d2b383576f828","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"},{"line_number":4530,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4531,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_d6548355","line":4528,"in_reply_to":"7f287b81_0703250f","updated":"2017-08-28 12:39:35.000000000","message":"Is there any harm in setting hw_firmware_type *only* if it is unset in the image_meta.properties?\n\nJust anticipating a bug like \"hw_firmware_type not honored on aarch64\".  If this is in fact the only setting that ever works, and they set it to something else, I think we would rather fail with \"Invalid firmware type; aarch64 only supports uefi\" versus silently ignoring and overriding.","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6f32f7e67ce3bf26f8ea702c435cb18de5a71d41","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"},{"line_number":4530,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4531,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_0703250f","line":4528,"in_reply_to":"7f287b81_d45dcde9","updated":"2017-08-25 08:57:51.000000000","message":"Sahid: on aarch64 there are two ways of boot VM: UEFI or kernel/initrd directly. We do not have seabios option like it is on x86.\n\nhw_firmware_type\u003duefi works with both ways of boot and does not change how kernel/initrd direct works.","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1b39ec7a8c39582a6d36a40fe06893c22ad5ac90","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"},{"line_number":4530,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4531,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_e9b0c045","line":4528,"in_reply_to":"7f287b81_d6548355","updated":"2017-08-28 12:54:38.000000000","message":"Eric: good point!\n\nKevin: can you add check for not set hw_firmware_type and set it to UEFI if it is not set?","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"eabc70cfeb8cdb5306b2a98a3bc9816a384a57b0","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"},{"line_number":4530,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4531,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_a2fbed44","line":4528,"in_reply_to":"7f287b81_e9b0c045","updated":"2017-08-28 14:47:57.000000000","message":"Yes that was the point, we should not override silently setting from users.\n\nI would have not added a condition saying that \"aarch64 only supports UEFI\", a) if users are setting something bad the VM is not going to boot, b) we don\u0027t know what will happen in future so why to add a check which is going to be a bug at some point. - if you look for the other arch is not something we do.","commit_id":"e4a4ab7eefdbb70ac3c90ee7f4326cffce740925"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7811c847b1cc17719e691a7a5fb75ff296067bac","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_3258132f","line":4528,"range":{"start_line":4528,"start_character":15,"end_line":4528,"end_character":66},"updated":"2017-08-31 11:54:04.000000000","message":"This ain\u0027t gonna work unless AARCH64 is a list.\n\nIf you want this to be a tuple, you need a trailing comma before the close paren.\n\nBut you might as well instead say:\n\n if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1f385d0ce0423ff07824d5ee290f8e32da6ebd23","unresolved":false,"context_lines":[{"line_number":4525,"context_line":"                guest.sysinfo \u003d self._get_guest_config_sysinfo(instance)"},{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_6083f0cd","line":4528,"range":{"start_line":4528,"start_character":15,"end_line":4528,"end_character":66},"in_reply_to":"7f287b81_3258132f","updated":"2018-01-03 16:42:04.000000000","message":"Done","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba7fe98d7fe3f67faac39973c121c53aa4ee6fd0","unresolved":false,"context_lines":[{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"},{"line_number":4532,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_9d07ddca","line":4529,"updated":"2017-08-31 10:13:11.000000000","message":"You are still overriding users data silently and you are spamming the operators which can\u0027t do anything to resolve this problem.\n\n  if caps.host.cpu.arch in (fields.Architecture.AARCH64):\n      if not hw_firmware_type:\n         hw_firmware_type \u003d fields.FirmwareType.UEFI\n\nIf you still want to add a log, so a notice or a debug should be enough.","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7811c847b1cc17719e691a7a5fb75ff296067bac","unresolved":false,"context_lines":[{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"},{"line_number":4532,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_f23debba","line":4529,"in_reply_to":"7f287b81_0f8050f4","updated":"2017-08-31 11:54:04.000000000","message":"Agree.","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b7111041abb3c55f087b597d8f17a7046dce010d","unresolved":false,"context_lines":[{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"},{"line_number":4532,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_0f8050f4","line":4529,"in_reply_to":"7f287b81_9d07ddca","updated":"2017-08-31 11:13:15.000000000","message":"Agree with sahid here. Also his code suggestion is what I would like to see here.","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1f385d0ce0423ff07824d5ee290f8e32da6ebd23","unresolved":false,"context_lines":[{"line_number":4526,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4527,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4528,"context_line":"            if caps.host.cpu.arch in (fields.Architecture.AARCH64):"},{"line_number":4529,"context_line":"                if hw_firmware_type !\u003d fields.FirmwareType.UEFI:"},{"line_number":4530,"context_line":"                    LOG.warning(\"Invalid firmware type; aarch64 only \""},{"line_number":4531,"context_line":"                                \"supports uefi\")"},{"line_number":4532,"context_line":"                hw_firmware_type \u003d fields.FirmwareType.UEFI"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_808634db","line":4529,"in_reply_to":"7f287b81_9d07ddca","updated":"2018-01-03 16:42:04.000000000","message":"Done","commit_id":"15b69a991c75f08d2d0c3800d4b8b5b9e864f5c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96787fd6c3cf9ab268ddf071864eb1c31c224456","unresolved":false,"context_lines":[{"line_number":4503,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4504,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4505,"context_line":"            if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":4506,"context_line":"                if not hw_firmware_type:"},{"line_number":4507,"context_line":"                    hw_firmware_type \u003d fields.FirmwareType.UEFI:"},{"line_number":4508,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4509,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_cb3a1d97","line":4506,"range":{"start_line":4506,"start_character":16,"end_line":4506,"end_character":40},"updated":"2018-01-03 17:00:00.000000000","message":"What happens if it is defined and not \u0027uefi\u0027? Previously you were logging a warning. I appreciate that we don\u0027t want to spam the user, but surely we should kill the boot if this just will not work (or does that already happen?)","commit_id":"7a0f208666f60f1ed010631a53777d9db1517fe9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"24ae2aa0a051af03ecd623fd9c29655ccb125792","unresolved":false,"context_lines":[{"line_number":4503,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":4504,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4505,"context_line":"            if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":4506,"context_line":"                if not hw_firmware_type:"},{"line_number":4507,"context_line":"                    hw_firmware_type \u003d fields.FirmwareType.UEFI:"},{"line_number":4508,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4509,"context_line":"                if self._has_uefi_support():"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_8be095fc","line":4506,"range":{"start_line":4506,"start_character":16,"end_line":4506,"end_character":40},"in_reply_to":"9f91af0f_cb3a1d97","updated":"2018-01-03 17:06:17.000000000","message":"\u003e What happens if it is defined and not \u0027uefi\u0027? \n\nThere are two ways to boot AArch64 VM:\n\n1. UEFI\n2. kernel+initrd\n\nNo one sane is using 2nd option so we set hw_firmware_type\u003duefi for each used image.\n\nIf someone will invent own bootloader for VM and wants to use it then they set hw_firmware_type\u003dtheir-own-bootloader as image property and patch Nova to handle it.\n\n\u003e Previously you were logging a warning. I appreciate that we don\u0027t \n\u003e want to spam the user, but surely we should kill the boot if this\n\u003e just will not work (or does that already happen?)\n\nIf someone wants to play with kernel+initrd or works on other way of booting aarch64 vm then in this form patch will not interfere.","commit_id":"7a0f208666f60f1ed010631a53777d9db1517fe9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96787fd6c3cf9ab268ddf071864eb1c31c224456","unresolved":false,"context_lines":[{"line_number":4504,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4505,"context_line":"            if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":4506,"context_line":"                if not hw_firmware_type:"},{"line_number":4507,"context_line":"                    hw_firmware_type \u003d fields.FirmwareType.UEFI:"},{"line_number":4508,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4509,"context_line":"                if self._has_uefi_support():"},{"line_number":4510,"context_line":"                    global uefi_logged"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_0be24530","line":4507,"range":{"start_line":4507,"start_character":63,"end_line":4507,"end_character":64},"updated":"2018-01-03 17:00:00.000000000","message":"This shouldn\u0027t be here","commit_id":"7a0f208666f60f1ed010631a53777d9db1517fe9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"24ae2aa0a051af03ecd623fd9c29655ccb125792","unresolved":false,"context_lines":[{"line_number":4504,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":4505,"context_line":"            if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":4506,"context_line":"                if not hw_firmware_type:"},{"line_number":4507,"context_line":"                    hw_firmware_type \u003d fields.FirmwareType.UEFI:"},{"line_number":4508,"context_line":"            if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":4509,"context_line":"                if self._has_uefi_support():"},{"line_number":4510,"context_line":"                    global uefi_logged"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_eb6da198","line":4507,"range":{"start_line":4507,"start_character":63,"end_line":4507,"end_character":64},"in_reply_to":"9f91af0f_0be24530","updated":"2018-01-03 17:06:17.000000000","message":"Done","commit_id":"7a0f208666f60f1ed010631a53777d9db1517fe9"}]}