)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e72ab4d7b0208c2b1445bd33b6e79fc9c2799b0","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"        self.assertFlavorMatchesAllocation(old_flavor, usages)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"        # NOTE(gibi): After fixing bug 1707252 the following is expected"},{"line_number":1473,"context_line":"        # self.assertEqual(max(old_flavor[\u0027vcpus\u0027], new_flavor[\u0027vcpus\u0027]),"},{"line_number":1474,"context_line":"        #                  usages[\u0027VCPU\u0027])"},{"line_number":1475,"context_line":"        # self.assertEqual(max(old_flavor[\u0027ram\u0027], new_flavor[\u0027ram\u0027]),"},{"line_number":1476,"context_line":"        #                  usages[\u0027MEMORY_MB\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_35ad2188","line":1473,"updated":"2017-08-02 16:05:02.000000000","message":"All this type of assert should be changed in the following way to assert a real double up.\nself.assertEqual(old_flavor[\u0027vcpus\u0027] + new_flavor[\u0027vcpus\u0027]), usages[\u0027VCPU\u0027])","commit_id":"06b244a1e12dff4c6aa5ec999d814e4f1ae1d84f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f937c9fcd404aae6756b92922ee31ae40ef3191","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"        # self.assertEqual(old_flavor[\u0027disk\u0027] + new_flavor[\u0027disk\u0027],"},{"line_number":1494,"context_line":"        #                  allocation[\u0027DISK_GB\u0027])"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"        self._run_periodics()"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        usages \u003d self._get_provider_usages(rp_uuid)"},{"line_number":1499,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_bb48d786","line":1496,"range":{"start_line":1496,"start_character":13,"end_line":1496,"end_character":27},"updated":"2017-08-02 21:08:15.000000000","message":"We don\u0027t really need to run periodics for the disabled compute2, but it\u0027s OK, and it would actually still continue running in real life, so probably good we don\u0027t change that.","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b6c8e33f07015618461d439a6bf0e3c27cf9ea28","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"        # self.assertEqual(old_flavor[\u0027disk\u0027] + new_flavor[\u0027disk\u0027],"},{"line_number":1494,"context_line":"        #                  allocation[\u0027DISK_GB\u0027])"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"        self._run_periodics()"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        usages \u003d self._get_provider_usages(rp_uuid)"},{"line_number":1499,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_bb59f735","line":1496,"updated":"2017-08-02 20:39:33.000000000","message":"it would be useful to have a comment here that says what impact this is supposed to have","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88cb91c1c67e68f9fa2c6c70ff8327ba08845d90","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"        # self.assertEqual(old_flavor[\u0027disk\u0027] + new_flavor[\u0027disk\u0027],"},{"line_number":1494,"context_line":"        #                  allocation[\u0027DISK_GB\u0027])"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"        self._run_periodics()"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        usages \u003d self._get_provider_usages(rp_uuid)"},{"line_number":1499,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_5b468bc2","line":1496,"in_reply_to":"df3967d1_bb59f735","updated":"2017-08-02 20:57:43.000000000","message":"Yeah this is copied from _resize_and_check_allocations where we check things before and after the periodic, and the periodic stomps on the double allocation for the source/dest host when they are different in that case.","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14ebaab2bf5d10af6e204dd55c2bbfb6afc10100","unresolved":false,"context_lines":[{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        usages \u003d self._get_provider_usages(rp_uuid)"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"        # NOTE(gibi): This is bug 1707252, where the usages are not doubled for"},{"line_number":1501,"context_line":"        # resize to same host"},{"line_number":1502,"context_line":"        self.assertFlavorMatchesAllocation(new_flavor, usages)"},{"line_number":1503,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_5be20ba2","line":1500,"range":{"start_line":1500,"start_character":34,"end_line":1500,"end_character":41},"updated":"2017-08-02 21:00:42.000000000","message":"I think this is bug 1707071 where the compute overwrites the summed allocations that the scheduler created. Hence the confusion above about running periodics in between.","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14ebaab2bf5d10af6e204dd55c2bbfb6afc10100","unresolved":false,"context_lines":[{"line_number":1513,"context_line":"        self.assertEqual(1, len(allocations))"},{"line_number":1514,"context_line":"        allocation \u003d allocations[rp_uuid][\u0027resources\u0027]"},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"        # NOTE(gibi): This is bug 1707252, where allocation is not doubled for"},{"line_number":1517,"context_line":"        # resize to same host"},{"line_number":1518,"context_line":"        self.assertFlavorMatchesAllocation(new_flavor, allocation)"},{"line_number":1519,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_3bdf47d7","line":1516,"range":{"start_line":1516,"start_character":34,"end_line":1516,"end_character":41},"updated":"2017-08-02 21:00:42.000000000","message":"1707071","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88cb91c1c67e68f9fa2c6c70ff8327ba08845d90","unresolved":false,"context_lines":[{"line_number":1558,"context_line":"        self._delete_and_check_allocations(server, rp_uuid, rp_uuid)"},{"line_number":1559,"context_line":""},{"line_number":1560,"context_line":"    def test_resize_confirm_same_host(self):"},{"line_number":1561,"context_line":"        # make sure that the test only uses a single host"},{"line_number":1562,"context_line":"        compute2_service_id \u003d self.admin_api.get_services("},{"line_number":1563,"context_line":"            host\u003dself.compute2.host, binary\u003d\u0027nova-compute\u0027)[0][\u0027id\u0027]"},{"line_number":1564,"context_line":"        self.admin_api.put_service(compute2_service_id, {\u0027status\u0027: \u0027disabled\u0027})"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"        hostname \u003d self.compute1.manager.host"},{"line_number":1567,"context_line":"        rp_uuid \u003d self._get_provider_uuid_by_host(hostname)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_1bbec3d4","line":1564,"range":{"start_line":1561,"start_character":8,"end_line":1564,"end_character":79},"updated":"2017-08-02 20:57:43.000000000","message":"OK I was wondering how you\u0027d make this a single node run. I was thinking maybe we\u0027d have a new subclass for the tests which set a flag for how many computes to start, but this is also fine and easier.","commit_id":"4133ee7d5d0d62e79da37ad8e1116e70c726de79"}]}