)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"845a5021477b690e23528c6485083282f55ebd6b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"compute."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When the CoreFilter is enabled the the resource accounting seems"},{"line_number":13,"context_line":"correct."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Whenthe CoreFilter is not enabled then I see two possible expected"},{"line_number":16,"context_line":"bahaviors to choose from:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_91700f0a","line":13,"updated":"2017-08-04 18:30:25.000000000","message":"The CoreFilter shouldn\u0027t be enabled at all. It\u0027s redundant code.","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3d347b2f7eaee4522e59af042499da180d6cc24","unresolved":false,"context_lines":[{"line_number":10,"context_line":"compute."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When the CoreFilter is enabled the the resource accounting seems"},{"line_number":13,"context_line":"correct."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Whenthe CoreFilter is not enabled then I see two possible expected"},{"line_number":16,"context_line":"bahaviors to choose from:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf3e73b7_530db93c","line":13,"in_reply_to":"df3967d1_91700f0a","updated":"2017-08-07 11:35:31.000000000","message":"Done","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"845a5021477b690e23528c6485083282f55ebd6b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Whenthe CoreFilter is not enabled then I see two possible expected"},{"line_number":16,"context_line":"bahaviors to choose from:"},{"line_number":17,"context_line":"* Option A: Scheduling should fail with NoValidHost. This is not the"},{"line_number":18,"context_line":"  case today."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Option B: We allow the Server to boot. Then we expect that the"},{"line_number":21,"context_line":"  allocations at least reflect the amount of (over) allocated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_517f47df","line":18,"updated":"2017-08-04 18:30:25.000000000","message":"This should be the case and if it isn\u0027t, this is a bug that needs to be addressed.","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3d347b2f7eaee4522e59af042499da180d6cc24","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Whenthe CoreFilter is not enabled then I see two possible expected"},{"line_number":16,"context_line":"bahaviors to choose from:"},{"line_number":17,"context_line":"* Option A: Scheduling should fail with NoValidHost. This is not the"},{"line_number":18,"context_line":"  case today."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Option B: We allow the Server to boot. Then we expect that the"},{"line_number":21,"context_line":"  allocations at least reflect the amount of (over) allocated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf3e73b7_330a3526","line":18,"in_reply_to":"df3967d1_517f47df","updated":"2017-08-07 11:35:31.000000000","message":"Done","commit_id":"0338ca092101299f578e0928706d03b7299da342"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9d6590606a48ad06aa25196e24aba794a2bb4aaa","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    def setUp(self):"},{"line_number":1074,"context_line":"        # NOTE(danms): The test defaults to using SmallFakeDriver,"},{"line_number":1075,"context_line":"        # which only has one vcpu, which can\u0027t take the doubled allocation"},{"line_number":1076,"context_line":"        # we\u0027re now giving it. So, use the bigger MediumFakeDriver here."},{"line_number":1077,"context_line":"        self.flags(compute_driver\u003d\u0027fake.MediumFakeDriver\u0027)"},{"line_number":1078,"context_line":"        self.flags(enabled_filters\u003dself._enabled_filters,"},{"line_number":1079,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_b158b355","line":1076,"range":{"start_line":1076,"start_character":43,"end_line":1076,"end_character":49},"updated":"2017-08-04 18:33:08.000000000","message":"I think you mean the smaller MediumFakeDriver, right? normal FakeDriver has 1000 VCPUs...","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3d347b2f7eaee4522e59af042499da180d6cc24","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    def setUp(self):"},{"line_number":1074,"context_line":"        # NOTE(danms): The test defaults to using SmallFakeDriver,"},{"line_number":1075,"context_line":"        # which only has one vcpu, which can\u0027t take the doubled allocation"},{"line_number":1076,"context_line":"        # we\u0027re now giving it. So, use the bigger MediumFakeDriver here."},{"line_number":1077,"context_line":"        self.flags(compute_driver\u003d\u0027fake.MediumFakeDriver\u0027)"},{"line_number":1078,"context_line":"        self.flags(enabled_filters\u003dself._enabled_filters,"},{"line_number":1079,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_d319a988","line":1076,"range":{"start_line":1076,"start_character":43,"end_line":1076,"end_character":49},"in_reply_to":"df3967d1_b158b355","updated":"2017-08-07 11:35:31.000000000","message":"The tests defaults to the SmallFakeDriver and  the MediumFakeDriver is bigger than the SmallFakeDriver.","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"845a5021477b690e23528c6485083282f55ebd6b","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"            filters.append(\u0027CoreFilter\u0027)"},{"line_number":1592,"context_line":"            self.flags(enabled_filters\u003dfilters,"},{"line_number":1593,"context_line":"                       group\u003d\u0027filter_scheduler\u0027)"},{"line_number":1594,"context_line":"            self.scheduler \u003d self.start_service(\u0027scheduler\u0027)"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        flavor_body \u003d {\u0027flavor\u0027:"},{"line_number":1597,"context_line":"                           {\u0027name\u0027: \u0027test_too_big_flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_f1dd1be0","line":1594,"updated":"2017-08-04 18:30:25.000000000","message":"Get rid of the enable_core_filter stuff entirely. We need to fix things to ensure correct behaviour when CoreFilter isn\u0027t around.","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3d347b2f7eaee4522e59af042499da180d6cc24","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"            filters.append(\u0027CoreFilter\u0027)"},{"line_number":1592,"context_line":"            self.flags(enabled_filters\u003dfilters,"},{"line_number":1593,"context_line":"                       group\u003d\u0027filter_scheduler\u0027)"},{"line_number":1594,"context_line":"            self.scheduler \u003d self.start_service(\u0027scheduler\u0027)"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        flavor_body \u003d {\u0027flavor\u0027:"},{"line_number":1597,"context_line":"                           {\u0027name\u0027: \u0027test_too_big_flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_93132167","line":1594,"in_reply_to":"df3967d1_f1dd1be0","updated":"2017-08-07 11:35:31.000000000","message":"Done","commit_id":"0338ca092101299f578e0928706d03b7299da342"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"285cb49f62a0ec2cbf71338fb2be96a6489b80e4","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        # NOTE(gibi): This is bug 1708637. Placement returns no allocation"},{"line_number":1616,"context_line":"        # candidate and the scheduler falls back to the legacy filtering. As"},{"line_number":1617,"context_line":"        # CoreFilter is not enabled the filtering result in hosts selected"},{"line_number":1618,"context_line":"        # without enough VCPU resource"},{"line_number":1619,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], resize_req)"},{"line_number":1620,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":1621,"context_line":"        self.assertEqual(dest_hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"        # Note(gibi): After bug 1708637 is fixed the following is expected"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_b0971b91","line":1620,"range":{"start_line":1617,"start_character":40,"end_line":1620,"end_character":79},"updated":"2017-08-09 19:58:36.000000000","message":"Why wouldn\u0027t the claim in the compute service fail though? Yes we failed to filter the host out of the scheduler, but the claim in the compute should still fail.","commit_id":"13f52d443ed2a5154c9b10ee19ea5aed8205e37b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"256c5d8977428549e4319c6e93812b5c234515b9","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        # NOTE(gibi): This is bug 1708637. Placement returns no allocation"},{"line_number":1616,"context_line":"        # candidate and the scheduler falls back to the legacy filtering. As"},{"line_number":1617,"context_line":"        # CoreFilter is not enabled the filtering result in hosts selected"},{"line_number":1618,"context_line":"        # without enough VCPU resource"},{"line_number":1619,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], resize_req)"},{"line_number":1620,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":1621,"context_line":"        self.assertEqual(dest_hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"        # Note(gibi): After bug 1708637 is fixed the following is expected"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_f0aa4383","line":1620,"range":{"start_line":1617,"start_character":40,"end_line":1620,"end_character":79},"in_reply_to":"9f436f4f_b0971b91","updated":"2017-08-09 20:09:36.000000000","message":"Dan thought it might be due to cpu_allocation_ratio defaulting to 16.0, but I tried setting that to 1.0 at the start of the setUp and it still passes.","commit_id":"13f52d443ed2a5154c9b10ee19ea5aed8205e37b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46f653992a610198792d13061e05ea751819757b","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        # NOTE(gibi): This is bug 1708637. Placement returns no allocation"},{"line_number":1616,"context_line":"        # candidate and the scheduler falls back to the legacy filtering. As"},{"line_number":1617,"context_line":"        # CoreFilter is not enabled the filtering result in hosts selected"},{"line_number":1618,"context_line":"        # without enough VCPU resource"},{"line_number":1619,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], resize_req)"},{"line_number":1620,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":1621,"context_line":"        self.assertEqual(dest_hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"        # Note(gibi): After bug 1708637 is fixed the following is expected"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_8b706a74","line":1620,"range":{"start_line":1617,"start_character":40,"end_line":1620,"end_character":79},"in_reply_to":"9f436f4f_f0aa4383","updated":"2017-08-09 20:37:07.000000000","message":"OK it\u0027s because we don\u0027t have the CoreFilter enabled and that\u0027s what sets the vcpus limits for the claim:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/claims.py#L240-L244\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/core_filter.py#L52\n\nDan pointed this out.","commit_id":"13f52d443ed2a5154c9b10ee19ea5aed8205e37b"}]}