)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc9c60cc20a01260241b0a16d17d72961876ed49","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                claimed_host \u003d hosts[0]"},{"line_number":189,"context_line":"            else:"},{"line_number":190,"context_line":"                instance_uuid \u003d instance_uuids[num]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                # Attempt to claim the resources against one or more resource"},{"line_number":193,"context_line":"                # providers, looping over the sorted list of possible hosts"},{"line_number":194,"context_line":"                # looking for an allocation request that contains that host\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_938201c8","side":"PARENT","line":191,"updated":"2017-08-07 11:27:47.000000000","message":"seems like an unnecessary change","commit_id":"5971dde5d945bcbe1e81b87d342887abd5d2eece"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4d3f72de454fe33fb129cd3bc0d01a6c862a4477","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                claimed_host \u003d hosts[0]"},{"line_number":189,"context_line":"            else:"},{"line_number":190,"context_line":"                instance_uuid \u003d instance_uuids[num]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                # Attempt to claim the resources against one or more resource"},{"line_number":193,"context_line":"                # providers, looping over the sorted list of possible hosts"},{"line_number":194,"context_line":"                # looking for an allocation request that contains that host\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_0f8a651a","side":"PARENT","line":191,"in_reply_to":"bf3e73b7_938201c8","updated":"2017-08-07 12:56:39.000000000","message":"Correct, just missed to not modified it.","commit_id":"5971dde5d945bcbe1e81b87d342887abd5d2eece"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc9c60cc20a01260241b0a16d17d72961876ed49","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        :param context: The RequestContext object"},{"line_number":119,"context_line":"        :param spec_obj: The RequestSpec object"},{"line_number":120,"context_line":"        :param instance_uuids: List of UUIDs, one for each value of the spec"},{"line_number":121,"context_line":"                               object\u0027s num_instances attribute"},{"line_number":122,"context_line":"        :param alloc_reqs_by_rp_uuid: Optional dict, keyed by resource provider"},{"line_number":123,"context_line":"                                      UUID, of the allocation requests that may"},{"line_number":124,"context_line":"                                      be used to claim resources against"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_d32ac9e5","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":63},"updated":"2017-08-07 11:27:47.000000000","message":"Then I guess this is not true any more.","commit_id":"c6b578010ed7a5341d87cbb61af826673e05f78b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a4e81fb509753753a9e21aeb00859920387d7e1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        :param context: The RequestContext object"},{"line_number":119,"context_line":"        :param spec_obj: The RequestSpec object"},{"line_number":120,"context_line":"        :param instance_uuids: List of UUIDs, one for each value of the spec"},{"line_number":121,"context_line":"                               object\u0027s num_instances attribute"},{"line_number":122,"context_line":"        :param alloc_reqs_by_rp_uuid: Optional dict, keyed by resource provider"},{"line_number":123,"context_line":"                                      UUID, of the allocation requests that may"},{"line_number":124,"context_line":"                                      be used to claim resources against"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_0fff0502","line":121,"in_reply_to":"bf3e73b7_d32ac9e5","updated":"2017-08-07 12:45:12.000000000","message":"yeah would be good to clarify this","commit_id":"c6b578010ed7a5341d87cbb61af826673e05f78b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a4e81fb509753753a9e21aeb00859920387d7e1","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        # NOTE(sbauza): The RequestSpec.num_instances field contains the"},{"line_number":164,"context_line":"        # number of instances it was created at once but we can ask to move"},{"line_number":165,"context_line":"        # or resize just one."},{"line_number":166,"context_line":"        num_instances \u003d (len(instance_uuids) if instance_uuids"},{"line_number":167,"context_line":"                         else spec_obj.num_instances)"},{"line_number":168,"context_line":"        for num in range(num_instances):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_0f76e5a5","line":165,"updated":"2017-08-07 12:45:12.000000000","message":"Try:\n\nThe RequestSpec.num_instances field contains the number of instances created when the RequestSpec was used to first boot some instances. This is incorrect when doing a move or resize operation, so prefer the length of instance_uuids unless it is None.","commit_id":"c6b578010ed7a5341d87cbb61af826673e05f78b"}],"nova/tests/unit/scheduler/test_filter_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc9c60cc20a01260241b0a16d17d72961876ed49","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_schedule_old_reqspec_and_move_operation(self):"},{"line_number":195,"context_line":"        \"\"\"This test is for verifying that in case of a move operation with"},{"line_number":196,"context_line":"           an original RequestSpec created for 10 concurrent instances, we only"},{"line_number":197,"context_line":"           verify the instance that is moved.\"\"\""},{"line_number":198,"context_line":"        self._test_schedule_successful_claim(num_instances\u003d3)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_7360bd33","line":196,"range":{"start_line":196,"start_character":47,"end_line":196,"end_character":49},"updated":"2017-08-07 11:27:47.000000000","message":"nit:3","commit_id":"c6b578010ed7a5341d87cbb61af826673e05f78b"}]}