)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"03354843ac3f1d7714d867f5521725ed6f8a2e4e","unresolved":false,"context_lines":[{"line_number":15704,"context_line":"    \"\"\"Test for nova.virt.libvirt.libvirt_driver.LibvirtDriver.\"\"\""},{"line_number":15705,"context_line":"    def setUp(self):"},{"line_number":15706,"context_line":"        super(LibvirtDriverTestCase, self).setUp()"},{"line_number":15707,"context_line":"        self.flags(sysinfo_serial\u003d\"none\", group\u003d\"libvirt\")"},{"line_number":15708,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":15709,"context_line":"        os_vif.initialize()"},{"line_number":15710,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_df4e64c0","line":15707,"updated":"2017-08-22 16:18:03.000000000","message":"I think a more robust fix would be to add the following here:\n\n  self.flags(instances_path\u003dself.useFixture(fixtures.TempDir()).path\n\nThe issue is that _create_image explicitly creates the instances directory, and later we create console.log in there. We could mock these out, but as long as they don\u0027t interfere with each other it\u0027s really not that important, and maintaining the mocks would get kinda janky. By doing it here we give each test instance its own sandbox and clean it up afterwards.\n\nIMHO it would be better still to do this in FakeLibvirtFixture, but that would require an audit of all users which I haven\u0027t done.","commit_id":"7691641d9037d59ccec477327bdd0f602366f258"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"d1a63d01c336c543dd9a2f484e14a56a0226c20f","unresolved":false,"context_lines":[{"line_number":15704,"context_line":"    \"\"\"Test for nova.virt.libvirt.libvirt_driver.LibvirtDriver.\"\"\""},{"line_number":15705,"context_line":"    def setUp(self):"},{"line_number":15706,"context_line":"        super(LibvirtDriverTestCase, self).setUp()"},{"line_number":15707,"context_line":"        self.flags(sysinfo_serial\u003d\"none\", group\u003d\"libvirt\")"},{"line_number":15708,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":15709,"context_line":"        os_vif.initialize()"},{"line_number":15710,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_30a2329c","line":15707,"in_reply_to":"7f287b81_df4e64c0","updated":"2017-08-23 07:10:58.000000000","message":"Dear Matthew, thank you for your review !\n\nIs the mentioned above fix is a good way to close this issue ? And after it we need to report new launchpad bug - smth. like \"test_driver.py should be changed to use FakeLibvirtFixture ...\". Or it is better to do work with audit and changes for FakeLibvirtFixture in case of this bug fix ?","commit_id":"7691641d9037d59ccec477327bdd0f602366f258"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7021f585f9fabb6b456df028cbd88488c8258185","unresolved":false,"context_lines":[{"line_number":15735,"context_line":""},{"line_number":15736,"context_line":"        inst \u003d {}"},{"line_number":15737,"context_line":"        inst[\u0027id\u0027] \u003d 1"},{"line_number":15738,"context_line":"        inst[\u0027uuid\u0027] \u003d uuids.fake_instance_id"},{"line_number":15739,"context_line":"        inst[\u0027os_type\u0027] \u003d \u0027linux\u0027"},{"line_number":15740,"context_line":"        inst[\u0027image_ref\u0027] \u003d uuids.fake_image_ref"},{"line_number":15741,"context_line":"        inst[\u0027reservation_id\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_04737fe9","line":15738,"updated":"2017-08-22 16:00:27.000000000","message":"nit: Good change, but not strictly related.","commit_id":"7691641d9037d59ccec477327bdd0f602366f258"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"d1a63d01c336c543dd9a2f484e14a56a0226c20f","unresolved":false,"context_lines":[{"line_number":15735,"context_line":""},{"line_number":15736,"context_line":"        inst \u003d {}"},{"line_number":15737,"context_line":"        inst[\u0027id\u0027] \u003d 1"},{"line_number":15738,"context_line":"        inst[\u0027uuid\u0027] \u003d uuids.fake_instance_id"},{"line_number":15739,"context_line":"        inst[\u0027os_type\u0027] \u003d \u0027linux\u0027"},{"line_number":15740,"context_line":"        inst[\u0027image_ref\u0027] \u003d uuids.fake_image_ref"},{"line_number":15741,"context_line":"        inst[\u0027reservation_id\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_30559251","line":15738,"in_reply_to":"7f287b81_04737fe9","updated":"2017-08-23 07:10:58.000000000","message":"This change was needed to create different folder (same as instance ID) for each tests. It helps particular test to delete only folder which it created. Before this fix all tests created the same folder (as the uuid was hardcoded) and as several tests could executed at the same time - it isn\u0027t possible to understand what test should remove folder because other test could still use this folder and will fail if didn\u0027t find it.","commit_id":"7691641d9037d59ccec477327bdd0f602366f258"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"24b82cb70f78229be0435d4af9df56f9150f7d0e","unresolved":false,"context_lines":[{"line_number":15736,"context_line":""},{"line_number":15737,"context_line":"        inst \u003d {}"},{"line_number":15738,"context_line":"        inst[\u0027id\u0027] \u003d 1"},{"line_number":15739,"context_line":"        inst[\u0027uuid\u0027] \u003d uuids.fake_instance_id"},{"line_number":15740,"context_line":"        inst[\u0027os_type\u0027] \u003d \u0027linux\u0027"},{"line_number":15741,"context_line":"        inst[\u0027image_ref\u0027] \u003d uuids.fake_image_ref"},{"line_number":15742,"context_line":"        inst[\u0027reservation_id\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_18a191aa","line":15739,"updated":"2017-08-23 09:10:15.000000000","message":"nit: Now genuinely not strictly related as we\u0027re in separate directories :) Change is still good, though. Don\u0027t change it unless somebody else complains.","commit_id":"c337dd42c025a64b009da74d4a6e0b3ae3fa5e24"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"aed694bf6352163292ca8679dba3a959ab50a1e8","unresolved":false,"context_lines":[{"line_number":15736,"context_line":""},{"line_number":15737,"context_line":"        inst \u003d {}"},{"line_number":15738,"context_line":"        inst[\u0027id\u0027] \u003d 1"},{"line_number":15739,"context_line":"        inst[\u0027uuid\u0027] \u003d uuids.fake_instance_id"},{"line_number":15740,"context_line":"        inst[\u0027os_type\u0027] \u003d \u0027linux\u0027"},{"line_number":15741,"context_line":"        inst[\u0027image_ref\u0027] \u003d uuids.fake_image_ref"},{"line_number":15742,"context_line":"        inst[\u0027reservation_id\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_e0d03cfa","line":15739,"in_reply_to":"7f287b81_18a191aa","updated":"2017-08-23 15:55:27.000000000","message":"Agree 100%, now they are separated,but decided to keep this change anyway. There was no hardcoded uuid in other tests in this class or any other usages of this particular uuid, so it should be ok.","commit_id":"c337dd42c025a64b009da74d4a6e0b3ae3fa5e24"}]}