)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e5ffd425f2d10244e80c411389f8fcecccab642","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                      \"with Ocata compute hosts. Auto-correcting \""},{"line_number":1110,"context_line":"                      \"allocations to handle Ocata-style assumptions.\")"},{"line_number":1111,"context_line":"        else:"},{"line_number":1112,"context_line":"            # NOTE(jaypipes): We\u0027re on a Pike compute host or later in"},{"line_number":1113,"context_line":"            # a deployment with all compute hosts upgraded to Pike or"},{"line_number":1114,"context_line":"            # later"},{"line_number":1115,"context_line":"            #"},{"line_number":1116,"context_line":"            # If that is the case, then we know that the scheduler will"},{"line_number":1117,"context_line":"            # have properly created an allocation and that the compute"},{"line_number":1118,"context_line":"            # hosts have not attempted to overwrite allocations"},{"line_number":1119,"context_line":"            # **during the periodic update_available_resource() call**."},{"line_number":1120,"context_line":"            # However, Pike compute hosts may still rework an"},{"line_number":1121,"context_line":"            # allocation for an instance in a move operation during"},{"line_number":1122,"context_line":"            # confirm_resize() on the source host which will remove the"},{"line_number":1123,"context_line":"            # source resource provider from any allocation for an"},{"line_number":1124,"context_line":"            # instance."},{"line_number":1125,"context_line":"            #"},{"line_number":1126,"context_line":"            # In Queens and beyond, the scheduler will understand when"},{"line_number":1127,"context_line":"            # a move operation has been requested and instead of"},{"line_number":1128,"context_line":"            # creating a doubled-up allocation that contains both the"},{"line_number":1129,"context_line":"            # source and destination host, the scheduler will take the"},{"line_number":1130,"context_line":"            # original allocation (against the source host) and change"},{"line_number":1131,"context_line":"            # the consumer ID of that allocation to be the migration"},{"line_number":1132,"context_line":"            # UUID and not the instance UUID. The scheduler will"},{"line_number":1133,"context_line":"            # allocate the resources for the destination host to the"},{"line_number":1134,"context_line":"            # instance UUID."},{"line_number":1135,"context_line":"            LOG.debug(\"We\u0027re on a Pike compute host in a deployment \""},{"line_number":1136,"context_line":"                      \"with all Pike compute hosts. Skipping \""},{"line_number":1137,"context_line":"                      \"auto-correction of allocations.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a576a3a3","line":1134,"range":{"start_line":1112,"start_character":12,"end_line":1134,"end_character":28},"updated":"2017-08-10 15:46:20.000000000","message":"Moving all of this from where it was kind of loses the sense of it.\n\nHow about we leave the logging and comments where they were, but pass a boolean in to _update_usage_from_instance so we only log it once for this loop?","commit_id":"0f168c87ea2a86f66c50ac4eeb203a2552e432ed"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d4968efd92c3edce7e45bf798a26a2798fe1b55b","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"            if has_ocata_computes:"},{"line_number":1042,"context_line":"                # Did we already logged the fact that we auto-corrected"},{"line_number":1043,"context_line":"                # allocations ?"},{"line_number":1044,"context_line":"                if not getattr(self, _logged_once_auto_correction, False):"},{"line_number":1045,"context_line":"                    LOG.debug(\"We\u0027re on a Pike compute host in a deployment \""},{"line_number":1046,"context_line":"                              \"with Ocata compute hosts. Auto-correcting \""},{"line_number":1047,"context_line":"                              \"allocations to handle Ocata-style assumptions.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_5b056c13","line":1044,"updated":"2017-08-27 10:35:53.000000000","message":"this should be a string for \u0027_logged...\u0027 and because you have no direct tests of this, the place where it shows up is an error is in pep8 and a non-obvious failure in an ironic-related functional test\n\nRather than using a tricksy getattr thing, maybe set _logged... to False in __init__?","commit_id":"c73f9eb0c5c63e1d06a8a405d502b19a49e5080d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"31452c0abdbf4e66ca939d914e4d094ca4923abc","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"            if has_ocata_computes:"},{"line_number":1042,"context_line":"                # Did we already logged the fact that we auto-corrected"},{"line_number":1043,"context_line":"                # allocations ?"},{"line_number":1044,"context_line":"                if not getattr(self, _logged_once_auto_correction, False):"},{"line_number":1045,"context_line":"                    LOG.debug(\"We\u0027re on a Pike compute host in a deployment \""},{"line_number":1046,"context_line":"                              \"with Ocata compute hosts. Auto-correcting \""},{"line_number":1047,"context_line":"                              \"allocations to handle Ocata-style assumptions.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_51dd9a12","line":1044,"in_reply_to":"7f287b81_5b056c13","updated":"2017-10-11 09:58:42.000000000","message":"^ what he said - simply initialize it in __init__","commit_id":"c73f9eb0c5c63e1d06a8a405d502b19a49e5080d"}]}