)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b69669aea5569dafc7bf83784e6f3d87400a25b5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-08-14 11:22:55 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add online_data_migrations to nova docs"},{"line_number":8,"context_line":"adding cli documentation for online_data_migrations to clarify"},{"line_number":9,"context_line":"when the command is complete."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If50bd044091250611a7d3d67438d732279510d5b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_b33e77b5","line":8,"updated":"2017-08-29 22:29:22.000000000","message":"You should have a blank line between the title and the description in the commit message, otherwise it\u0027s all one long line in the git history.","commit_id":"2b40c9b02e05a168d71261f92fe742e7426df4e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b69669aea5569dafc7bf83784e6f3d87400a25b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add online_data_migrations to nova docs"},{"line_number":8,"context_line":"adding cli documentation for online_data_migrations to clarify"},{"line_number":9,"context_line":"when the command is complete."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If50bd044091250611a7d3d67438d732279510d5b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_539e33b9","line":10,"updated":"2017-08-29 22:29:22.000000000","message":"You should have this in here:\n\nCloses-Bug: #1670738","commit_id":"2b40c9b02e05a168d71261f92fe742e7426df4e2"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"43afd8094718d0e108abed8eb60485ff2daac218","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    Sync the api cells database up to the most recent version. This is the standard way to create the db as well."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   Performs data migration to update all live data. Returns exit code 0 if"},{"line_number":82,"context_line":"   migrations were successful or exit code 1 if a failure occurred. This"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_1f6e94c8","line":79,"updated":"2017-08-14 09:50:36.000000000","message":"You should put it in Nova Database section or use api_db.","commit_id":"196c34c1844cc3ced9a26dda2c62c69fc544de91"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"43afd8094718d0e108abed8eb60485ff2daac218","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   Performs data migration to update all live data. Returns exit code 0 if"},{"line_number":82,"context_line":"   migrations were successful or exit code 1 if a failure occurred. This"},{"line_number":83,"context_line":"   command should be called after upgrading database schema and nova services on"},{"line_number":84,"context_line":"   all controller nodes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_1f58d4f7","line":81,"range":{"start_line":81,"start_character":52,"end_line":81,"end_character":59},"updated":"2017-08-14 09:50:36.000000000","message":"nit: ditto","commit_id":"196c34c1844cc3ced9a26dda2c62c69fc544de91"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"43afd8094718d0e108abed8eb60485ff2daac218","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   Performs data migration to update all live data. Returns exit code 0 if"},{"line_number":82,"context_line":"   migrations were successful or exit code 1 if a failure occurred. This"},{"line_number":83,"context_line":"   command should be called after upgrading database schema and nova services on"},{"line_number":84,"context_line":"   all controller nodes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_df4c8c43","line":81,"range":{"start_line":81,"start_character":3,"end_line":81,"end_character":11},"updated":"2017-08-14 09:50:36.000000000","message":"nit: s/Performs/Perform/ as the imperative mood is used nearby","commit_id":"196c34c1844cc3ced9a26dda2c62c69fc544de91"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"43afd8094718d0e108abed8eb60485ff2daac218","unresolved":false,"context_lines":[{"line_number":79,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   Performs data migration to update all live data. Returns exit code 0 if"},{"line_number":82,"context_line":"   migrations were successful or exit code 1 if a failure occurred. This"},{"line_number":83,"context_line":"   command should be called after upgrading database schema and nova services on"},{"line_number":84,"context_line":"   all controller nodes."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_1f821401","line":82,"range":{"start_line":82,"start_character":33,"end_line":82,"end_character":44},"updated":"2017-08-14 09:50:36.000000000","message":"1 is returned for a partial update and you have to re-run it again.","commit_id":"196c34c1844cc3ced9a26dda2c62c69fc544de91"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b69669aea5569dafc7bf83784e6f3d87400a25b5","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    Lists and optionally deletes database records where instance_uuid is NULL."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Perform data migration to update all live data. Return exit code 0 if"},{"line_number":71,"context_line":"   migrations were successful or exit code 1 for partial updates. This"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_13a42b07","line":68,"updated":"2017-08-29 22:29:22.000000000","message":"Should have the [--max-count] option in this and a description of the option below.","commit_id":"2b40c9b02e05a168d71261f92fe742e7426df4e2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4046b26e2565950c6fed4c08f247bc886ba9cb1","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``nova-manage db online_data_migrations``"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Perform data migration to update all live data. Return exit code 0 if"},{"line_number":71,"context_line":"   migrations were successful or exit code 1 for partial updates. This"},{"line_number":72,"context_line":"   command should be called after upgrading database schema and nova services on"},{"line_number":73,"context_line":"   all controller nodes. If the command exits with partial updates (exit code 1) the"},{"line_number":74,"context_line":"   command will need to be called again."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Nova API Database"},{"line_number":77,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_1fe62c18","line":74,"range":{"start_line":70,"start_character":0,"end_line":74,"end_character":40},"updated":"2017-08-22 16:08:35.000000000","message":"This needs to be wrapped at 80 characters, but this isn\u0027t done consistently in this file so I can let it slide","commit_id":"2b40c9b02e05a168d71261f92fe742e7426df4e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a2021757bb047bad2dd79124a45da65ee4f792d9","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Perform data migration to update all live data. Return exit code 0 if"},{"line_number":71,"context_line":"   migrations were successful or exit code 1 for partial updates. This command"},{"line_number":72,"context_line":"   should be called after upgrading database schema and nova services on all"},{"line_number":73,"context_line":"   controller nodes. If the command exits with partial updates (exit code 1)"},{"line_number":74,"context_line":"   the command will need to be called again."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"   ``--max-count`` controls the maximum number of objects to migrate in a given"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_3c5b2855","line":73,"range":{"start_line":72,"start_character":52,"end_line":73,"end_character":20},"updated":"2017-09-01 15:47:04.000000000","message":"This conflicts a bit with the upgrade doc here:\n\nhttps://docs.openstack.org/nova/latest/user/upgrade.html#rolling-upgrade-process\n\nWhich says, \"Once all the services are running the latest version of the code, and all the services are aware they all have been upgraded, it is safe to transform the data in the database into its new format.\"\n\nThis is *all* services, including nova-compute.\n\nReally need dansmith to weigh in on this since when to run this is always a question that comes up.","commit_id":"9e1e1a52de48877fd4eb9bcd783e7c187e09a2ab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9fce9304b4cfca6f0e0a1425ecb4c09023338af6","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Perform data migration to update all live data. Return exit code 0 if"},{"line_number":71,"context_line":"   migrations were successful or exit code 1 for partial updates. This command"},{"line_number":72,"context_line":"   should be called after upgrading database schema and nova services on all"},{"line_number":73,"context_line":"   controller nodes. If the command exits with partial updates (exit code 1)"},{"line_number":74,"context_line":"   the command will need to be called again."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"   ``--max-count`` controls the maximum number of objects to migrate in a given"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_f73019eb","line":73,"range":{"start_line":72,"start_character":52,"end_line":73,"end_character":20},"in_reply_to":"7f287b81_3c5b2855","updated":"2017-09-01 15:53:09.000000000","message":"(10:47:16 AM) mriedem: dansmith: can you clarify a question i have in here? https://review.openstack.org/#/c/493442/6\n(10:49:06 AM) dansmith: mriedem: yeah, so really it should be only the controllers, but we had one incident where it wouldn\u0027t complete until all the computes have been upgraded\n(10:49:08 AM) dansmith: mriedem: the pci one\n(10:49:20 AM) dansmith: I was talking to someone recently about this, not sure if it was this person\n(10:49:44 AM) dansmith: I dunno what to say here, because in some cases it\u0027d be one or the other, but almost always just controllers\n(10:51:04 AM) mriedem: in the case of the pci issue,\n(10:51:23 AM) mriedem: did running online_data_migrations break anything? or just not migrate things as expected?\n(10:51:38 AM) dansmith: nope it would just warn you that it couldn\u0027t finish because it needed the computes to be upgraded first\n(10:51:43 AM) mriedem: ah, ok\n(10:52:03 AM) mriedem: so, then i think we leave the ideal case in the man page, and if we have a known weird wrinkle, then we release note that\n(10:52:19 AM) dansmith: sounds good","commit_id":"9e1e1a52de48877fd4eb9bcd783e7c187e09a2ab"}]}