)]}'
{"nova/tests/unit/scheduler/test_utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6be3ff74cbc11528b71ff9073d20cba723aadc37","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 3072,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        utils.merge_resources(resources, new_resources)"},{"line_number":241,"context_line":"        self.assertEqual(doubled, resources)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_b44781bc","line":241,"updated":"2017-08-15 17:50:03.000000000","message":"Can you add something that makes the original go to zero that wasn\u0027t before?","commit_id":"3a45f3bbcc7cdcfb3bc45dcf3145239ce349b0a6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"17be0b6487f339617c8dd4b1b11848088d37f1c9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            \u0027VCPU\u0027: 2, \u0027MEMORY_MB\u0027: 2048, \u0027DISK_GB\u0027: 0,"},{"line_number":235,"context_line":"        }"},{"line_number":236,"context_line":"        # The result should not include the zero valued resource."},{"line_number":237,"context_line":"        doubled \u003d {"},{"line_number":238,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 3072,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        utils.merge_resources(resources, new_resources)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_888447d4","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":15},"updated":"2017-08-16 15:45:24.000000000","message":"Nit: is that a cut and paste error? Might be better if its just called \"expected\"?","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"dc3166e04278e9b4182731008a5b6687f07825b9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            \u0027VCPU\u0027: 2, \u0027MEMORY_MB\u0027: 2048, \u0027DISK_GB\u0027: 0,"},{"line_number":235,"context_line":"        }"},{"line_number":236,"context_line":"        # The result should not include the zero valued resource."},{"line_number":237,"context_line":"        doubled \u003d {"},{"line_number":238,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 3072,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        utils.merge_resources(resources, new_resources)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_c8512f38","line":237,"in_reply_to":"9f436f4f_888447d4","updated":"2017-08-16 15:49:12.000000000","message":"It\u0027s borrowed from the previous test. In both, since merge_resources is using the default sign of 1, the resources are being summed, referred to in various places as \"doubling\".\n\nSo mostly I was maintaining the pattern from the previous test. In the following test I used merged.\n\nIn both cases \"expected\" might be more clear, so happy to change it if you prefer.","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ac0f196a79fc9f286f09f821ddda5c16ef78ab8f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            \u0027VCPU\u0027: 2, \u0027MEMORY_MB\u0027: 2048, \u0027DISK_GB\u0027: 0,"},{"line_number":235,"context_line":"        }"},{"line_number":236,"context_line":"        # The result should not include the zero valued resource."},{"line_number":237,"context_line":"        doubled \u003d {"},{"line_number":238,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 3072,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        utils.merge_resources(resources, new_resources)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_fc74b4ff","line":237,"in_reply_to":"9f436f4f_c8512f38","updated":"2017-08-16 16:16:03.000000000","message":"We\u0027ve been calling this the \"doubled allocation\" even though it\u0027s often not doubled. I\u0027m okay with this as it is, but maybe if we have to rebase this we can/should change for clarity.","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cffddbf6f2ea88d6456ccf191ae5c7eca0b3c444","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_merge_resources_original_zeroes(self):"},{"line_number":244,"context_line":"        \"\"\"Confirm that merging that result in a zero in the original"},{"line_number":245,"context_line":"        excludes the zeroed resource class."},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        resources \u003d {"},{"line_number":248,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 1023, \u0027DISK_GB\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_f0ecd5bb","line":245,"updated":"2017-08-16 18:41:34.000000000","message":"This sentence doesn\u0027t really make sense to me. :P","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"41fa22fd1886ac5fb28db38866a7fdc95efc25b1","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_merge_resources_original_zeroes(self):"},{"line_number":244,"context_line":"        \"\"\"Confirm that merging that result in a zero in the original"},{"line_number":245,"context_line":"        excludes the zeroed resource class."},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        resources \u003d {"},{"line_number":248,"context_line":"            \u0027VCPU\u0027: 3, \u0027MEMORY_MB\u0027: 1023, \u0027DISK_GB\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_865af37f","line":245,"in_reply_to":"9f436f4f_f0ecd5bb","updated":"2017-08-16 20:02:19.000000000","message":"hmm yeah, that makes no sense at all\n\nI just spent some time reading and being embarrassed and fascinated by: http://ask.metafilter.com/110657/Why-do-I-keep-accidently-typing-homonyms-instead-of-the-actual-word-I-meant and http://ask.metafilter.com/102350/Why-am-substituting-one-bird-for-another-when-I-type","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cffddbf6f2ea88d6456ccf191ae5c7eca0b3c444","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            \u0027VCPU\u0027: 2, \u0027MEMORY_MB\u0027: 511,"},{"line_number":255,"context_line":"        }"},{"line_number":256,"context_line":"        utils.merge_resources(resources, new_resources, -1)"},{"line_number":257,"context_line":"        self.assertEqual(merged, resources)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_d01671a8","line":257,"updated":"2017-08-16 18:41:34.000000000","message":"So this is verifying that a merge using subtraction should remove results that are 0.","commit_id":"7c463e2e761ae545bdc86576c2bba537c8cfc27e"}]}