)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"61ab1a750c43a1d3fbda97916bfbaad3fbff94f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Zhao \u003ckevin.zhao@arm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-25 14:55:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the test case of get_disk_mapping_rescue_with_config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1711093"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_51a7af50","line":7,"updated":"2017-08-25 08:07:47.000000000","message":"Can you be more explicit about why you are updating the test which its to make it supports different arch.","commit_id":"2363bbb0aa87227acccb9b91f547ff60e839b0dd"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"61ab1a750c43a1d3fbda97916bfbaad3fbff94f9","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        expect_map \u003d {\u0027aarch64\u0027: expect_disk_config_rescue_aarch64}"},{"line_number":261,"context_line":"        expect_disk_config_rescue \u003d \\"},{"line_number":262,"context_line":"            expect_map.get(blockinfo.libvirt_utils.get_arch({}),"},{"line_number":263,"context_line":"                           expect_disk_config_rescue_default)"},{"line_number":264,"context_line":"        expect \u003d {"},{"line_number":265,"context_line":"            \u0027disk.rescue\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":266,"context_line":"                            \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f1b8db76","line":263,"updated":"2017-08-25 08:07:47.000000000","message":"I would have just changed the formatting to avoid the backslashes. \n\n  expect_disk_config_rescue_default \u003d {\n      \u0027bus\u0027: \u0027ide\u0027, \u0027dev\u0027: \u0027hda\u0027, type\u0027: \u0027cdrom\u0027}\n  expect_disk_config_rescue_aarch64 \u003d {\n      \u0027bus\u0027: \u0027scsi\u0027, \u0027dev\u0027: \u0027sda\u0027, \u0027type\u0027: \u0027cdrom\u0027}\n  expect_map \u003d {\u0027aarch64\u0027: expect_disk_config_rescue_aarch64}\n  \n  expect_disk_config_rescue \u003d expect_map.get(\n      blockinfo.libvirt_utils.get_arch({}),\n      expect_disk_config_rescue_default)","commit_id":"2363bbb0aa87227acccb9b91f547ff60e839b0dd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"42296a2bcd49841c7481c3df635cbbbd7ff44db8","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                                             image_meta,"},{"line_number":254,"context_line":"                                             rescue\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        expect_disk_config_rescue_default \u003d {"},{"line_number":257,"context_line":"            \u0027bus\u0027: \u0027ide\u0027, \u0027dev\u0027: \u0027hda\u0027, \u0027type\u0027: \u0027cdrom\u0027}"},{"line_number":258,"context_line":"        expect_disk_config_rescue_aarch64 \u003d {"},{"line_number":259,"context_line":"            \u0027bus\u0027: \u0027scsi\u0027, \u0027dev\u0027: \u0027sda\u0027, \u0027type\u0027: \u0027cdrom\u0027}"},{"line_number":260,"context_line":"        expect_map \u003d {\u0027aarch64\u0027: expect_disk_config_rescue_aarch64}"},{"line_number":261,"context_line":"        expect_disk_config_rescue \u003d expect_map.get("},{"line_number":262,"context_line":"            blockinfo.libvirt_utils.get_arch({}),"},{"line_number":263,"context_line":"            expect_disk_config_rescue_default)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        expect \u003d {"},{"line_number":266,"context_line":"            \u0027disk.rescue\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_7d59e98b","line":263,"range":{"start_line":256,"start_character":0,"end_line":263,"end_character":46},"updated":"2018-01-09 09:53:13.000000000","message":"This overengineered\n\n    expect_disk_config_rescue \u003d {\u0027bus\u0027: ...}\n    if blockinfo.libvirt_utils.get_arch({}):\n        expect_disk_config_rescue[\u0027bus\u0027] \u003d \u0027scsi\u0027\n\n(meta: ...and this is bikeshedding, I know)","commit_id":"5a377c45edb3cc6d894f1fafa6fe858c2aaa8a6c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"ceac5e5305ff4b858250a84af089be7ab5d8f145","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                                             image_meta,"},{"line_number":254,"context_line":"                                             rescue\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        expect_disk_config_rescue_default \u003d {"},{"line_number":257,"context_line":"            \u0027bus\u0027: \u0027ide\u0027, \u0027dev\u0027: \u0027hda\u0027, \u0027type\u0027: \u0027cdrom\u0027}"},{"line_number":258,"context_line":"        expect_disk_config_rescue_aarch64 \u003d {"},{"line_number":259,"context_line":"            \u0027bus\u0027: \u0027scsi\u0027, \u0027dev\u0027: \u0027sda\u0027, \u0027type\u0027: \u0027cdrom\u0027}"},{"line_number":260,"context_line":"        expect_map \u003d {\u0027aarch64\u0027: expect_disk_config_rescue_aarch64}"},{"line_number":261,"context_line":"        expect_disk_config_rescue \u003d expect_map.get("},{"line_number":262,"context_line":"            blockinfo.libvirt_utils.get_arch({}),"},{"line_number":263,"context_line":"            expect_disk_config_rescue_default)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        expect \u003d {"},{"line_number":266,"context_line":"            \u0027disk.rescue\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_9cce1961","line":263,"range":{"start_line":256,"start_character":0,"end_line":263,"end_character":46},"in_reply_to":"9f91af0f_7d59e98b","updated":"2018-01-10 02:41:17.000000000","message":"Done","commit_id":"5a377c45edb3cc6d894f1fafa6fe858c2aaa8a6c"}]}