)]}'
{"doc/source/contributor/code-review.rst":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bada41048fc2df8c58bf422eac7479dc9ff82832","unresolved":false,"context_lines":[{"line_number":230,"context_line":"If a new microversion API is added, the following needs to happen:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* A new patch for the microversion API change in python-novaclient side"},{"line_number":233,"context_line":"  should be submitted before the microversion change in Nova is merged."},{"line_number":234,"context_line":"* If the microversion changes the response schema, a new schema and test for"},{"line_number":235,"context_line":"  the microversion must be added to Tempest. The microversion change in Nova"},{"line_number":236,"context_line":"  should not be merged until the Tempest test is submitted and at least"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_93b6c089","line":233,"updated":"2017-08-16 11:45:59.000000000","message":"Let\u0027s require to attach a change-id(just change-id without depends-on tag) of novaclient\u0027s change, it will simplify the work of reviewer.","commit_id":"fe933acfc861f9300c5fcfae97fdb4b46b78b9e5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd11d7dbeb9c2d18137d3446bc9f8d03045243fa","unresolved":false,"context_lines":[{"line_number":230,"context_line":"If a new microversion API is added, the following needs to happen:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* A new patch for the microversion API change in python-novaclient side"},{"line_number":233,"context_line":"  should be submitted before the microversion change in Nova is merged."},{"line_number":234,"context_line":"* If the microversion changes the response schema, a new schema and test for"},{"line_number":235,"context_line":"  the microversion must be added to Tempest. The microversion change in Nova"},{"line_number":236,"context_line":"  should not be merged until the Tempest test is submitted and at least"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_df27a2c6","line":233,"in_reply_to":"9f436f4f_93b6c089","updated":"2017-08-16 16:58:48.000000000","message":"I have a small concern about this.\nOn Nova side, microversions patches seem a race for merging. If losing we need to rebase again and again.\nWith this requirement, microversions process will require more steps for merging and we will need to rebase patches of Nova, Tempest and novaclient for a single microversion patch.\n\nI think Natsume-san is facing such difficult situation now, so is it OK for you to add more step? (I have a concern like some guy will -1 on Nova patch due to less-rebasing on the corresponding novaclient side and it will make the process slow more)","commit_id":"fe933acfc861f9300c5fcfae97fdb4b46b78b9e5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3cd162b8dad581c101937667f1843ee9852a1c62","unresolved":false,"context_lines":[{"line_number":230,"context_line":"If a new microversion API is added, the following needs to happen:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* A new patch for the microversion API change in python-novaclient side"},{"line_number":233,"context_line":"  should be submitted before the microversion change in Nova is merged."},{"line_number":234,"context_line":"* If the microversion changes the response schema, a new schema and test for"},{"line_number":235,"context_line":"  the microversion must be added to Tempest. The microversion change in Nova"},{"line_number":236,"context_line":"  should not be merged until the Tempest test is submitted and at least"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_cee4763f","line":233,"in_reply_to":"9f436f4f_98e91ee4","updated":"2017-08-17 18:47:51.000000000","message":"Hi Andrey,\n\n \u003e  It is ok if a patch is unfinished or require rebase.\n\nYeah, that is I think/hope.\nThis rst is for code-review as the filename. So how about adding\n\n Please don\u0027t put -1 on a python-novaclient patch only if\n the patch doesn\u0027t follow the latest microversion on the\n development to avoid developers\u0027 burden.\n\nor something.","commit_id":"fe933acfc861f9300c5fcfae97fdb4b46b78b9e5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5a837e2ce9f4b3a3fcc41483ab534f8e267b47dd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"If a new microversion API is added, the following needs to happen:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* A new patch for the microversion API change in python-novaclient side"},{"line_number":233,"context_line":"  should be submitted before the microversion change in Nova is merged."},{"line_number":234,"context_line":"* If the microversion changes the response schema, a new schema and test for"},{"line_number":235,"context_line":"  the microversion must be added to Tempest. The microversion change in Nova"},{"line_number":236,"context_line":"  should not be merged until the Tempest test is submitted and at least"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_98e91ee4","line":233,"in_reply_to":"9f436f4f_df27a2c6","updated":"2017-08-17 11:03:27.000000000","message":"@Ken\u0027ichi: It is ok if a patch is unfinished or require rebase. It is much better to have at least something. The current situation is like everyone does not care about novaclient\u0027s side at all(sorry, but it relates to some nova\u0027s cores too). Just a few folks are exceptions. If this statement is wrong, the change would not be proposed.","commit_id":"fe933acfc861f9300c5fcfae97fdb4b46b78b9e5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f9ae0102918ae67e9752cd0d62707d91ac279421","unresolved":false,"context_lines":[{"line_number":230,"context_line":"If a new microversion API is added, the following needs to happen:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* A new patch for the microversion API change in python-novaclient side"},{"line_number":233,"context_line":"  should be submitted before the microversion change in Nova is merged."},{"line_number":234,"context_line":"* If the microversion changes the response schema, a new schema and test for"},{"line_number":235,"context_line":"  the microversion must be added to Tempest. The microversion change in Nova"},{"line_number":236,"context_line":"  should not be merged until the Tempest test is submitted and at least"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f436f4f_9430d4a0","line":233,"in_reply_to":"9f436f4f_df27a2c6","updated":"2017-08-17 03:38:31.000000000","message":"if it\u0027s just *submit* a patch, can a WIP be there so we will forget it and you might find a N-1 version ongoing patch and depends on it ?","commit_id":"fe933acfc861f9300c5fcfae97fdb4b46b78b9e5"}]}