)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"7681db9ddad76e625fdc44021c5a66a5ebe7a344","unresolved":false,"context_lines":[{"line_number":10,"context_line":"doing rebuild or evacuate, there is a window the instance can become"},{"line_number":11,"context_line":"ACTIVE but the host is still the old one before rebuild or"},{"line_number":12,"context_line":"evacuate action , this can lead to potential issue if"},{"line_number":13,"context_line":"following actions submitted to nova api. nova api might"},{"line_number":14,"context_line":"accept the request and because instance state already"},{"line_number":15,"context_line":"ACTIVE, it is able to take actions but the instance.host is"},{"line_number":16,"context_line":"incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa0c359_662c9f47","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2018-02-05 07:16:47.000000000","message":"a following","commit_id":"9314717e7b97e0f86ae9c9d83803fd472d6dfc17"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"685ddae9c51be3f8258881ecd8f2587ad52377e9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"doing rebuild or evacuate, there is a window the instance can become"},{"line_number":11,"context_line":"ACTIVE but the host is still the old one before rebuild or"},{"line_number":12,"context_line":"evacuate action , this can lead to potential issue if"},{"line_number":13,"context_line":"following actions submitted to nova api. nova api might"},{"line_number":14,"context_line":"accept the request and because instance state already"},{"line_number":15,"context_line":"ACTIVE, it is able to take actions but the instance.host is"},{"line_number":16,"context_line":"incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa0c359_1c0f2a2f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"3fa0c359_662c9f47","updated":"2018-02-05 08:35:09.000000000","message":"Done","commit_id":"9314717e7b97e0f86ae9c9d83803fd472d6dfc17"}],"nova/compute/manager.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"7681db9ddad76e625fdc44021c5a66a5ebe7a344","unresolved":false,"context_lines":[{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        instance.apply_migration_context()"},{"line_number":3075,"context_line":"        instance.host \u003d self.host"},{"line_number":3076,"context_line":"        instance.node \u003d schedule_node"},{"line_number":3077,"context_line":"        instance.drop_migration_context()"},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        self._update_instance_after_spawn(context, instance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa0c359_66e1fffe","line":3076,"range":{"start_line":3076,"start_character":24,"end_line":3076,"end_character":37},"updated":"2018-02-05 07:16:47.000000000","message":"typo scheduled_node","commit_id":"9314717e7b97e0f86ae9c9d83803fd472d6dfc17"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"685ddae9c51be3f8258881ecd8f2587ad52377e9","unresolved":false,"context_lines":[{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        instance.apply_migration_context()"},{"line_number":3075,"context_line":"        instance.host \u003d self.host"},{"line_number":3076,"context_line":"        instance.node \u003d schedule_node"},{"line_number":3077,"context_line":"        instance.drop_migration_context()"},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        self._update_instance_after_spawn(context, instance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa0c359_5c0db235","line":3076,"range":{"start_line":3076,"start_character":24,"end_line":3076,"end_character":37},"in_reply_to":"3fa0c359_66e1fffe","updated":"2018-02-05 08:35:09.000000000","message":"Done","commit_id":"9314717e7b97e0f86ae9c9d83803fd472d6dfc17"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bcd577a795f7155a51776a8f3128c668d4d31e1f","unresolved":false,"context_lines":[{"line_number":2939,"context_line":"                raise"},{"line_number":2940,"context_line":"            else:"},{"line_number":2941,"context_line":"                instance.apply_migration_context()"},{"line_number":2942,"context_line":"                # NOTE (ndipanov): This save will now update the host and node"},{"line_number":2943,"context_line":"                # attributes making sure that next RT pass is consistent since"},{"line_number":2944,"context_line":"                # it will be based on the instance and not the migration DB"},{"line_number":2945,"context_line":"                # entry."},{"line_number":2946,"context_line":"                instance.host \u003d self.host"},{"line_number":2947,"context_line":"                instance.node \u003d scheduled_node"},{"line_number":2948,"context_line":"                instance.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_9936dfdf","side":"PARENT","line":2945,"range":{"start_line":2942,"start_character":16,"end_line":2945,"end_character":24},"updated":"2018-08-03 16:04:10.000000000","message":"Why drop this note?","commit_id":"86c74e4319a804468fe706c045709ee8b7e1bad2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bcd577a795f7155a51776a8f3128c668d4d31e1f","unresolved":false,"context_lines":[{"line_number":2938,"context_line":"                self._notify_instance_rebuild_error(context, instance, e, bdms)"},{"line_number":2939,"context_line":"                raise"},{"line_number":2940,"context_line":"            else:"},{"line_number":2941,"context_line":"                # NOTE (ndipanov): Mark the migration as done only after we"},{"line_number":2942,"context_line":"                # mark the instance as belonging to this host."},{"line_number":2943,"context_line":"                self._set_migration_status(migration, \u0027done\u0027)"},{"line_number":2944,"context_line":""},{"line_number":2945,"context_line":"    def _do_rebuild_instance_with_claim(self, claim_context, *args, **kwargs):"},{"line_number":2946,"context_line":"        \"\"\"Helper to avoid deep nesting in the top-level method.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_39430b43","line":2943,"range":{"start_line":2941,"start_character":16,"end_line":2943,"end_character":61},"updated":"2018-08-03 16:04:10.000000000","message":"This is a bit confusing now because the context about updating the instance.host has moved to another method.","commit_id":"da6ea12d585416be05414fa7874797e77658ad3b"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"a019d9dada021a0603c180f6e2bd1ac92dbe6749","unresolved":false,"context_lines":[{"line_number":3809,"context_line":""},{"line_number":3810,"context_line":"            def _mock_rebuild(*args, **kargs):"},{"line_number":3811,"context_line":"                instance.node \u003d \u0027new-node\u0027"},{"line_number":3812,"context_line":"            "},{"line_number":3813,"context_line":"            mock_rebuild.side_effect \u003d _mock_rebuild"},{"line_number":3814,"context_line":""},{"line_number":3815,"context_line":"            self.compute.rebuild_instance(self.context, instance, None, None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_e3ee5a20","line":3812,"range":{"start_line":3812,"start_character":0,"end_line":3812,"end_character":12},"updated":"2017-10-26 09:12:38.000000000","message":"white space","commit_id":"c8939a1c8fa2c77642cbbe78d4b58b3ddae34d22"},{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"7def165cb53aa4bbb2138f9d980ba2473da71dde","unresolved":false,"context_lines":[{"line_number":3809,"context_line":""},{"line_number":3810,"context_line":"            def _mock_rebuild(*args, **kargs):"},{"line_number":3811,"context_line":"                instance.node \u003d \u0027new-node\u0027"},{"line_number":3812,"context_line":"            "},{"line_number":3813,"context_line":"            mock_rebuild.side_effect \u003d _mock_rebuild"},{"line_number":3814,"context_line":""},{"line_number":3815,"context_line":"            self.compute.rebuild_instance(self.context, instance, None, None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa0c359_9289e127","line":3812,"range":{"start_line":3812,"start_character":0,"end_line":3812,"end_character":12},"in_reply_to":"3f4b6375_e3ee5a20","updated":"2018-02-05 10:05:09.000000000","message":"white space","commit_id":"c8939a1c8fa2c77642cbbe78d4b58b3ddae34d22"}]}
