)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"90ee944b4b07d9c8fe7d4441eaca1b01932f38ce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"error \u0027unable to find iscsi targets\u0027 because the underlying"},{"line_number":11,"context_line":"retrieval api was updated to a newer version but not it\u0027s usage in"},{"line_number":12,"context_line":"volume_util (see commit e331287cdd1300878bfb9bbb3630889370e5fa72)."},{"line_number":13,"context_line":"This is a regression over Grizzly release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixes: bug #1193980"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATH%2F%2FlmM%3D","line":13,"updated":"2013-10-14 07:24:44.000000000","message":"This really isn\u0027t a very helpful commit message\n\n\"updated to a newer version in I894d9698461b0ce22b01211fd196f6c32899a8fd\" ... well, I894d9698461b0ce22b01211fd196f6c32899a8fd is huge and it\u0027s not clear at all why the changes in that commit require the change in this patch","commit_id":"e70211ff89785fed6a868eaab723847833590502"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"36faa49953073be80339f8b3e538aece34684362","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        volume_util.find_st(mox.IgnoreArg(), connection_info[\u0027data\u0027],"},{"line_number":905,"context_line":"                            mox.IgnoreArg()).AndReturn((None, None))"},{"line_number":906,"context_line":"        # rescan gets called with target portal"},{"line_number":907,"context_line":"        volume_util.rescan_iscsi_hba(self.conn._session, None,"},{"line_number":908,"context_line":"            connection_info[\u0027data\u0027][\u0027target_portal\u0027])"},{"line_number":909,"context_line":"        # simulate target found"},{"line_number":910,"context_line":"        volume_util.find_st(mox.IgnoreArg(), connection_info[\u0027data\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FKP0%3D","line":907,"updated":"2013-10-03 08:01:17.000000000","message":"How about StubOutWithMock this call as well, and verify that the last param is called with connection_info[\u0027data\u0027][\u0027target_portal\u0027]?","commit_id":"6be63550c1e6b5d579f82e3e1222f55ff4132380"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"441d8b22509dfda94d3a9599ecfc29dac9083545","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        volume_util.find_st(mox.IgnoreArg(), connection_info[\u0027data\u0027],"},{"line_number":905,"context_line":"                            mox.IgnoreArg()).AndReturn((None, None))"},{"line_number":906,"context_line":"        # rescan gets called with target portal"},{"line_number":907,"context_line":"        volume_util.rescan_iscsi_hba(self.conn._session, None,"},{"line_number":908,"context_line":"            connection_info[\u0027data\u0027][\u0027target_portal\u0027])"},{"line_number":909,"context_line":"        # simulate target found"},{"line_number":910,"context_line":"        volume_util.find_st(mox.IgnoreArg(), connection_info[\u0027data\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FG9A%3D","line":907,"in_reply_to":"AAAAS3%2F%2FKP0%3D","updated":"2013-10-04 08:34:53.000000000","message":"I have added a new test for rescan_iscsi_hba and have stubbed out this call.\n\nBut this has been moved to https://review.openstack.org/#/c/49692/","commit_id":"6be63550c1e6b5d579f82e3e1222f55ff4132380"}],"nova/virt/vmwareapi/volume_util.py":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"36faa49953073be80339f8b3e538aece34684362","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        send_tgt \u003d client_factory.create(\u0027ns0:HostInternetScsiHbaSendTarget\u0027)"},{"line_number":161,"context_line":"        (send_tgt.address, send_tgt.port) \u003d target_portal.split(\u0027:\u0027)"},{"line_number":162,"context_line":"        LOG.debug(_(\"Adding iSCSI host %s to send targets\") % send_tgt.address)"},{"line_number":163,"context_line":"        session._call_method(session._get_vim(), \"AddInternetScsiSendTargets\","},{"line_number":164,"context_line":"            storage_system_mor, iScsiHbaDevice\u003dhba_device, targets\u003d[send_tgt])"},{"line_number":165,"context_line":"    LOG.debug(_(\"Rescanning HBA %s\") % hba_device)"},{"line_number":166,"context_line":"    session._call_method(session._get_vim(), \"RescanHba\", storage_system_mor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FKRk%3D","line":163,"updated":"2013-10-03 08:01:17.000000000","message":"Doing a rescan every time we cannot find a matching target seems excessive, but that\u0027s existing behavior that is best retained, I suppose. Adding the same sendtarget multiple times probably cause the server to use more resources without any additional benefit, so maybe check against the HBA\u0027s sendtarget list before adding?","commit_id":"6be63550c1e6b5d579f82e3e1222f55ff4132380"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"441d8b22509dfda94d3a9599ecfc29dac9083545","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        send_tgt \u003d client_factory.create(\u0027ns0:HostInternetScsiHbaSendTarget\u0027)"},{"line_number":161,"context_line":"        (send_tgt.address, send_tgt.port) \u003d target_portal.split(\u0027:\u0027)"},{"line_number":162,"context_line":"        LOG.debug(_(\"Adding iSCSI host %s to send targets\") % send_tgt.address)"},{"line_number":163,"context_line":"        session._call_method(session._get_vim(), \"AddInternetScsiSendTargets\","},{"line_number":164,"context_line":"            storage_system_mor, iScsiHbaDevice\u003dhba_device, targets\u003d[send_tgt])"},{"line_number":165,"context_line":"    LOG.debug(_(\"Rescanning HBA %s\") % hba_device)"},{"line_number":166,"context_line":"    session._call_method(session._get_vim(), \"RescanHba\", storage_system_mor,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FIrU%3D","line":163,"in_reply_to":"AAAAS3%2F%2FKRk%3D","updated":"2013-10-04 08:34:53.000000000","message":"Moved to https://review.openstack.org/#/c/49692/ \n\nI now check the configured target before adding. See the above review.","commit_id":"6be63550c1e6b5d579f82e3e1222f55ff4132380"}]}