)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add functional livemigrate test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Livemigration ow seems to be failing, as after the movement of the VM,"},{"line_number":10,"context_line":"the allocations are only presenet on the source host, and not on the"},{"line_number":11,"context_line":"destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_eb92754b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2017-08-18 11:24:58.000000000","message":"Let\u0027s mention that this test covers the live migration with force:True set","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add functional livemigrate test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Livemigration ow seems to be failing, as after the movement of the VM,"},{"line_number":10,"context_line":"the allocations are only presenet on the source host, and not on the"},{"line_number":11,"context_line":"destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_4b762141","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":16},"updated":"2017-08-18 11:24:58.000000000","message":"nit:now","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87c6f5220e75efe0997dc85a597637f6cac410cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add functional livemigrate test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Livemigration ow seems to be failing, as after the movement of the VM,"},{"line_number":10,"context_line":"the allocations are only presenet on the source host, and not on the"},{"line_number":11,"context_line":"destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_34f2159c","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":16},"in_reply_to":"9f436f4f_4b762141","updated":"2017-08-18 14:29:31.000000000","message":"Done","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87c6f5220e75efe0997dc85a597637f6cac410cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add functional livemigrate test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Livemigration ow seems to be failing, as after the movement of the VM,"},{"line_number":10,"context_line":"the allocations are only presenet on the source host, and not on the"},{"line_number":11,"context_line":"destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_74541d55","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"9f436f4f_eb92754b","updated":"2017-08-18 14:29:31.000000000","message":"I added the case without force to have both.\nThe strange that the 2 works differently:\n- force case: there are no allocations on the destination host, but the allocations remain on the source host.\n- without force case: there are allocations on both the source and destination hosts.","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"},{"line_number":13,"context_line":"make the test pass."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6856f57426db6f2f49daea86679b50d5d019fe19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_ab9c6d5d","line":14,"updated":"2017-08-18 11:24:58.000000000","message":"I suggest to file a bug for this and add a Related-Bug to the commit message","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add functional force live migrate test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Forced live migration now seems to be failing, as after the movement of"},{"line_number":10,"context_line":"the VM, the allocations are only presenet on the source host, and not on"},{"line_number":11,"context_line":"the destination host."},{"line_number":12,"context_line":"The related assertions are commented out and replaced with wrong ones to"},{"line_number":13,"context_line":"make the test pass."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_f83a0ec2","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":41},"updated":"2017-08-21 18:37:42.000000000","message":"present","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"            \u0027os-migrateLive\u0027: {"},{"line_number":1316,"context_line":"                \u0027host\u0027: host,"},{"line_number":1317,"context_line":"                \u0027block_migration\u0027: True,"},{"line_number":1318,"context_line":"                \u0027force\u0027: True,"},{"line_number":1319,"context_line":"            }"},{"line_number":1320,"context_line":"        }"},{"line_number":1321,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_4b9d0165","line":1318,"updated":"2017-08-18 11:24:58.000000000","message":"The meaning of force from the doc: Force a live-migration by not verifying the provided destination host by the scheduler.\n\nStill I think this should not result in a missing allocation on the destination host. So I agree that there is a bug.","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87c6f5220e75efe0997dc85a597637f6cac410cd","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"            \u0027os-migrateLive\u0027: {"},{"line_number":1316,"context_line":"                \u0027host\u0027: host,"},{"line_number":1317,"context_line":"                \u0027block_migration\u0027: True,"},{"line_number":1318,"context_line":"                \u0027force\u0027: True,"},{"line_number":1319,"context_line":"            }"},{"line_number":1320,"context_line":"        }"},{"line_number":1321,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_f4eecd89","line":1318,"in_reply_to":"9f436f4f_4b9d0165","updated":"2017-08-18 14:29:31.000000000","message":"I moved this part of the test code, and have a test with and one without force.","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"            }"},{"line_number":1320,"context_line":"        }"},{"line_number":1321,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"},{"line_number":1322,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1323,"context_line":"        self._wait_for_server_parameter(self.api, server,"},{"line_number":1324,"context_line":"                                        {\u0027OS-EXT-SRV-ATTR:host\u0027: host})"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"        self._run_periodics()"},{"line_number":1327,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_abcfcdae","line":1324,"range":{"start_line":1322,"start_character":0,"end_line":1324,"end_character":71},"updated":"2017-08-18 11:24:58.000000000","message":"you can do that in a single call:\n\nself._wait_for_server_parameter(\n    self.api, server,\n    {\u0027OS-EXT-SRV-ATTR:host\u0027: host,\n     \u0027status\u0027: \u0027ACTIVE\u0027})","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87c6f5220e75efe0997dc85a597637f6cac410cd","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"            }"},{"line_number":1320,"context_line":"        }"},{"line_number":1321,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"},{"line_number":1322,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1323,"context_line":"        self._wait_for_server_parameter(self.api, server,"},{"line_number":1324,"context_line":"                                        {\u0027OS-EXT-SRV-ATTR:host\u0027: host})"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"        self._run_periodics()"},{"line_number":1327,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_344e95c1","line":1324,"range":{"start_line":1322,"start_character":0,"end_line":1324,"end_character":71},"in_reply_to":"9f436f4f_abcfcdae","updated":"2017-08-18 14:29:31.000000000","message":"Done","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d828af2e1c341d92eb292277925309e8185a6e","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"                                                dest_hostname,"},{"line_number":1865,"context_line":"                                                self.flavor1,"},{"line_number":1866,"context_line":"                                                source_rp_uuid,"},{"line_number":1867,"context_line":"                                                dest_rp_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_eb3a7596","line":1867,"updated":"2017-08-18 11:24:58.000000000","message":"let\u0027s delete the instance and assert the allocations as well with the following call:\nself._delete_and_check_allocations(server, source_rp_uuid, source_rp_uuid)","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87c6f5220e75efe0997dc85a597637f6cac410cd","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"                                                dest_hostname,"},{"line_number":1865,"context_line":"                                                self.flavor1,"},{"line_number":1866,"context_line":"                                                source_rp_uuid,"},{"line_number":1867,"context_line":"                                                dest_rp_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_7402dd40","line":1867,"in_reply_to":"9f436f4f_eb3a7596","updated":"2017-08-18 14:29:31.000000000","message":"Done","commit_id":"5bb78e49867be2bed081a688771a4b7835e19014"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f41f24f6b20d9ca9db933635e0a39e8e1ff0ed00","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"        dest_allocation \u003d allocations[dest_rp_uuid][\u0027resources\u0027]"},{"line_number":1310,"context_line":"        self.assertFlavorMatchesAllocation(new_flavor, dest_allocation)"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"    def _live_migrate_and_check_allocations(self, server, req, host, flavor,"},{"line_number":1313,"context_line":"                                            source_rp_uuid, dest_rp_uuid):"},{"line_number":1314,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"},{"line_number":1315,"context_line":"        self._wait_for_server_parameter(self.api, server,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_4921604d","line":1312,"updated":"2017-08-21 09:38:18.000000000","message":"This separate util function only useful if you can use it for the force:False case as well. So let\u0027s see if that is the case or not.","commit_id":"00b43f8434be39148ff0a9f8d1c1b430a43e913d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ce92f8f7290bccdf4bdef5978129a9dc8c0d93f7","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"        dest_allocation \u003d allocations[dest_rp_uuid][\u0027resources\u0027]"},{"line_number":1310,"context_line":"        self.assertFlavorMatchesAllocation(new_flavor, dest_allocation)"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"    def _live_migrate_and_check_allocations(self, server, req, host, flavor,"},{"line_number":1313,"context_line":"                                            source_rp_uuid, dest_rp_uuid):"},{"line_number":1314,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], req)"},{"line_number":1315,"context_line":"        self._wait_for_server_parameter(self.api, server,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_84804f48","line":1312,"in_reply_to":"9f436f4f_4921604d","updated":"2017-08-21 10:06:25.000000000","message":"I moved all the stuff to the test.\nWhen the bug will be fixed we can have one helper to do all the checks for both case.","commit_id":"00b43f8434be39148ff0a9f8d1c1b430a43e913d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"        self.addCleanup(nova.tests.unit.image.fake.FakeImageService_reset)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"        fake.set_nodes([\u0027host1\u0027])"},{"line_number":1108,"context_line":"        self.useFixture(nova_fixtures.ConfPatcher(host\u003d\u0027host1\u0027))"},{"line_number":1109,"context_line":"        self.compute1 \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027host1\u0027)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"        # NOTE(sbauza): Make sure the FakeDriver returns a different nodename"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_b85da616","line":1108,"range":{"start_line":1108,"start_character":8,"end_line":1108,"end_character":64},"updated":"2017-08-21 18:37:42.000000000","message":"This seems kind of heavyweight, couldn\u0027t we just do this?\n\nself.flags(host\u003d\u0027host1\u0027)","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1824,"context_line":"        self._run_periodics()"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        source_usages \u003d self._get_provider_usages(source_rp_uuid)"},{"line_number":1827,"context_line":"        # Note(lajos katona): After bug 712008 is solved on the source there"},{"line_number":1828,"context_line":"        # will be no allocations:"},{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_38f536ee","line":1827,"range":{"start_line":1827,"start_character":40,"end_line":1827,"end_character":46},"updated":"2017-08-21 18:37:42.000000000","message":"1712008","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1824,"context_line":"        self._run_periodics()"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        source_usages \u003d self._get_provider_usages(source_rp_uuid)"},{"line_number":1827,"context_line":"        # Note(lajos katona): After bug 712008 is solved on the source there"},{"line_number":1828,"context_line":"        # will be no allocations:"},{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_58f23a08","line":1827,"range":{"start_line":1827,"start_character":10,"end_line":1827,"end_character":14},"updated":"2017-08-21 18:37:42.000000000","message":"NOTE","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e243956368218ce6bc10d043d49167d9428c5e9b","unresolved":false,"context_lines":[{"line_number":1824,"context_line":"        self._run_periodics()"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        source_usages \u003d self._get_provider_usages(source_rp_uuid)"},{"line_number":1827,"context_line":"        # Note(lajos katona): After bug 712008 is solved on the source there"},{"line_number":1828,"context_line":"        # will be no allocations:"},{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_91fe3d03","line":1827,"range":{"start_line":1827,"start_character":10,"end_line":1827,"end_character":14},"in_reply_to":"9f436f4f_58f23a08","updated":"2017-08-21 20:34:36.000000000","message":"This is actually bug 1712045 I think.","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        source_usages \u003d self._get_provider_usages(source_rp_uuid)"},{"line_number":1827,"context_line":"        # Note(lajos katona): After bug 712008 is solved on the source there"},{"line_number":1828,"context_line":"        # will be no allocations:"},{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # Note(lajos katona): till bug 1712008 is not solved on the source"},{"line_number":1833,"context_line":"        # host the allocations are remaining:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_f8444e1b","line":1830,"range":{"start_line":1829,"start_character":10,"end_line":1830,"end_character":63},"updated":"2017-08-21 18:37:42.000000000","message":"I guess this works. Another way this is done is like this in the _delete_and_check_allocations method:\n\nself.assertEqual({\u0027VCPU\u0027: 0,\n                  \u0027MEMORY_MB\u0027: 0,\n                  \u0027DISK_GB\u0027: 0}, source_usages)","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e243956368218ce6bc10d043d49167d9428c5e9b","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # Note(lajos katona): till bug 1712008 is not solved on the source"},{"line_number":1833,"context_line":"        # host the allocations are remaining:"},{"line_number":1834,"context_line":"        # on the original host should not have the old resource usage"},{"line_number":1835,"context_line":"        self.assertFlavorMatchesAllocation(self.flavor1, source_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_160da33d","line":1832,"range":{"start_line":1832,"start_character":39,"end_line":1832,"end_character":46},"updated":"2017-08-21 20:34:36.000000000","message":"I think this is bug 1712045, right? Different issue.","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":1830,"context_line":"        #     {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, source_usages)"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        # Note(lajos katona): till bug 1712008 is not solved on the source"},{"line_number":1833,"context_line":"        # host the allocations are remaining:"},{"line_number":1834,"context_line":"        # on the original host should not have the old resource usage"},{"line_number":1835,"context_line":"        self.assertFlavorMatchesAllocation(self.flavor1, source_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_b8e00628","line":1832,"range":{"start_line":1832,"start_character":10,"end_line":1832,"end_character":14},"updated":"2017-08-21 18:37:42.000000000","message":"NOTE","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        self.assertFlavorMatchesAllocation(self.flavor1, source_usages)"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        dest_usages \u003d self._get_provider_usages(dest_rp_uuid)"},{"line_number":1838,"context_line":"        # Note(lajos katona): When bug 1712008 is solved the dest host"},{"line_number":1839,"context_line":"        # expected to have resource allocation based on the new flavor"},{"line_number":1840,"context_line":"        # the server is resized to:"},{"line_number":1841,"context_line":"        # self.assertFlavorMatchesAllocation(flavor, dest_usages)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_982d4248","line":1838,"range":{"start_line":1838,"start_character":10,"end_line":1838,"end_character":14},"updated":"2017-08-21 18:37:42.000000000","message":"NOTE","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        dest_usages \u003d self._get_provider_usages(dest_rp_uuid)"},{"line_number":1838,"context_line":"        # Note(lajos katona): When bug 1712008 is solved the dest host"},{"line_number":1839,"context_line":"        # expected to have resource allocation based on the new flavor"},{"line_number":1840,"context_line":"        # the server is resized to:"},{"line_number":1841,"context_line":"        # self.assertFlavorMatchesAllocation(flavor, dest_usages)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"        # Note(lajos katona): the allocation on the destination host is empty,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_38df763b","line":1840,"range":{"start_line":1839,"start_character":53,"end_line":1840,"end_character":35},"updated":"2017-08-21 18:37:42.000000000","message":"nit: it\u0027s not a new flavor, it\u0027s the existing flavor that the instance was created with, since this isn\u0027t a resize","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"        # the server is resized to:"},{"line_number":1841,"context_line":"        # self.assertFlavorMatchesAllocation(flavor, dest_usages)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":"        # Note(lajos katona): the allocation on the destination host is empty,"},{"line_number":1844,"context_line":"        # but when bug 1712008 is solved expected to be equal described by the"},{"line_number":1845,"context_line":"        # flavor:"},{"line_number":1846,"context_line":"        self.assertFlavorMatchesAllocation("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_18cf1280","line":1843,"range":{"start_line":1843,"start_character":10,"end_line":1843,"end_character":14},"updated":"2017-08-21 18:37:42.000000000","message":"NOTE","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e243956368218ce6bc10d043d49167d9428c5e9b","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        # the server has just 1 allocation:"},{"line_number":1851,"context_line":"        self.assertEqual(1, len(allocations))"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        # Note(lajos katona): When bug 1712008 is solved the server has"},{"line_number":1854,"context_line":"        # no allocation on the source:"},{"line_number":1855,"context_line":"        # self.assertNotIn(source_rp_uuid, allocations)"},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_5121f59e","line":1853,"range":{"start_line":1853,"start_character":39,"end_line":1853,"end_character":46},"updated":"2017-08-21 20:34:36.000000000","message":"1712045","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        # the server has just 1 allocation:"},{"line_number":1851,"context_line":"        self.assertEqual(1, len(allocations))"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        # Note(lajos katona): When bug 1712008 is solved the server has"},{"line_number":1854,"context_line":"        # no allocation on the source:"},{"line_number":1855,"context_line":"        # self.assertNotIn(source_rp_uuid, allocations)"},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_58835a05","line":1853,"range":{"start_line":1853,"start_character":10,"end_line":1853,"end_character":14},"updated":"2017-08-21 18:37:42.000000000","message":"NOTE","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2688d0c99b1d6f14adbeb732b44e3ab9918d0a74","unresolved":false,"context_lines":[{"line_number":1861,"context_line":"        # Note(lajos katona): When bug 1712008 solved the server should have"},{"line_number":1862,"context_line":"        # an allocation for the destination:"},{"line_number":1863,"context_line":"        # dest_allocation \u003d allocations[dest_rp_uuid][\u0027resources\u0027]"},{"line_number":1864,"context_line":"        # self.assertFlavorMatchesAllocation(flavor, dest_allocation)"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"        # Instead the server has no allocation for the destination host:"},{"line_number":1867,"context_line":"        self.assertNotIn(dest_rp_uuid, allocations)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_b8980675","line":1864,"range":{"start_line":1864,"start_character":45,"end_line":1864,"end_character":51},"updated":"2017-08-21 18:37:42.000000000","message":"self.flavor1","commit_id":"c26202d3f0e833f4e22a5867ca4fedaa0667c4d9"}]}