)]}'
{"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ac80bc6e6a4cf36ca9600df04ff09650d0ff4c53","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    req.response.body \u003d encodeutils.to_utf8(jsonutils.dumps("},{"line_number":302,"context_line":"        _serialize_provider(req.environ, resource_provider)))"},{"line_number":303,"context_line":"    req.response.status \u003d 200"},{"line_number":304,"context_line":"    req.response.content_type \u003d \u0027application/json\u0027"},{"line_number":305,"context_line":"    return req.response"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f4e5783_883cc0c8","line":304,"range":{"start_line":303,"start_character":4,"end_line":304,"end_character":50},"updated":"2017-10-13 07:36:33.000000000","message":"do we want to change here for PUT return header?","commit_id":"3f6745dd61a5a6bc95af1a8cbc56256633c14a73"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"65841f75a12ffec6f7e2f8427bd1ad366888f129","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    req.response.body \u003d encodeutils.to_utf8(jsonutils.dumps("},{"line_number":302,"context_line":"        _serialize_provider(req.environ, resource_provider)))"},{"line_number":303,"context_line":"    req.response.status \u003d 200"},{"line_number":304,"context_line":"    req.response.content_type \u003d \u0027application/json\u0027"},{"line_number":305,"context_line":"    return req.response"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f4e5783_deef091c","line":304,"range":{"start_line":303,"start_character":4,"end_line":304,"end_character":50},"in_reply_to":"5f4e5783_883cc0c8","updated":"2017-10-13 14:29:05.000000000","message":"yes, good catch, I forgot that this one had a body.","commit_id":"3f6745dd61a5a6bc95af1a8cbc56256633c14a73"}],"nova/api/openstack/placement/util.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"956eeabf8b3272bc1c4b9bb3c8d1e0bc332c0c07","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    return {\u0027errors\u0027: [error_dict]}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def pick_last_modified(last_modified, obj):"},{"line_number":119,"context_line":"    \"\"\"Choose max of last_modified and obj.updated_at or obj.created_at.\"\"\""},{"line_number":120,"context_line":"    current_modified \u003d (obj.updated_at or obj.created_at)"},{"line_number":121,"context_line":"    if last_modified:"},{"line_number":122,"context_line":"        last_modified \u003d max(last_modified, current_modified)"},{"line_number":123,"context_line":"    else:"},{"line_number":124,"context_line":"        last_modified \u003d current_modified"},{"line_number":125,"context_line":"    return last_modified"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"def require_content(content_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f4e5783_14bfd061","line":125,"range":{"start_line":118,"start_character":0,"end_line":125,"end_character":24},"updated":"2017-10-13 07:27:53.000000000","message":"this logic LGTM and do we need some unit test as well?","commit_id":"3f6745dd61a5a6bc95af1a8cbc56256633c14a73"}],"nova/tests/functional/api/openstack/placement/gabbits/resource-provider.yaml":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0399a6925e198e13f15212a6b45b51541cfbfd83","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: what is at resource providers"},{"line_number":13,"context_line":"  GET: /resource_providers"},{"line_number":14,"context_line":"  request_headers:"},{"line_number":15,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":16,"context_line":"  response_json_paths:"},{"line_number":17,"context_line":"      $.resource_providers: []"},{"line_number":18,"context_line":"  response_headers:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_d73f9c84","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":43},"updated":"2017-10-26 06:54:15.000000000","message":"should we add a test for 1.10 as it doesn\u0027t have cache related output?","commit_id":"1dc62c2766e28fb680791c3732e268c944df0756"}]}