)]}'
{"nova/privsep/fs.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9ff965e25aff3e2a65f02d9e9892e5bd43e0714a","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":82,"context_line":"def lvclear(path, volume_size, shred\u003dFalse):"},{"line_number":83,"context_line":"    cmd \u003d [\u0027shred\u0027]"},{"line_number":84,"context_line":"    if shred:"},{"line_number":85,"context_line":"        cmd.extend([\u0027-n3\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_4f14d3a0","line":82,"updated":"2017-10-19 20:08:26.000000000","message":"Why this name? It\u0027s not specific to lvm -- we could use this on image files or other things. If we call it this, aren\u0027t we likely to get another shred() added in here because someone doesn\u0027t realize we already have it? Similarly, it would be weird to do:\n\n  lvclear(\u0027/var/lib/nova/instances/...\u0027)\n\nright?","commit_id":"ec60188765419b9126a32c0e8d7912555b1a4a69"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f3e1425f322774ac9c87f0cb3b14e11e584a26ac","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":82,"context_line":"def lvclear(path, volume_size, shred\u003dFalse):"},{"line_number":83,"context_line":"    cmd \u003d [\u0027shred\u0027]"},{"line_number":84,"context_line":"    if shred:"},{"line_number":85,"context_line":"        cmd.extend([\u0027-n3\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_2a3cb7e0","line":82,"in_reply_to":"3f4b6375_1d783c28","updated":"2017-10-22 21:11:59.000000000","message":"This name is inherited from the old code, I\u0027m happy enough to change it.","commit_id":"ec60188765419b9126a32c0e8d7912555b1a4a69"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6434d074850b9bafcbcbde128c946dc85392bc36","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":82,"context_line":"def lvclear(path, volume_size, shred\u003dFalse):"},{"line_number":83,"context_line":"    cmd \u003d [\u0027shred\u0027]"},{"line_number":84,"context_line":"    if shred:"},{"line_number":85,"context_line":"        cmd.extend([\u0027-n3\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_7c726be5","line":82,"in_reply_to":"3f4b6375_2a3cb7e0","updated":"2017-10-23 13:37:51.000000000","message":"Hmm, only by way of the tests, AFAICT","commit_id":"ec60188765419b9126a32c0e8d7912555b1a4a69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9451b33ab635e0ae582c991aa1ec4603b0ab0f5c","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":82,"context_line":"def lvclear(path, volume_size, shred\u003dFalse):"},{"line_number":83,"context_line":"    cmd \u003d [\u0027shred\u0027]"},{"line_number":84,"context_line":"    if shred:"},{"line_number":85,"context_line":"        cmd.extend([\u0027-n3\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_1d783c28","line":82,"in_reply_to":"3f4b6375_4f14d3a0","updated":"2017-10-20 15:15:30.000000000","message":"I\u0027m guessing so it matches up with the other \u0027lvm\u0027 functions in here? This is only used for lvm modules so it kind of makes sense?","commit_id":"ec60188765419b9126a32c0e8d7912555b1a4a69"}]}