)]}'
{"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"298ac2944334367c950617662822e10e7b5ead13","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"    vm_ref \u003d get_vm_ref(session, instance)"},{"line_number":1154,"context_line":"    vm_state \u003d session._call_method(vutil, \"get_object_property\","},{"line_number":1155,"context_line":"                                    vm_ref, \"runtime.powerState\")"},{"line_number":1156,"context_line":"    return power_state.STATE_MAP[constants.POWER_STATES[vm_state]]"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"def get_stats_from_cluster(session, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_5fde9b11","line":1156,"updated":"2017-08-25 07:01:29.000000000","message":"if you change the return value of this method, then you break the code at here https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/driver.py#L204","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"239d57899f700818efa20551003a1481c29b3921","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"    vm_ref \u003d get_vm_ref(session, instance)"},{"line_number":1154,"context_line":"    vm_state \u003d session._call_method(vutil, \"get_object_property\","},{"line_number":1155,"context_line":"                                    vm_ref, \"runtime.powerState\")"},{"line_number":1156,"context_line":"    return power_state.STATE_MAP[constants.POWER_STATES[vm_state]]"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"def get_stats_from_cluster(session, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_9f776303","line":1156,"in_reply_to":"7f287b81_5fde9b11","updated":"2017-08-25 07:29:06.000000000","message":"Thanks Alex, I will update it.","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"74eaa3a8a5fa3e39f0ef66bda468b4217bb37ad2","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        # IDE does not support disk hotplug"},{"line_number":333,"context_line":"        if adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"},{"line_number":334,"context_line":"            state \u003d vm_util.get_vm_state(self._session, instance)"},{"line_number":335,"context_line":"            if state.lower() !\u003d \u0027shutdown\u0027:"},{"line_number":336,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":337,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_1f9a5362","line":335,"updated":"2017-08-25 06:58:33.000000000","message":"why not just write like \u0027if state !\u003d power_state.SHUTDOWN. Then you needn\u0027t change this https://review.openstack.org/#/c/496140/4/nova/virt/vmwareapi/vm_util.py","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"239d57899f700818efa20551003a1481c29b3921","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        # IDE does not support disk hotplug"},{"line_number":333,"context_line":"        if adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"},{"line_number":334,"context_line":"            state \u003d vm_util.get_vm_state(self._session, instance)"},{"line_number":335,"context_line":"            if state.lower() !\u003d \u0027shutdown\u0027:"},{"line_number":336,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":337,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_3f662f53","line":335,"in_reply_to":"7f287b81_1f9a5362","updated":"2017-08-25 07:29:06.000000000","message":"OK, I will do it.","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"97fe5b0c8e5f040ef176c0416a930060d4eb6dc3","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        # IDE does not support disk hotplug"},{"line_number":533,"context_line":"        if vmdk.adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"},{"line_number":534,"context_line":"            state \u003d vm_util.get_vm_state(self._session, instance)"},{"line_number":535,"context_line":"            if state.lower() !\u003d \u0027shutdown\u0027:"},{"line_number":536,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":537,"context_line":"                                          \u0027hotplug.\u0027) % vmdk.adapter_type)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_bf79ff2f","line":535,"updated":"2017-08-25 06:56:56.000000000","message":"This seems like a functional change that is unrelated to the bug that this patch is supposed to fix. Could you please move these changes into a followup patch or update the bug description so that it is obvious why this particular change was necessary?","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"5b289d10ea65e56b27112f1281ab0105104e3b47","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        # IDE does not support disk hotplug"},{"line_number":533,"context_line":"        if vmdk.adapter_type \u003d\u003d constants.ADAPTER_TYPE_IDE:"},{"line_number":534,"context_line":"            state \u003d vm_util.get_vm_state(self._session, instance)"},{"line_number":535,"context_line":"            if state.lower() !\u003d \u0027shutdown\u0027:"},{"line_number":536,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":537,"context_line":"                                          \u0027hotplug.\u0027) % vmdk.adapter_type)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_711d0b65","line":535,"in_reply_to":"7f287b81_bf79ff2f","updated":"2017-08-25 07:29:47.000000000","message":"Thanks for your review Jay. I will update it.","commit_id":"3d8ee510a851062a0015cc32b37d55bc756deb6c"}]}