)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5eb9644a230094dcf3176248fd872b6dc103d90f","unresolved":false,"context_lines":[{"line_number":3729,"context_line":""},{"line_number":3730,"context_line":"    def test_get_guest_config_with_vnc_no_keymap(self):"},{"line_number":3731,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3732,"context_line":"        self.flags(enabled\u003dTrue, keymap\u003d\u0027\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":3733,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027spice\u0027)"},{"line_number":3734,"context_line":"        devices \u003d self._test_get_guest_config_with_graphics()"},{"line_number":3735,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f2ca0e18","line":3732,"updated":"2017-08-25 15:46:12.000000000","message":"keymap would be set to None in the config if it\u0027s not set right? Also, I don\u0027t see anywhere else in this test file that we validate keymap being set actually sets it on the config object. Am I missing it? If not, I think you better add a positive assertion too. That should have already been tested, but since you\u0027re allowing it to be unset, you should assert that it can _still_ be set if needed.","commit_id":"47c8f9fd48284e75099744bc984d9733e0d31349"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8af0014aa851b7211dbd69260ba9ff9f4c1e4dd8","unresolved":false,"context_lines":[{"line_number":3729,"context_line":""},{"line_number":3730,"context_line":"    def test_get_guest_config_with_vnc_no_keymap(self):"},{"line_number":3731,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3732,"context_line":"        self.flags(enabled\u003dTrue, keymap\u003d\u0027\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":3733,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027spice\u0027)"},{"line_number":3734,"context_line":"        devices \u003d self._test_get_guest_config_with_graphics()"},{"line_number":3735,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f2668e29","line":3732,"in_reply_to":"7f287b81_f2ca0e18","updated":"2017-08-25 15:49:16.000000000","message":"++","commit_id":"47c8f9fd48284e75099744bc984d9733e0d31349"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"792e4f2e0cac9657c8a018e29d97029fa7e6d2a7","unresolved":false,"context_lines":[{"line_number":3750,"context_line":""},{"line_number":3751,"context_line":"    def test_get_guest_config_with_spice_no_keymap(self):"},{"line_number":3752,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3753,"context_line":"        self.flags(enabled\u003dTrue, keymap\u003d\u0027\u0027, group\u003d\u0027spice\u0027)"},{"line_number":3754,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027vnc\u0027)"},{"line_number":3755,"context_line":"        devices \u003d self._test_get_guest_config_with_graphics()"},{"line_number":3756,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_2dc5d75b","line":3753,"range":{"start_line":3753,"start_character":33,"end_line":3753,"end_character":42},"updated":"2017-08-25 16:09:37.000000000","message":"Is there some reason this has to be an empty string instead of None? It\u0027d be none if excluded from the config right?","commit_id":"92d79098cf450ea673df905a77211b5bf1c5d977"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33543762bde1e3c11d379b21873f9c0b472c3a43","unresolved":false,"context_lines":[{"line_number":3750,"context_line":""},{"line_number":3751,"context_line":"    def test_get_guest_config_with_spice_no_keymap(self):"},{"line_number":3752,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3753,"context_line":"        self.flags(enabled\u003dTrue, keymap\u003d\u0027\u0027, group\u003d\u0027spice\u0027)"},{"line_number":3754,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027vnc\u0027)"},{"line_number":3755,"context_line":"        devices \u003d self._test_get_guest_config_with_graphics()"},{"line_number":3756,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_8000f4ac","line":3753,"range":{"start_line":3753,"start_character":33,"end_line":3753,"end_character":42},"in_reply_to":"7f287b81_2dc5d75b","updated":"2017-08-28 08:55:12.000000000","message":"Correct. Fixed","commit_id":"92d79098cf450ea673df905a77211b5bf1c5d977"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4718ff7e6c96357badb1754df09519d342054681","unresolved":false,"context_lines":[{"line_number":4950,"context_line":"        if CONF.vnc.enabled and guest.virt_type not in (\u0027lxc\u0027, \u0027uml\u0027):"},{"line_number":4951,"context_line":"            graphics \u003d vconfig.LibvirtConfigGuestGraphics()"},{"line_number":4952,"context_line":"            graphics.type \u003d \"vnc\""},{"line_number":4953,"context_line":"            if CONF.vnc.keymap:"},{"line_number":4954,"context_line":"                graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4955,"context_line":"                LOG.warning(\u0027The option \"[vnc] keymap\" causes issues for \u0027"},{"line_number":4956,"context_line":"                            \u0027instances using non-en-US keymappings and will \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_67d65ec6","line":4953,"updated":"2017-08-25 15:15:26.000000000","message":"Tests for this?","commit_id":"37c5751f9a896521eb6d69f7ca90e67d316342dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f27d1bd7485eac5ea325263bbd353f22de028e1","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"                graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4955,"context_line":"                LOG.warning(\u0027The option \"[vnc] keymap\" causes issues for \u0027"},{"line_number":4956,"context_line":"                            \u0027instances using non-en-US keymappings and will \u0027"},{"line_number":4957,"context_line":"                            \u0027be deprecated in a future release. Consider \u0027"},{"line_number":4958,"context_line":"                            \u0027unsetting the option now to mitigate these \u0027"},{"line_number":4959,"context_line":"                            \u0027issues. Refer to bug #1682020 for more \u0027"},{"line_number":4960,"context_line":"                            \u0027information.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_e71dae73","line":4957,"updated":"2017-08-25 15:20:55.000000000","message":"We probably should drop the warning here given the feedback on the following deprecation patch. Let\u0027s just let them unset it here and not commit to deprecation until we work out those details.","commit_id":"37c5751f9a896521eb6d69f7ca90e67d316342dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9092834dd361f7fbf64cb43329bb4cd5373b6fd","unresolved":false,"context_lines":[{"line_number":4952,"context_line":"            graphics.type \u003d \"vnc\""},{"line_number":4953,"context_line":"            if CONF.vnc.keymap:"},{"line_number":4954,"context_line":"                # TODO(stephenfin): There are some issues here that may"},{"line_number":4955,"context_line":"                # necessitate deprecating this option entirely in the future."},{"line_number":4956,"context_line":"                # Refer to bug #1682020 for more information."},{"line_number":4957,"context_line":"                graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4958,"context_line":"            graphics.listen \u003d CONF.vnc.vncserver_listen"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_f66e5f2d","line":4955,"range":{"start_line":4955,"start_character":30,"end_line":4955,"end_character":41},"updated":"2017-08-28 12:38:24.000000000","message":"+1 to deprecate.","commit_id":"d983234288728427235ef2c1f355ec135119b865"}]}