)]}'
{"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f9453d6a267d7f02a70deeba80f97c2a6c18da2e","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"        cn \u003d self.rt.compute_nodes[_NODENAME]"},{"line_number":2595,"context_line":"        # Call the method."},{"line_number":2596,"context_line":"        self.rt._remove_deleted_instances_allocations(mock.sentinel.ctx, cn)"},{"line_number":2597,"context_line":"        # We don\u0027t delete the allocation because we\u0027re not sure what to do."},{"line_number":2598,"context_line":"        rc.delete_allocation_for_instance.assert_not_called()"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"    def test_delete_allocation_for_shelve_offloaded_instance(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_dadc0b76","line":2597,"updated":"2017-08-23 19:10:08.000000000","message":"it\u0027s good for this test to exist because it confirms the behavior in the existing code, but you should add a NOTE or TODO to indicate that that behavior is not actually what we want and that at some point, when we figure out how to be smart here, this test may start failing and that is a good sign.","commit_id":"44a2ae4bda95f63262bf5f0e01cb19cd559b0b02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cc6887b6b763f759c30f33ba69ee1d77b8e0437a","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"        cn \u003d self.rt.compute_nodes[_NODENAME]"},{"line_number":2595,"context_line":"        # Call the method."},{"line_number":2596,"context_line":"        self.rt._remove_deleted_instances_allocations(mock.sentinel.ctx, cn)"},{"line_number":2597,"context_line":"        # We don\u0027t delete the allocation because we\u0027re not sure what to do."},{"line_number":2598,"context_line":"        rc.delete_allocation_for_instance.assert_not_called()"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"    def test_delete_allocation_for_shelve_offloaded_instance(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_95c5343f","line":2597,"in_reply_to":"7f287b81_dadc0b76","updated":"2017-08-23 20:21:10.000000000","message":"Done","commit_id":"44a2ae4bda95f63262bf5f0e01cb19cd559b0b02"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4638700650044b105004873bdf8514effc704f00","unresolved":false,"context_lines":[{"line_number":2595,"context_line":"        # Call the method."},{"line_number":2596,"context_line":"        self.rt._remove_deleted_instances_allocations(mock.sentinel.ctx, cn)"},{"line_number":2597,"context_line":"        # We don\u0027t delete the allocation because we\u0027re not sure what to do."},{"line_number":2598,"context_line":"        # NOTE(mriedem): This is not actually the behavior we want. This is"},{"line_number":2599,"context_line":"        # testing the current behavior but in the future when we get smart"},{"line_number":2600,"context_line":"        # and figure things out, this should actually be an error."},{"line_number":2601,"context_line":"        rc.delete_allocation_for_instance.assert_not_called()"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"    def test_delete_allocation_for_shelve_offloaded_instance(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_74f5e682","line":2600,"range":{"start_line":2598,"start_character":8,"end_line":2600,"end_character":66},"updated":"2017-09-26 17:43:44.000000000","message":"nice NOTE for distinguishing both additional tests.","commit_id":"e3b7f43e3ae9689967d2ecd1cd7974d829c78c85"}]}